-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-align colorcontrol cluster definition with the spec #18700
Merged
jmartinez-silabs
merged 3 commits into
project-chip:master
from
jmartinez-silabs:cc_toSpec
May 24, 2022
Merged
Re-align colorcontrol cluster definition with the spec #18700
jmartinez-silabs
merged 3 commits into
project-chip:master
from
jmartinez-silabs:cc_toSpec
May 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #18700: Size comparison from 55ef609 to 5b88c90 Increases (3 builds for linux)
Decreases (3 builds for linux)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
May 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
pullapprove
bot
requested review from
andy31415,
arkq,
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
hawk248,
harsha-rajendran,
jelderton,
jepenven-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
robszewczyk,
saurabhst,
selissia and
tcarmelveilleux
May 21, 2022 01:33
pullapprove
bot
requested review from
tecimovic,
tehampson,
turon,
vijs,
wbschiller,
xylophone21 and
yunhanw-google
May 21, 2022 01:33
selissia
approved these changes
May 23, 2022
…control server implementation
jmartinez-silabs
force-pushed
the
cc_toSpec
branch
from
May 23, 2022 22:04
5b88c90
to
745807f
Compare
PR #18700: Size comparison from 8c47582 to 745807f Increases (3 builds for linux)
Decreases (3 builds for linux)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fixes #12372
Change overview
commit 1
Commit 2
Testing
Build a few examples and chip-tool locally.
CI can test against regression through Test_TC_CC_X_X and confirm build for all apps.