Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorTemperature attribute name and command field is not aligned with spec #12372

Closed
joesena-amz opened this issue Nov 30, 2021 · 2 comments · Fixed by #18700
Closed

ColorTemperature attribute name and command field is not aligned with spec #12372

joesena-amz opened this issue Nov 30, 2021 · 2 comments · Fixed by #18700
Assignees
Labels
app-clusters Application cluster work spec Mismatch between spec and implementation V1.0

Comments

@joesena-amz
Copy link

joesena-amz commented Nov 30, 2021

Problem

The color temperature value name is misaligned between chip-tool/chip-device-ctrl and the specification.

Spec: ColorTemperatureMireds
image

Chip-tool:

Usage:
  ./chip-tool colorcontrol read attribute-name [param1 param2 ...]

  +-------------------------------------------------------------------------------------+
  | Attributes:                                                                         |
  +-------------------------------------------------------------------------------------+
  | * current-hue                                                                       |
  | * current-saturation                                                                |
  | * remaining-time                                                                    |
  | * current-x                                                                         |
  | * current-y                                                                         |
  | * drift-compensation                                                                |
  | * compensation-text                                                                 |
  | * color-temperature                                                                 |
  | * color-mode                                                                        |
  | * color-control-options                                                             |
  | * number-of-primaries                                                               |
  | * primary1x                                                                         |
  | * primary1y                                                                         |
  | * primary1intensity                                                                 |
  | * primary2x                                                                         |
  | * primary2y                                                                         |
  | * primary2intensity                                                                 |
  | * primary3x                                                                         |
  | * primary3y                                                                         |
  | * primary3intensity                                                                 |
  | * primary4x                                                                         |
  | * primary4y                                                                         |
  | * primary4intensity                                                                 |
  | * primary5x                                                                         |
  | * primary5y                                                                         |
  | * primary5intensity                                                                 |
  | * primary6x                                                                         |
  | * primary6y                                                                         |
  | * primary6intensity                                                                 |
  | * white-point-x                                                                     |
  | * white-point-y                                                                     |
  | * color-point-rx                                                                    |
  | * color-point-ry                                                                    |
  | * color-point-rintensity                                                            |
  | * color-point-gx                                                                    |
  | * color-point-gy                                                                    |
  | * color-point-gintensity                                                            |
  | * color-point-bx                                                                    |
  | * color-point-by                                                                    |
  | * color-point-bintensity                                                            |
  | * enhanced-current-hue                                                              |
  | * enhanced-color-mode                                                               |
  | * color-loop-active                                                                 |
  | * color-loop-direction                                                              |
  | * color-loop-time                                                                   |
  | * color-loop-start-enhanced-hue                                                     |
  | * color-loop-stored-enhanced-hue                                                    |
  | * color-capabilities                                                                |
  | * color-temp-physical-min                                                           |
  | * color-temp-physical-max                                                           |
  | * couple-color-temp-to-level-min-mireds                                             |
  | * start-up-color-temperature-mireds                                                 |
  | * cluster-revision                                                                  |
  +-------------------------------------------------------------------------------------+

Associated test plans issue: https://github.com/CHIP-Specifications/chip-test-plans/issues/381

Proposed Solution

Change the spec or align the attribute name with the spec in chip-tool.

@andy31415 andy31415 added v1_triage_split_2 V1.0 spec Mismatch between spec and implementation and removed V1.0 v1_triage_split_2 labels Jan 30, 2022
@bzbarsky-apple bzbarsky-apple changed the title ColorTemperature attribute name is not aligned with spec ColorTemperature attribute name and command field is not aligned with spec Apr 18, 2022
@bzbarsky-apple bzbarsky-apple added the app-clusters Application cluster work label Apr 18, 2022
@bzbarsky-apple
Copy link
Contributor

Just to be clear, the issue is that the cluster XML does not match the spec...

@bzbarsky-apple
Copy link
Contributor

@jmartinez-silabs Could you take a look at aligning the XML with the spec here? There are all sorts of differences (e.g. the spec has "CurrentY" and the XML has "current y"...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-clusters Application cluster work spec Mismatch between spec and implementation V1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants