-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update matter IDL to contain per-endpoint attribute storage and defaults #18053
Merged
andy31415
merged 21 commits into
project-chip:master
from
andy31415:per_endpoint_storage_info
May 6, 2022
Merged
Update matter IDL to contain per-endpoint attribute storage and defaults #18053
andy31415
merged 21 commits into
project-chip:master
from
andy31415:per_endpoint_storage_info
May 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndpoint attribute configurations
…ld up endpoint data
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro and
Damian-Nordic
May 4, 2022 18:34
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
May 4, 2022 18:34
Note: this depends on #18046 (includes the latest zap pull) |
PR #18053: Size comparison from 51d67c4 to b478fa6 Full report (18 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #18053: Size comparison from 9aeecb3 to f9d466f Full report (8 builds for cyw30739, linux, mbed, nrfconnect, telink)
|
PR #18053: Size comparison from cd6844e to 38ecb79 Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
May 5, 2022
PR #18053: Size comparison from 498be03 to fe1aa5f Full report (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tehampson
reviewed
May 5, 2022
tehampson
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need to codereview storage data. Specifically seeing featuremap defaults and cluster revisions in a reviewable manner is very useful.
Change overview
Update endpoint information to contain storage and defaults as a section. Updated docs, unit tests and parsers. They look like:
Testing