Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull latest zap #18046

Merged
merged 2 commits into from
May 4, 2022
Merged

Pull latest zap #18046

merged 2 commits into from
May 4, 2022

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented May 4, 2022 •
edited
Loading

Problem

Update zap to latest

Change overview

RAN:

cd third_party/zap/repo/
git fetch https://github.com/project-chip/zap.git master
git checkout FETCH_HEAD

Also updated the zap template workflow to use a newer image of the zap dockerfile (moved to 0.5.70)

Testing

CI will validate that no file generation differences will occur.

@github-actions
Copy link

github-actions bot commented May 4, 2022 •
edited
Loading

PR #18046: Size comparison from efca638 to c8fe4e7

Full report (18 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section efca638 c8fe4e7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689155 689155 0 0.0
(read/write) 163132 163132 0 0.0
.bss 75268 75268 0 0.0
.data 3412 3412 0 0.0
.rodata 102371 102371 0 0.0
.text 586300 586300 0 0.0
lock-ftd LP_CC2652R7 (read only) 677047 677047 0 0.0
(read/write) 166496 166496 0 0.0
.bss 73580 73580 0 0.0
.data 3236 3236 0 0.0
.rodata 94439 94439 0 0.0
.text 582128 582128 0 0.0
lock-mtd LP_CC2652R7 (read only) 625799 625799 0 0.0
(read/write) 146396 146396 0 0.0
.bss 69300 69300 0 0.0
.data 3236 3236 0 0.0
.rodata 94327 94327 0 0.0
.text 530984 530984 0 0.0
pump-app LP_CC2652R7 (read only) 661567 661567 0 0.0
(read/write) 183216 183216 0 0.0
.bss 73796 73796 0 0.0
.data 3268 3268 0 0.0
.rodata 80479 80479 0 0.0
.text 580604 580604 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654491 654491 0 0.0
(read/write) 190092 190092 0 0.0
.bss 73852 73852 0 0.0
.data 3232 3232 0 0.0
.rodata 83435 83435 0 0.0
.text 570572 570572 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626434 626434 0 0.0
.app_xip_area 528936 528936 0 0.0
.bss 80140 80140 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625154 625154 0 0.0
.app_xip_area 529112 529112 0 0.0
.bss 78716 78716 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574254 574254 0 0.0
.app_xip_area 468592 468592 0 0.0
.bss 88040 88040 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 684260 684260 0 0.0
.bss 81336 81336 0 0.0
.data 2020 2020 0 0.0
.text 599200 599200 0 0.0
lock k32w061+release (read/write) 729108 729108 0 0.0
.bss 81768 81768 0 0.0
.data 1980 1980 0 0.0
.text 643656 643656 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8817700 8817700 0 0.0
(read/write) 642641 642641 0 0.0
.bss 40913 40913 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 581752 581752 0 0.0
.dynamic 560 560 0 0.0
.got 14960 14960 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 431460 431460 0 0.0
.text 6927732 6927732 0 0.0
thermostat-no-ble arm64 (read only) 2361540 2361540 0 0.0
(read/write) 174689 174689 0 0.0
.bss 86289 86289 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79088 79088 0 0.0
.dynamic 560 560 0 0.0
.got 4752 4752 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 145940 145940 0 0.0
.text 1986304 1986304 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418204 2418204 0 0.0
.bss 205908 205908 0 0.0
.data 5872 5872 0 0.0
.text 1380804 1380804 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177715 1177715 0 0.0
bss 139624 139624 0 0.0
rodata 150820 150820 0 0.0
text 808636 808636 0 0.0
p6 all-clusters-app default (read/write) 2528896 2528896 0 0.0
.bss 139272 139272 0 0.0
.data 2808 2808 0 0.0
.text 1487160 1487160 0 0.0
light-app default (read/write) 2419488 2419488 0 0.0
.bss 132736 132736 0 0.0
.data 2608 2608 0 0.0
.text 1377752 1377752 0 0.0
lock-app default (read/write) 2428784 2428784 0 0.0
.bss 132560 132560 0 0.0
.data 2568 2568 0 0.0
.text 1387048 1387048 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 804536 804536 0 0.0
bss 72260 72260 0 0.0
noinit 40416 40416 0 0.0
text 571294 571294 0 0.0

@github-actions
Copy link

github-actions bot commented May 4, 2022 •
edited
Loading

PR #18046: Size comparison from efca638 to 454c9c9

Increases (7 builds for cc13x2_26x2, cyw30739, linux)
platform target config section efca638 454c9c9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 163132 163344 212 0.1
lock-ftd LP_CC2652R7 (read/write) 166496 166716 220 0.1
pump-app LP_CC2652R7 (read/write) 183216 183460 244 0.1
pump-controller-app LP_CC2652R7 (read/write) 190092 190328 236 0.1
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574254 574266 12 0.0
.app_xip_area 468592 468604 12 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8817700 8817796 96 0.0
.data.rel.ro 581752 581760 8 0.0
.text 6927732 6927796 64 0.0
thermostat-no-ble arm64 .data.rel.ro 79088 79096 8 0.0
.text 1986304 1986368 64 0.0
Decreases (18 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section efca638 454c9c9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689155 688855 -300 -0.0
.bss 75268 75180 -88 -0.1
.rodata 102371 102127 -244 -0.2
.text 586300 586244 -56 -0.0
lock-ftd LP_CC2652R7 (read only) 677047 676731 -316 -0.0
.bss 73580 73484 -96 -0.1
.rodata 94439 94195 -244 -0.3
.text 582128 582056 -72 -0.0
lock-mtd LP_CC2652R7 (read only) 625799 625483 -316 -0.1
(read/write) 146396 146300 -96 -0.1
.bss 69300 69204 -96 -0.1
.rodata 94327 94083 -244 -0.3
.text 530984 530912 -72 -0.0
pump-app LP_CC2652R7 (read only) 661567 661283 -284 -0.0
.bss 73796 73756 -40 -0.1
.rodata 80479 80275 -204 -0.3
.text 580604 580524 -80 -0.0
pump-controller-app LP_CC2652R7 (read only) 654491 654215 -276 -0.0
.bss 73852 73812 -40 -0.1
.rodata 83435 83231 -204 -0.2
.text 570572 570500 -72 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626434 626038 -396 -0.1
.app_xip_area 528936 528628 -308 -0.1
.bss 80140 80052 -88 -0.1
lock cyw930739m2evb_01 (read/write) 625154 624750 -404 -0.1
.app_xip_area 529112 528804 -308 -0.1
.bss 78716 78620 -96 -0.1
esp32 all-clusters-app c3devkit (read only) 999734 999640 -94 -0.0
(read/write) 1474570 1474226 -344 -0.0
.dram0.bss 68408 68320 -88 -0.1
.flash.rodata 207264 207016 -248 -0.1
.flash.text 999734 999640 -94 -0.0
m5stack (read only) 1054927 1054847 -80 -0.0
(read/write) 476984 476648 -336 -0.1
.dram0.bss 73928 73832 -96 -0.1
.flash.rodata 237036 236796 -240 -0.1
.flash.text 1049543 1049463 -80 -0.0
k32w light k32w061+release (read/write) 684260 684032 -228 -0.0
.bss 81336 81248 -88 -0.1
.text 599200 599060 -140 -0.0
lock k32w061+release (read/write) 729108 728712 -396 -0.1
.bss 81768 81680 -88 -0.1
.text 643656 643348 -308 -0.0
linux thermostat-no-ble arm64 (read only) 2361540 2361244 -296 -0.0
(read/write) 174689 174593 -96 -0.1
.bss 86289 86193 -96 -0.1
.rodata 145940 145868 -72 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2418204 2417836 -368 -0.0
.bss 205908 205820 -88 -0.0
.text 1380804 1380436 -368 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177715 1177411 -304 -0.0
bss 139624 139532 -92 -0.1
rodata 150820 150580 -240 -0.2
text 808636 808568 -68 -0.0
p6 all-clusters-app default (read/write) 2528896 2528592 -304 -0.0
.bss 139272 139184 -88 -0.1
.text 1487160 1486856 -304 -0.0
light-app default (read/write) 2419488 2419160 -328 -0.0
.bss 132736 132648 -88 -0.1
.text 1377752 1377424 -328 -0.0
lock-app default (read/write) 2428784 2428448 -336 -0.0
.bss 132560 132472 -88 -0.1
.text 1387048 1386712 -336 -0.0
telink lighting-app tlsr9518adk80d (read/write) 804536 804104 -432 -0.1
bss 72260 72172 -88 -0.1
text 571294 571200 -94 -0.0
Full report (20 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section efca638 454c9c9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689155 688855 -300 -0.0
(read/write) 163132 163344 212 0.1
.bss 75268 75180 -88 -0.1
.data 3412 3412 0 0.0
.rodata 102371 102127 -244 -0.2
.text 586300 586244 -56 -0.0
lock-ftd LP_CC2652R7 (read only) 677047 676731 -316 -0.0
(read/write) 166496 166716 220 0.1
.bss 73580 73484 -96 -0.1
.data 3236 3236 0 0.0
.rodata 94439 94195 -244 -0.3
.text 582128 582056 -72 -0.0
lock-mtd LP_CC2652R7 (read only) 625799 625483 -316 -0.1
(read/write) 146396 146300 -96 -0.1
.bss 69300 69204 -96 -0.1
.data 3236 3236 0 0.0
.rodata 94327 94083 -244 -0.3
.text 530984 530912 -72 -0.0
pump-app LP_CC2652R7 (read only) 661567 661283 -284 -0.0
(read/write) 183216 183460 244 0.1
.bss 73796 73756 -40 -0.1
.data 3268 3268 0 0.0
.rodata 80479 80275 -204 -0.3
.text 580604 580524 -80 -0.0
pump-controller-app LP_CC2652R7 (read only) 654491 654215 -276 -0.0
(read/write) 190092 190328 236 0.1
.bss 73852 73812 -40 -0.1
.data 3232 3232 0 0.0
.rodata 83435 83231 -204 -0.2
.text 570572 570500 -72 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626434 626038 -396 -0.1
.app_xip_area 528936 528628 -308 -0.1
.bss 80140 80052 -88 -0.1
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625154 624750 -404 -0.1
.app_xip_area 529112 528804 -308 -0.1
.bss 78716 78620 -96 -0.1
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574254 574266 12 0.0
.app_xip_area 468592 468604 12 0.0
.bss 88040 88040 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 999734 999640 -94 -0.0
(read/write) 1474570 1474226 -344 -0.0
.dram0.bss 68408 68320 -88 -0.1
.dram0.data 14444 14444 0 0.0
.flash.rodata 207264 207016 -248 -0.1
.flash.text 999734 999640 -94 -0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1054927 1054847 -80 -0.0
(read/write) 476984 476648 -336 -0.1
.dram0.bss 73928 73832 -96 -0.1
.dram0.data 34184 34184 0 0.0
.flash.rodata 237036 236796 -240 -0.1
.flash.text 1049543 1049463 -80 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684260 684032 -228 -0.0
.bss 81336 81248 -88 -0.1
.data 2020 2020 0 0.0
.text 599200 599060 -140 -0.0
lock k32w061+release (read/write) 729108 728712 -396 -0.1
.bss 81768 81680 -88 -0.1
.data 1980 1980 0 0.0
.text 643656 643348 -308 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8817700 8817796 96 0.0
(read/write) 642641 642641 0 0.0
.bss 40913 40913 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 581752 581760 8 0.0
.dynamic 560 560 0 0.0
.got 14960 14960 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 431460 431460 0 0.0
.text 6927732 6927796 64 0.0
thermostat-no-ble arm64 (read only) 2361540 2361244 -296 -0.0
(read/write) 174689 174593 -96 -0.1
.bss 86289 86193 -96 -0.1
.data 1520 1520 0 0.0
.data.rel.ro 79088 79096 8 0.0
.dynamic 560 560 0 0.0
.got 4752 4752 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 145940 145868 -72 -0.0
.text 1986304 1986368 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418204 2417836 -368 -0.0
.bss 205908 205820 -88 -0.0
.data 5872 5872 0 0.0
.text 1380804 1380436 -368 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177715 1177411 -304 -0.0
bss 139624 139532 -92 -0.1
rodata 150820 150580 -240 -0.2
text 808636 808568 -68 -0.0
p6 all-clusters-app default (read/write) 2528896 2528592 -304 -0.0
.bss 139272 139184 -88 -0.1
.data 2808 2808 0 0.0
.text 1487160 1486856 -304 -0.0
light-app default (read/write) 2419488 2419160 -328 -0.0
.bss 132736 132648 -88 -0.1
.data 2608 2608 0 0.0
.text 1377752 1377424 -328 -0.0
lock-app default (read/write) 2428784 2428448 -336 -0.0
.bss 132560 132472 -88 -0.1
.data 2568 2568 0 0.0
.text 1387048 1386712 -336 -0.0
telink lighting-app tlsr9518adk80d (read/write) 804536 804104 -432 -0.1
bss 72260 72172 -88 -0.1
noinit 40416 40416 0 0.0
text 571294 571200 -94 -0.0

@andy31415 andy31415 mentioned this pull request May 4, 2022
Merged
@andy31415 andy31415 merged commit cd6844e into project-chip:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkq arkq arkq approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track github review - pending workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy31415 @arkq