Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sleepy] Rename sleepy params per spec. #17927

Merged
merged 5 commits into from
May 9, 2022
Merged

[sleepy] Rename sleepy params per spec. #17927

merged 5 commits into from
May 9, 2022

Conversation

turon
Copy link
Contributor

@turon turon commented Apr 29, 2022

Problem

Update sleepy parameters per https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5092
Fixes #17220

Change overview

Initial rename of CRA/CRI discovery params --> SAI/SII.

Testing

CI

@restyled-io restyled-io bot mentioned this pull request Apr 29, 2022
Closed
@github-actions
Copy link

github-actions bot commented Apr 29, 2022 •
edited
Loading

PR #17927: Size comparison from ad2520a to 06347c3

Full report (31 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, p6, telink)
platform target config section ad2520a 06347c3 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689511 689511 0 0.0
(read/write) 162744 162744 0 0.0
.bss 75236 75236 0 0.0
.data 3400 3400 0 0.0
.rodata 102303 102303 0 0.0
.text 586724 586724 0 0.0
lock-ftd LP_CC2652R7 (read only) 677303 677303 0 0.0
(read/write) 166208 166208 0 0.0
.bss 73548 73548 0 0.0
.data 3224 3224 0 0.0
.rodata 94359 94359 0 0.0
.text 582464 582464 0 0.0
lock-mtd LP_CC2652R7 (read only) 626047 626047 0 0.0
(read/write) 146352 146352 0 0.0
.bss 69268 69268 0 0.0
.data 3224 3224 0 0.0
.rodata 94247 94247 0 0.0
.text 531312 531312 0 0.0
pump-app LP_CC2652R7 (read only) 661955 661955 0 0.0
(read/write) 182796 182796 0 0.0
.bss 73764 73764 0 0.0
.data 3256 3256 0 0.0
.rodata 80499 80499 0 0.0
.text 580972 580972 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654795 654795 0 0.0
(read/write) 189756 189756 0 0.0
.bss 73820 73820 0 0.0
.data 3220 3220 0 0.0
.rodata 83435 83435 0 0.0
.text 570876 570876 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626898 626898 0 0.0
.app_xip_area 529432 529432 0 0.0
.bss 80116 80116 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625594 625594 0 0.0
.app_xip_area 529592 529592 0 0.0
.bss 78692 78692 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574722 574722 0 0.0
.app_xip_area 469100 469100 0 0.0
.bss 88016 88016 0 0.0
.data 572 572 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 908936 908936 0 0.0
(read/write) 135128 135128 0 0.0
.bss 133072 133072 0 0.0
.data 2052 2052 0 0.0
.text 908928 908928 0 0.0
BRD4161A+rpc (read only) 943280 943280 0 0.0
(read/write) 151808 151808 0 0.0
.bss 149552 149552 0 0.0
.data 2256 2256 0 0.0
.text 943272 943272 0 0.0
BRD4161A+rs911x (read only) 747260 747260 0 0.0
(read/write) 129352 129352 0 0.0
.bss 127372 127372 0 0.0
.data 1980 1980 0 0.0
.text 747252 747252 0 0.0
lock-app BRD4161A+wf200 (read only) 917184 917184 0 0.0
(read/write) 127540 127540 0 0.0
.bss 125604 125604 0 0.0
.data 1936 1936 0 0.0
.text 917176 917176 0 0.0
window-app BRD4161A (read only) 846168 846168 0 0.0
(read/write) 133216 133216 0 0.0
.bss 131248 131248 0 0.0
.data 1964 1964 0 0.0
.text 846160 846160 0 0.0
k32w light k32w061+release (read/write) 684860 684860 0 0.0
.bss 81320 81320 0 0.0
.data 2008 2008 0 0.0
.text 599828 599828 0 0.0
lock k32w061+release (read/write) 729676 729676 0 0.0
.bss 81744 81744 0 0.0
.data 1968 1968 0 0.0
.text 644260 644260 0 0.0
linux all-clusters-app debug (read only) 2732721 2732721 0 0.0
(read/write) 173336 173336 0 0.0
.bss 83584 83584 0 0.0
.data 1968 1968 0 0.0
.data.rel.ro 81656 81656 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 234981 234981 0 0.0
.text 2323138 2323138 0 0.0
bridge-app debug+rpc (read only) 1887905 1887905 0 0.0
(read/write) 120664 120664 0 0.0
.bss 71584 71584 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40312 40312 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 160417 160417 0 0.0
.text 1605090 1605090 0 0.0
chip-tool debug (read only) 8852773 8852773 0 0.0
(read/write) 550704 550704 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 520488 520488 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 462581 462581 0 0.0
.text 7127525 7127525 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8694996 8694996 0 0.0
(read/write) 616497 616497 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 555648 555648 0 0.0
.dynamic 560 560 0 0.0
.got 14736 14736 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 429860 429860 0 0.0
.text 6867892 6867892 0 0.0
lighting-app debug+rpc (read only) 2322281 2322281 0 0.0
(read/write) 151616 151616 0 0.0
.bss 73632 73632 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70248 70248 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184553 184553 0 0.0
.text 1971474 1971474 0 0.0
lock-app debug (read only) 2228657 2228657 0 0.0
(read/write) 146200 146200 0 0.0
.bss 72256 72256 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 194353 194353 0 0.0
.text 1874402 1874402 0 0.0
ota-provider-app debug (read only) 2056961 2056961 0 0.0
(read/write) 139216 139216 0 0.0
.bss 71648 71648 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60104 60104 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 175099 175099 0 0.0
.text 1724738 1724738 0 0.0
ota-requestor-app debug (read only) 2088065 2088065 0 0.0
(read/write) 142024 142024 0 0.0
.bss 72288 72288 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171372 171372 0 0.0
.text 1758082 1758082 0 0.0
shell debug (read only) 2557913 2557913 0 0.0
(read/write) 197328 197328 0 0.0
.bss 114312 114312 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 75920 75920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 216722 216722 0 0.0
.text 2179666 2179666 0 0.0
thermostat-no-ble arm64 (read only) 2367732 2367732 0 0.0
(read/write) 174801 174801 0 0.0
.bss 86481 86481 0 0.0
.data 1496 1496 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146100 146100 0 0.0
.text 1992480 1992480 0 0.0
tv-app debug (read only) 2840625 2840625 0 0.0
(read/write) 276832 276832 0 0.0
.bss 189496 189496 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76456 76456 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217099 217099 0 0.0
.text 2441474 2441474 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418892 2418892 0 0.0
.bss 205884 205884 0 0.0
.data 5856 5856 0 0.0
.text 1381492 1381492 0 0.0
p6 all-clusters-app default (read/write) 2529352 2529352 0 0.0
.bss 139256 139256 0 0.0
.data 2792 2792 0 0.0
.text 1487616 1487616 0 0.0
light-app default (read/write) 2419912 2419912 0 0.0
.bss 132720 132720 0 0.0
.data 2592 2592 0 0.0
.text 1378176 1378176 0 0.0
lock-app default (read/write) 2429192 2429192 0 0.0
.bss 132544 132544 0 0.0
.data 2552 2552 0 0.0
.text 1387456 1387456 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 808144 808144 0 0.0
bss 75432 75432 0 0.0
noinit 40416 40416 0 0.0
text 571822 571822 0 0.0

tcarmelveilleux
tcarmelveilleux previously requested changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@tcarmelveilleux tcarmelveilleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes requested, but putting this merge gate until the spec PR is merged. We should not implement in SDK until spec PR merges.

@turon turon mentioned this pull request May 3, 2022
Open
@github-actions
Copy link

github-actions bot commented May 3, 2022 •
edited
Loading

PR #17927: Size comparison from caa1d6b to 5f545d8

Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section caa1d6b 5f545d8 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 688967 688967 0 0.0
(read/write) 163320 163320 0 0.0
.bss 75268 75268 0 0.0
.data 3404 3404 0 0.0
.rodata 102343 102343 0 0.0
.text 586140 586140 0 0.0
lock-ftd LP_CC2652R7 (read only) 676823 676823 0 0.0
(read/write) 166720 166720 0 0.0
.bss 73580 73580 0 0.0
.data 3228 3228 0 0.0
.rodata 94399 94399 0 0.0
.text 581944 581944 0 0.0
lock-mtd LP_CC2652R7 (read only) 625575 625575 0 0.0
(read/write) 146388 146388 0 0.0
.bss 69300 69300 0 0.0
.data 3228 3228 0 0.0
.rodata 94287 94287 0 0.0
.text 530800 530800 0 0.0
pump-app LP_CC2652R7 (read only) 661387 661387 0 0.0
(read/write) 183396 183396 0 0.0
.bss 73796 73796 0 0.0
.data 3260 3260 0 0.0
.rodata 80451 80451 0 0.0
.text 580452 580452 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654283 654283 0 0.0
(read/write) 190300 190300 0 0.0
.bss 73852 73852 0 0.0
.data 3224 3224 0 0.0
.rodata 83395 83395 0 0.0
.text 570404 570404 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626218 626218 0 0.0
.app_xip_area 528736 528736 0 0.0
.bss 80132 80132 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 624930 624930 0 0.0
.app_xip_area 528904 528904 0 0.0
.bss 78708 78708 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574050 574050 0 0.0
.app_xip_area 468404 468404 0 0.0
.bss 88032 88032 0 0.0
.data 576 576 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 908432 908432 0 0.0
(read/write) 134592 134592 0 0.0
.bss 132536 132536 0 0.0
.data 2056 2056 0 0.0
.text 908424 908424 0 0.0
BRD4161A+rpc (read only) 942792 942792 0 0.0
(read/write) 151280 151280 0 0.0
.bss 149016 149016 0 0.0
.data 2260 2260 0 0.0
.text 942784 942784 0 0.0
BRD4161A+rs911x (read only) 746628 746628 0 0.0
(read/write) 128772 128772 0 0.0
.bss 126788 126788 0 0.0
.data 1984 1984 0 0.0
.text 746620 746620 0 0.0
lock-app BRD4161A+wf200 (read only) 916392 916392 0 0.0
(read/write) 127564 127564 0 0.0
.bss 125620 125620 0 0.0
.data 1940 1940 0 0.0
.text 916384 916384 0 0.0
window-app BRD4161A (read only) 845696 845696 0 0.0
(read/write) 132680 132680 0 0.0
.bss 130712 130712 0 0.0
.data 1968 1968 0 0.0
.text 845688 845688 0 0.0
esp32 all-clusters-app c3devkit (read only) 999538 999538 0 0.0
(read/write) 1474498 1474498 0 0.0
.dram0.bss 68400 68400 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 207224 207224 0 0.0
.flash.text 999538 999538 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1054727 1054727 0 0.0
(read/write) 476928 476928 0 0.0
.dram0.bss 73920 73920 0 0.0
.dram0.data 34176 34176 0 0.0
.flash.rodata 236996 236996 0 0.0
.flash.text 1049343 1049343 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684104 684104 0 0.0
.bss 81336 81336 0 0.0
.data 2012 2012 0 0.0
.text 599052 599052 0 0.0
lock k32w061+release (read/write) 728904 728904 0 0.0
.bss 81760 81760 0 0.0
.data 1972 1972 0 0.0
.text 643468 643468 0 0.0
linux all-clusters-app debug (read only) 2729961 2729961 0 0.0
(read/write) 173144 173144 0 0.0
.bss 83360 83360 0 0.0
.data 2000 2000 0 0.0
.data.rel.ro 81656 81656 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 235173 235173 0 0.0
.text 2320162 2320162 0 0.0
bridge-app debug+rpc (read only) 1885025 1885025 0 0.0
(read/write) 120472 120472 0 0.0
.bss 71360 71360 0 0.0
.data 3456 3456 0 0.0
.data.rel.ro 40312 40312 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 160417 160417 0 0.0
.text 1602210 1602210 0 0.0
chip-tool debug (read only) 8977653 8977653 0 0.0
(read/write) 576464 576464 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546472 546472 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 463733 463733 0 0.0
.text 7190773 7190773 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8817700 8817700 0 0.0
(read/write) 642641 642641 0 0.0
.bss 40913 40913 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 581752 581752 0 0.0
.dynamic 560 560 0 0.0
.got 14960 14960 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 431460 431460 0 0.0
.text 6927732 6927732 0 0.0
lighting-app debug+rpc (read only) 2319433 2319433 0 0.0
(read/write) 151392 151392 0 0.0
.bss 73408 73408 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70248 70248 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184617 184617 0 0.0
.text 1968562 1968562 0 0.0
lock-app debug (read only) 2225649 2225649 0 0.0
(read/write) 145976 145976 0 0.0
.bss 72032 72032 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 194353 194353 0 0.0
.text 1871394 1871394 0 0.0
ota-provider-app debug (read only) 2054289 2054289 0 0.0
(read/write) 138992 138992 0 0.0
.bss 71424 71424 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60104 60104 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 175099 175099 0 0.0
.text 1722066 1722066 0 0.0
ota-requestor-app debug (read only) 2085345 2085345 0 0.0
(read/write) 141800 141800 0 0.0
.bss 72064 72064 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171372 171372 0 0.0
.text 1755362 1755362 0 0.0
shell debug (read only) 2555033 2555033 0 0.0
(read/write) 197104 197104 0 0.0
.bss 114088 114088 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 75920 75920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 216722 216722 0 0.0
.text 2176786 2176786 0 0.0
thermostat-no-ble arm64 (read only) 2360868 2360868 0 0.0
(read/write) 174609 174609 0 0.0
.bss 86289 86289 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 560 560 0 0.0
.got 4728 4728 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 145828 145828 0 0.0
.text 1985920 1985920 0 0.0
tv-app debug (read only) 2841633 2841633 0 0.0
(read/write) 276704 276704 0 0.0
.bss 189272 189272 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76552 76552 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217259 217259 0 0.0
.text 2442178 2442178 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2417972 2417972 0 0.0
.bss 205900 205900 0 0.0
.data 5864 5864 0 0.0
.text 1380572 1380572 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177523 1177523 0 0.0
bss 139620 139620 0 0.0
rodata 150780 150780 0 0.0
text 808492 808492 0 0.0
p6 all-clusters-app default (read/write) 2528656 2528656 0 0.0
.bss 139272 139272 0 0.0
.data 2800 2800 0 0.0
.text 1486920 1486920 0 0.0
light-app default (read/write) 2419256 2419256 0 0.0
.bss 132736 132736 0 0.0
.data 2600 2600 0 0.0
.text 1377520 1377520 0 0.0
lock-app default (read/write) 2428544 2428544 0 0.0
.bss 132560 132560 0 0.0
.data 2560 2560 0 0.0
.text 1386808 1386808 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 804352 804352 0 0.0
bss 72252 72252 0 0.0
noinit 40416 40416 0 0.0
text 571174 571174 0 0.0

@github-actions
Copy link

github-actions bot commented May 6, 2022 •
edited
Loading

PR #17927: Size comparison from 70dc49f to 16c2c56

Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 70dc49f 16c2c56 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690935 690935 0 0.0
(read/write) 161416 161416 0 0.0
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 102983 102983 0 0.0
.text 587468 587468 0 0.0
lock-ftd LP_CC2652R7 (read only) 678507 678507 0 0.0
(read/write) 164948 164948 0 0.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94771 94771 0 0.0
.text 583256 583256 0 0.0
lock-mtd LP_CC2652R7 (read only) 627259 627259 0 0.0
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94651 94651 0 0.0
.text 532120 532120 0 0.0
pump-app LP_CC2652R7 (read only) 663035 663035 0 0.0
(read/write) 181708 181708 0 0.0
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80971 80971 0 0.0
.text 581580 581580 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655943 655943 0 0.0
(read/write) 188600 188600 0 0.0
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 83911 83911 0 0.0
.text 571548 571548 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627586 627586 0 0.0
.app_xip_area 530176 530176 0 0.0
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626474 626474 0 0.0
.app_xip_area 530520 530520 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575234 575234 0 0.0
.app_xip_area 469564 469564 0 0.0
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 910096 910096 0 0.0
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 910088 910088 0 0.0
BRD4161A+rpc (read only) 944440 944440 0 0.0
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 944432 944432 0 0.0
BRD4161A+rs911x (read only) 787676 787676 0 0.0
(read/write) 129776 129776 0 0.0
.bss 127708 127708 0 0.0
.data 2068 2068 0 0.0
.text 787668 787668 0 0.0
lock-app BRD4161A+wf200 (read only) 946768 946768 0 0.0
(read/write) 124268 124268 0 0.0
.bss 122244 122244 0 0.0
.data 2024 2024 0 0.0
.text 946760 946760 0 0.0
window-app BRD4161A (read only) 886516 886516 0 0.0
(read/write) 134460 134460 0 0.0
.bss 132408 132408 0 0.0
.data 2052 2052 0 0.0
.text 886508 886508 0 0.0
esp32 all-clusters-app c3devkit (read only) 1001090 1001090 0 0.0
(read/write) 1475658 1475658 0 0.0
.dram0.bss 68464 68464 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 208304 208304 0 0.0
.flash.text 1001090 1001090 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1056031 1056031 0 0.0
(read/write) 478088 478088 0 0.0
.dram0.bss 73984 73984 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 238084 238084 0 0.0
.flash.text 1050647 1050647 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 685136 685136 0 0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 600164 600164 0 0.0
lock k32w061+release (read/write) 730468 730468 0 0.0
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 645104 645104 0 0.0
linux all-clusters-app debug (read only) 2740073 2740073 0 0.0
(read/write) 174264 174264 0 0.0
.bss 83680 83680 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82392 82392 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 236357 236357 0 0.0
.text 2328514 2328514 0 0.0
bridge-app debug+rpc (read only) 1894161 1894161 0 0.0
(read/write) 120984 120984 0 0.0
.bss 71520 71520 0 0.0
.data 3488 3488 0 0.0
.data.rel.ro 40648 40648 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 161593 161593 0 0.0
.text 1609714 1609714 0 0.0
chip-tool debug (read only) 9026661 9026661 0 0.0
(read/write) 576944 576944 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546728 546728 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 466133 466133 0 0.0
.text 7236709 7236709 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8856532 8856532 0 0.0
(read/write) 643137 643137 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582048 582048 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 433636 433636 0 0.0
.text 6963588 6963588 0 0.0
lighting-app debug+rpc (read only) 2328241 2328241 0 0.0
(read/write) 151936 151936 0 0.0
.bss 73568 73568 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70568 70568 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 185721 185721 0 0.0
.text 1975810 1975810 0 0.0
lock-app debug (read only) 2235537 2235537 0 0.0
(read/write) 146520 146520 0 0.0
.bss 72192 72192 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67080 67080 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 195465 195465 0 0.0
.text 1879714 1879714 0 0.0
ota-provider-app debug (read only) 2063865 2063865 0 0.0
(read/write) 139632 139632 0 0.0
.bss 71680 71680 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 176467 176467 0 0.0
.text 1729506 1729506 0 0.0
ota-requestor-app debug (read only) 2095041 2095041 0 0.0
(read/write) 142440 142440 0 0.0
.bss 72320 72320 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62504 62504 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172796 172796 0 0.0
.text 1762866 1762866 0 0.0
shell debug (read only) 2565049 2565049 0 0.0
(read/write) 198160 198160 0 0.0
.bss 114408 114408 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76656 76656 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217810 217810 0 0.0
.text 2185138 2185138 0 0.0
thermostat-no-ble arm64 (read only) 2368620 2368620 0 0.0
(read/write) 175121 175121 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79376 79376 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146844 146844 0 0.0
.text 1992032 1992032 0 0.0
tv-app debug (read only) 2850849 2850849 0 0.0
(read/write) 277248 277248 0 0.0
.bss 189464 189464 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76872 76872 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218411 218411 0 0.0
.text 2449762 2449762 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420084 2420084 0 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382684 1382684 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179787 1179787 0 0.0
bss 139680 139680 0 0.0
rodata 151532 151532 0 0.0
text 809856 809856 0 0.0
p6 all-clusters-app default (read/write) 2531536 2531536 0 0.0
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1489800 1489800 0 0.0
light-app default (read/write) 2421592 2421592 0 0.0
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1379856 1379856 0 0.0
lock-app default (read/write) 2431096 2431096 0 0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1389360 1389360 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806024 806024 0 0.0
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572426 572426 0 0.0

@restyled-io restyled-io bot mentioned this pull request May 6, 2022
Closed
@turon
Copy link
Contributor Author

turon commented May 6, 2022 •
edited
Loading

No changes requested, but putting this merge gate until the spec PR is merged. We should not implement in SDK until spec PR merges.

@tcarmelveilleux
Spec changes merged: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5092

@github-actions
Copy link

github-actions bot commented May 6, 2022 •
edited
Loading

PR #17927: Size comparison from 54a39d7 to fb1c4a4

Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 54a39d7 fb1c4a4 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690935 690935 0 0.0
(read/write) 161416 161416 0 0.0
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 102983 102983 0 0.0
.text 587468 587468 0 0.0
lock-ftd LP_CC2652R7 (read only) 678507 678507 0 0.0
(read/write) 164948 164948 0 0.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94771 94771 0 0.0
.text 583256 583256 0 0.0
lock-mtd LP_CC2652R7 (read only) 627259 627259 0 0.0
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94651 94651 0 0.0
.text 532120 532120 0 0.0
pump-app LP_CC2652R7 (read only) 663035 663035 0 0.0
(read/write) 181708 181708 0 0.0
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80971 80971 0 0.0
.text 581580 581580 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655943 655943 0 0.0
(read/write) 188600 188600 0 0.0
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 83911 83911 0 0.0
.text 571548 571548 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627586 627586 0 0.0
.app_xip_area 530176 530176 0 0.0
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626474 626474 0 0.0
.app_xip_area 530520 530520 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575234 575234 0 0.0
.app_xip_area 469564 469564 0 0.0
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 910096 910096 0 0.0
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 910088 910088 0 0.0
BRD4161A+rpc (read only) 944440 944440 0 0.0
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 944432 944432 0 0.0
BRD4161A+rs911x (read only) 787676 787676 0 0.0
(read/write) 129776 129776 0 0.0
.bss 127708 127708 0 0.0
.data 2068 2068 0 0.0
.text 787668 787668 0 0.0
lock-app BRD4161A+wf200 (read only) 946768 946768 0 0.0
(read/write) 124268 124268 0 0.0
.bss 122244 122244 0 0.0
.data 2024 2024 0 0.0
.text 946760 946760 0 0.0
window-app BRD4161A (read only) 886516 886516 0 0.0
(read/write) 134460 134460 0 0.0
.bss 132408 132408 0 0.0
.data 2052 2052 0 0.0
.text 886508 886508 0 0.0
esp32 all-clusters-app c3devkit (read only) 1001090 1001090 0 0.0
(read/write) 1475658 1475658 0 0.0
.dram0.bss 68464 68464 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 208304 208304 0 0.0
.flash.text 1001090 1001090 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1056031 1056031 0 0.0
(read/write) 478088 478088 0 0.0
.dram0.bss 73984 73984 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 238084 238084 0 0.0
.flash.text 1050647 1050647 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 685136 685136 0 0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 600164 600164 0 0.0
lock k32w061+release (read/write) 730468 730468 0 0.0
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 645104 645104 0 0.0
linux all-clusters-app debug (read only) 2740073 2740073 0 0.0
(read/write) 174264 174264 0 0.0
.bss 83680 83680 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82392 82392 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 236357 236357 0 0.0
.text 2328514 2328514 0 0.0
bridge-app debug+rpc (read only) 1894161 1894161 0 0.0
(read/write) 120984 120984 0 0.0
.bss 71520 71520 0 0.0
.data 3488 3488 0 0.0
.data.rel.ro 40648 40648 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 161593 161593 0 0.0
.text 1609714 1609714 0 0.0
chip-tool debug (read only) 9026661 9026661 0 0.0
(read/write) 576944 576944 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546728 546728 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 466133 466133 0 0.0
.text 7236709 7236709 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8856532 8856532 0 0.0
(read/write) 643137 643137 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582048 582048 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 433636 433636 0 0.0
.text 6963588 6963588 0 0.0
lighting-app debug+rpc (read only) 2328241 2328241 0 0.0
(read/write) 151936 151936 0 0.0
.bss 73568 73568 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70568 70568 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 185721 185721 0 0.0
.text 1975810 1975810 0 0.0
lock-app debug (read only) 2235537 2235537 0 0.0
(read/write) 146520 146520 0 0.0
.bss 72192 72192 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67080 67080 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 195465 195465 0 0.0
.text 1879714 1879714 0 0.0
ota-provider-app debug (read only) 2063865 2063865 0 0.0
(read/write) 139632 139632 0 0.0
.bss 71680 71680 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 176467 176467 0 0.0
.text 1729506 1729506 0 0.0
ota-requestor-app debug (read only) 2095041 2095041 0 0.0
(read/write) 142440 142440 0 0.0
.bss 72320 72320 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62504 62504 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172796 172796 0 0.0
.text 1762866 1762866 0 0.0
shell debug (read only) 2565049 2565049 0 0.0
(read/write) 198160 198160 0 0.0
.bss 114408 114408 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76656 76656 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217810 217810 0 0.0
.text 2185138 2185138 0 0.0
thermostat-no-ble arm64 (read only) 2368620 2368620 0 0.0
(read/write) 175121 175121 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79376 79376 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146844 146844 0 0.0
.text 1992032 1992032 0 0.0
tv-app debug (read only) 2850849 2850849 0 0.0
(read/write) 277248 277248 0 0.0
.bss 189464 189464 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76872 76872 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218411 218411 0 0.0
.text 2449762 2449762 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420084 2420084 0 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382684 1382684 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179787 1179787 0 0.0
bss 139680 139680 0 0.0
rodata 151532 151532 0 0.0
text 809856 809856 0 0.0
p6 all-clusters-app default (read/write) 2531536 2531536 0 0.0
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1489800 1489800 0 0.0
light-app default (read/write) 2421592 2421592 0 0.0
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1379856 1379856 0 0.0
lock-app default (read/write) 2431096 2431096 0 0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1389360 1389360 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806024 806024 0 0.0
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572426 572426 0 0.0

@andy31415 andy31415 dismissed tcarmelveilleux’s stale review May 9, 2022 19:41

Spec changes were merged.

@andy31415 andy31415 merged commit afb7ccb into project-chip:master May 9, 2022
@andy31415 andy31415 mentioned this pull request May 11, 2022
Merged
@turon turon mentioned this pull request May 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@andy31415 andy31415 Awaiting requested review from andy31415

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@msandstedt msandstedt Awaiting requested review from msandstedt

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

Assignees
No one assigned
Labels
app controller lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sleepy] Update CRI/CRA naming per recent spec updates.
5 participants
@turon @tcarmelveilleux @andy31415 @msandstedt @bzbarsky-apple