Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sleepy] Complete internal rename of active/idle parameters #17999

Open
turon opened this issue May 3, 2022 · 3 comments
Open

[sleepy] Complete internal rename of active/idle parameters #17999

turon opened this issue May 3, 2022 · 3 comments

Comments

@turon
Copy link
Contributor

turon commented May 3, 2022 •
edited
Loading

Remove MRP (retrans) terminology from mIdleRetransTimeout and mActiveRetransTimeout and rename to a polling interval.

I assume there will be a followup to rename mIdleRetransTimeout to something that more closely matches what this actually is?

Originally posted by @bzbarsky-apple in #17927 (comment)
@turon turon mentioned this issue May 3, 2022
Merged
@turon
Copy link
Contributor Author

turon commented May 6, 2022 •
edited
Loading

Initial list of symbols with legacy naming to be updated:

  • mActiveRetransTimeout
  • mIdleRetransTimeout
  • mrpRetryIntervalActiveBuf
  • mrpRetryIntervalActiveBuf

@stale
Copy link

stale bot commented Nov 4, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Nov 4, 2022
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Nov 4, 2022
@stale
Copy link

stale bot commented May 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label May 3, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turon @bzbarsky-apple