-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Reboot command for chip-tool-darwin. #17854
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:implement-reboot-chip-tool-darwin
Apr 29, 2022
Merged
Implement Reboot command for chip-tool-darwin. #17854
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:implement-reboot-chip-tool-darwin
Apr 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables a few tests that needed Reboot to be enabled. Aligns the general test list better with chip-tool, so it's easier to see what's still missing/disabled. Fixes project-chip#16514
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
April 28, 2022 20:05
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
April 28, 2022 20:05
krypton36
approved these changes
Apr 28, 2022
PR #17854: Size comparison from 0ff0b15 to 5efc571 Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #17854: Size comparison from 0ff0b15 to 3f354d8 Increases (5 builds for cc13x2_26x2, linux)
Decreases (29 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Fast-tracking platform-specific test additions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables a few tests that needed Reboot to be enabled.
Aligns the general test list better with chip-tool, so it's easier to
see what's still missing/disabled.
Fixes #16514
Problem
See above.
Change overview
See above.
Testing
Should all be verified by CI, but I did run the various tests I am enabling locally, I believe.