Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to reboot apps in chip-tool-darwin. #16514

Closed
krypton36 opened this issue Mar 22, 2022 · 0 comments · Fixed by #17854
Closed

Add support to reboot apps in chip-tool-darwin. #16514

krypton36 opened this issue Mar 22, 2022 · 0 comments · Fixed by #17854

Comments

@krypton36
Copy link
Contributor

Problem

Currently there is no support to reboot apps in chip-tool-darwin.

Proposed Solution

Use current infrastructure to support rebooting a device in chip-tool-darwin. Add tests back to chip-tool-darwin that are set to manual that require manual interaction of reboot. This PR adds reboot to TestModeSelectCluster which will need to be added back to CI tests in chip-tool-darwin when reboot is enabled.
minhlez added a commit to minhlez/connectedhomeip that referenced this issue Mar 22, 2022
@minhlez
Disable TestModeSelectCluster for darwin. To be added back in project…
24fb989 
…-chip#16514
minhlez added a commit to minhlez/connectedhomeip that referenced this issue Mar 23, 2022
@minhlez
Disable TestModeSelectCluster for darwin. To be added back in project…
503a9e7 
…-chip#16514
woody-apple pushed a commit to minhlez/connectedhomeip that referenced this issue Mar 24, 2022
@minhlez @andy31415
Disable TestModeSelectCluster for darwin. To be added back in project…
7026363 
…-chip#16514
bzbarsky-apple pushed a commit that referenced this issue Mar 24, 2022
@minhlez @restyled-commits
Implement startup behavior with StartUpMode (#16039)
d88beed 
* Implement StartUpMode behavior with validation

* Disable TestModeSelectCluster for darwin. To be added back in #16514

* Update StartUpMode of ModeSelectCluster to use NVM storage option and generate code

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this issue Apr 14, 2022
@minhlez @restyled-commits @andrei-menzopol
Implement startup behavior with StartUpMode (project-chip#16039)
6c57530 
* Implement StartUpMode behavior with validation

* Disable TestModeSelectCluster for darwin. To be added back in project-chip#16514

* Update StartUpMode of ModeSelectCluster to use NVM storage option and generate code

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 28, 2022
@bzbarsky-apple
Implement Reboot command for chip-tool-darwin.
5efc571 
Enables a few tests that needed Reboot to be enabled.

Aligns the general test list better with chip-tool, so it's easier to
see what's still missing/disabled.

Fixes project-chip#16514
@bzbarsky-apple bzbarsky-apple mentioned this issue Apr 28, 2022
Merged
bzbarsky-apple added a commit that referenced this issue Apr 29, 2022
@bzbarsky-apple
Implement Reboot command for chip-tool-darwin. (#17854)
a451ce1 
* Implement Reboot command for chip-tool-darwin.

Enables a few tests that needed Reboot to be enabled.

Aligns the general test list better with chip-tool, so it's easier to
see what's still missing/disabled.

Fixes #16514

* Address review comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Reboot command for chip-tool-darwin. bzbarsky-apple/connectedhomeip
1 participant
@krypton36