Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing CHIP error codes into CHIPError.cpp/TestCHIPErrorStr.cpp and fix duplicates #17414

Merged
merged 5 commits into from
Apr 15, 2022
Merged

Add missing CHIP error codes into CHIPError.cpp/TestCHIPErrorStr.cpp and fix duplicates #17414

merged 5 commits into from
Apr 15, 2022

Conversation

isiu-apple
Copy link
Contributor

@isiu-apple isiu-apple commented Apr 15, 2022 •
edited
Loading

Problem

  • Some CHIP errors defined in CHIPError.h have not been added to CHIPError.cpp and TestCHIPErrorStr.cpp
  • Some CHIP errors have conflicting error codes

Fixes: #17191

Change overview

  • Added missing CHIP errors to CHIPError.cpp and TestCHIPErrorStr.cpp
  • Resolve conflicting CHIP error definitions

Testing

Verified Linux OTA-R compilation.
Verified src/lib/core/tests/BUILD.gn compilation

@boring-cyborg boring-cyborg bot added the lib label Apr 15, 2022
@isiu-apple isiu-apple marked this pull request as draft April 15, 2022 00:23
@github-actions
Copy link

github-actions bot commented Apr 15, 2022 •
edited
Loading

PR #17414: Size comparison from 964adbc to 07a00fe

Increases above 0.2%:

platform target config section 964adbc 07a00fe change % change
linux bridge-app debug+rpc .rodata 148601 149049 448 0.3
door-lock-app debug .rodata 186825 187273 448 0.2
lighting-app debug+rpc .rodata 182761 183209 448 0.2
ota-provider-app debug .rodata 172715 173163 448 0.3
ota-requestor-app debug .rodata 169452 169932 480 0.3
shell debug .rodata 214962 215410 448 0.2
thermostat-no-ble arm64 .rodata 144692 145124 432 0.3
tv-app debug .rodata 214091 214571 480 0.2
Increases (11 builds for linux)
platform target config section 964adbc 07a00fe change % change
linux all-clusters-app debug (read only) 2699609 2700217 608 0.0
.rodata 232581 233029 448 0.2
.text 2293218 2293378 160 0.0
bridge-app debug+rpc (read only) 1839069 1839677 608 0.0
.rodata 148601 149049 448 0.3
.text 1572309 1572469 160 0.0
chip-tool debug (read only) 10752421 10753061 640 0.0
.rodata 539917 540397 480 0.1
.text 9381349 9381509 160 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10378244 10378836 592 0.0
.rodata 513540 513972 432 0.1
.text 8759796 8759956 160 0.0
door-lock-app debug (read only) 2110337 2110945 608 0.0
.rodata 186825 187273 448 0.2
.text 1768082 1768242 160 0.0
lighting-app debug+rpc (read only) 2315153 2315761 608 0.0
.rodata 182761 183209 448 0.2
.text 1966738 1966898 160 0.0
ota-provider-app debug (read only) 2047537 2048145 608 0.0
.rodata 172715 173163 448 0.3
.text 1718882 1719042 160 0.0
ota-requestor-app debug (read only) 2078201 2078841 640 0.0
.rodata 169452 169932 480 0.3
.text 1751058 1751218 160 0.0
shell debug (read only) 2528193 2528801 608 0.0
.rodata 214962 215410 448 0.2
.text 2152162 2152322 160 0.0
thermostat-no-ble arm64 (read only) 2354724 2355316 592 0.0
.rodata 144692 145124 432 0.3
.text 1981936 1982096 160 0.0
tv-app debug (read only) 2830705 2831345 640 0.0
.rodata 214091 214571 480 0.2
.text 2435378 2435538 160 0.0
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 964adbc 07a00fe change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 683431 683431 0 0.0
(read/write) 169736 169736 0 0.0
.bss 76152 76152 0 0.0
.data 3380 3380 0 0.0
.rodata 102911 102911 0 0.0
.text 580040 580040 0 0.0
lock-ftd LP_CC2652R7 (read only) 676479 676479 0 0.0
(read/write) 167648 167648 0 0.0
.bss 74168 74168 0 0.0
.data 3212 3212 0 0.0
.rodata 98535 98535 0 0.0
.text 577460 577460 0 0.0
lock-mtd LP_CC2652R7 (read only) 625231 625231 0 0.0
(read/write) 146956 146956 0 0.0
.bss 69888 69888 0 0.0
.data 3212 3212 0 0.0
.rodata 98415 98415 0 0.0
.text 526324 526324 0 0.0
pump-app LP_CC2652R7 (read only) 648715 648715 0 0.0
(read/write) 152492 152492 0 0.0
.bss 74624 74624 0 0.0
.data 3244 3244 0 0.0
.rodata 75419 75419 0 0.0
.text 572808 572808 0 0.0
pump-controller-app LP_CC2652R7 (read only) 641975 641975 0 0.0
(read/write) 152160 152160 0 0.0
.bss 74328 74328 0 0.0
.data 3208 3208 0 0.0
.rodata 78695 78695 0 0.0
.text 562792 562792 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618654 618654 0 0.0
.app_xip_area 525404 525404 0 0.0
.bss 75916 75916 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 612902 612902 0 0.0
.app_xip_area 521156 521156 0 0.0
.bss 74444 74444 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565346 565346 0 0.0
.app_xip_area 464004 464004 0 0.0
.bss 83744 83744 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906884 906884 0 0.0
(read/write) 133128 133128 0 0.0
.bss 131088 131088 0 0.0
.data 2040 2040 0 0.0
.text 906876 906876 0 0.0
BRD4161A+rpc (read only) 941260 941260 0 0.0
(read/write) 149812 149812 0 0.0
.bss 147568 147568 0 0.0
.data 2244 2244 0 0.0
.text 941252 941252 0 0.0
window-app BRD4161A (read only) 843684 843684 0 0.0
(read/write) 131132 131132 0 0.0
.bss 129184 129184 0 0.0
.data 1948 1948 0 0.0
.text 843676 843676 0 0.0
esp32 all-clusters-app c3devkit (read only) 979932 979932 0 0.0
(read/write) 1397386 1397386 0 0.0
.dram0.bss 62608 62608 0 0.0
.dram0.data 14412 14412 0 0.0
.flash.rodata 201456 201456 0 0.0
.flash.text 979932 979932 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1035275 1035275 0 0.0
(read/write) 465156 465156 0 0.0
.dram0.bss 68128 68128 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231040 231040 0 0.0
.flash.text 1029891 1029891 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684200 684200 0 0.0
.bss 77928 77928 0 0.0
.data 1992 1992 0 0.0
.text 598480 598480 0 0.0
lock k32w061+release (read/write) 725044 725044 0 0.0
.bss 78536 78536 0 0.0
.data 1952 1952 0 0.0
.text 638756 638756 0 0.0
linux all-clusters-app debug (read only) 2699609 2700217 608 0.0
(read/write) 149024 149024 0 0.0
.bss 60000 60000 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 81032 81032 0 0.0
.dynamic 608 608 0 0.0
.got 4448 4448 0 0.0
.init 27 27 0 0.0
.init_array 984 984 0 0.0
.rodata 232581 233029 448 0.2
.text 2293218 2293378 160 0.0
bridge-app debug+rpc (read only) 1839069 1839677 608 0.0
(read/write) 91576 91576 0 0.0
.bss 44264 44264 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 39312 39312 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 148601 149049 448 0.3
.text 1572309 1572469 160 0.0
chip-tool debug (read only) 10752421 10753061 640 0.0
(read/write) 372248 372248 0 0.0
.bss 22560 22560 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 342304 342304 0 0.0
.dynamic 624 624 0 0.0
.got 4936 4936 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 539917 540397 480 0.1
.text 9381349 9381509 160 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10378244 10378836 592 0.0
(read/write) 492593 492593 0 0.0
.bss 40881 40881 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 389328 389328 0 0.0
.dynamic 560 560 0 0.0
.got 57392 57392 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 513540 513972 432 0.1
.text 8759796 8759956 160 0.0
door-lock-app debug (read only) 2110337 2110945 608 0.0
(read/write) 119344 119344 0 0.0
.bss 47872 47872 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 64456 64456 0 0.0
.dynamic 592 592 0 0.0
.got 4248 4248 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 186825 187273 448 0.2
.text 1768082 1768242 160 0.0
lighting-app debug+rpc (read only) 2315153 2315761 608 0.0
(read/write) 127632 127632 0 0.0
.bss 50048 50048 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 69928 69928 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 182761 183209 448 0.2
.text 1966738 1966898 160 0.0
ota-provider-app debug (read only) 2047537 2048145 608 0.0
(read/write) 115040 115040 0 0.0
.bss 48000 48000 0 0.0
.data 1640 1640 0 0.0
.data.rel.ro 59656 59656 0 0.0
.dynamic 608 608 0 0.0
.got 4448 4448 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 172715 173163 448 0.3
.text 1718882 1719042 160 0.0
ota-requestor-app debug (read only) 2078201 2078841 640 0.0
(read/write) 118072 118072 0 0.0
.bss 48704 48704 0 0.0
.data 1896 1896 0 0.0
.data.rel.ro 61880 61880 0 0.0
.dynamic 592 592 0 0.0
.got 4288 4288 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 169452 169932 480 0.3
.text 1751058 1751218 160 0.0
shell debug (read only) 2528193 2528801 608 0.0
(read/write) 149808 149808 0 0.0
.bss 67368 67368 0 0.0
.data 1296 1296 0 0.0
.data.rel.ro 75408 75408 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 214962 215410 448 0.2
.text 2152162 2152322 160 0.0
thermostat-no-ble arm64 (read only) 2354724 2355316 592 0.0
(read/write) 150769 150769 0 0.0
.bss 62977 62977 0 0.0
.data 1440 1440 0 0.0
.data.rel.ro 78608 78608 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144692 145124 432 0.3
.text 1981936 1982096 160 0.0
tv-app debug (read only) 2830705 2831345 640 0.0
(read/write) 250600 250600 0 0.0
.bss 163928 163928 0 0.0
.data 4480 4480 0 0.0
.data.rel.ro 76008 76008 0 0.0
.dynamic 592 592 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 214091 214571 480 0.2
.text 2435378 2435538 160 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2409556 2409556 0 0.0
.bss 185244 185244 0 0.0
.data 5840 5840 0 0.0
.text 1372156 1372156 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1163283 1163283 0 0.0
bss 136512 136512 0 0.0
rodata 147028 147028 0 0.0
text 801096 801096 0 0.0
p6 all-clusters-app default (read/write) 2514728 2514728 0 0.0
.bss 118624 118624 0 0.0
.data 2768 2768 0 0.0
.text 1472992 1472992 0 0.0
light-app default (read/write) 2415176 2415176 0 0.0
.bss 112120 112120 0 0.0
.data 2576 2576 0 0.0
.text 1373440 1373440 0 0.0
lock-app default (read/write) 2418656 2418656 0 0.0
.bss 111896 111896 0 0.0
.data 2536 2536 0 0.0
.text 1376920 1376920 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 801096 801096 0 0.0
bss 69972 69972 0 0.0
noinit 40416 40416 0 0.0
text 570012 570012 0 0.0

@isiu-apple isiu-apple marked this pull request as ready for review April 15, 2022 02:40
@andy31415 andy31415 changed the title Issue 17191 Add missing chip error codes into chip error/chiperrorstr and fix duplicates Apr 15, 2022
@isiu-apple isiu-apple changed the title Add missing chip error codes into chip error/chiperrorstr and fix duplicates Add missing CHIP error codes into CHIPError.cpp/TestCHIPErrorStr.cpp and fix duplicates Apr 15, 2022
@github-actions
Copy link

PR #17414: Size comparison from 964adbc to bd07874

Increases (2 builds for mbed, nrfconnect)
platform target config section 964adbc bd07874 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2409556 2410188 632 0.0
.text 1372156 1372788 632 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1163283 1163883 600 0.1
rodata 147028 147276 248 0.2
text 801096 801444 348 0.0
Decreases (2 builds for mbed, nrfconnect)
platform target config section 964adbc bd07874 change % change
mbed lock-app CY8CPROTO_062_4343W+release .bss 185244 185228 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 bss 136512 136492 -20 -0.0
Full report (2 builds for mbed, nrfconnect)
platform target config section 964adbc bd07874 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2409556 2410188 632 0.0
.bss 185244 185228 -16 -0.0
.data 5840 5840 0 0.0
.text 1372156 1372788 632 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1163283 1163883 600 0.1
bss 136512 136492 -20 -0.0
rodata 147028 147276 248 0.2
text 801096 801444 348 0.0

@carol-apple carol-apple merged commit d74d8be into project-chip:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt left review comments

@carol-apple carol-apple carol-apple approved these changes

@harsha-rajendran harsha-rajendran harsha-rajendran approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some chip errors defined in CHIPError.h have not been added to CHIPError.cpp and TestCHIPErrorStr.cpp
5 participants
@isiu-apple @andy31415 @msandstedt @harsha-rajendran @carol-apple