Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some chip errors defined in CHIPError.h have not been added to CHIPError.cpp and TestCHIPErrorStr.cpp #17191

Closed
isiu-apple opened this issue Apr 7, 2022 · 0 comments · Fixed by #17414
Assignees

Comments

@isiu-apple
Copy link
Contributor

isiu-apple commented Apr 7, 2022

Problem

Some chip errors defined in CHIPError.h have not been added to CHIPError.cpp and TestCHIPErrorStr.cpp

For example: CHIP_ERROR_INVALID_FILE_IDENTIFIER

Proposed Solution

Need to find all chip errors defined in CHIPError.h that are missing this change and update the translation of error codes to strings in CHIPError.cpp and add them to kTestElements[] in TestCHIPErrorStr.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant