Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nrfconnect] Support nRF52840 Dongle in all-clusters-app #17215

Merged
merged 4 commits into from
Apr 11, 2022
Merged

[nrfconnect] Support nRF52840 Dongle in all-clusters-app #17215

merged 4 commits into from
Apr 11, 2022

Conversation

Damian-Nordic
Copy link
Contributor

Problem

Some users want to be able to run all-clusters-app on nRF52840 Dongle.
Also, the platform, although claimed to be supported for the lighting-app, cannot be flashed due to code size limitations.

Change overview

Add support for nrf52840 dongle in all-clusters-app.
Fix support for nrf52840 dongle in lighting-app. It's mainly achieved by disabling shell and updating USB device initialization.

Testing

Verified both apps can be flashed onto the dongle and commissioned.

@github-actions
Copy link

github-actions bot commented Apr 8, 2022 •
edited
Loading

PR #17215: Size comparison from ecf91b2 to 0f74ead

Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section ecf91b2 0f74ead change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 639379 639379 0 0.0
(read/write) 151052 151052 0 0.0
.bss 73984 73984 0 0.0
.data 3212 3212 0 0.0
.rodata 79955 79955 0 0.0
.text 558932 558932 0 0.0
lock-mtd LP_CC2652R7 (read only) 588115 588115 0 0.0
(read/write) 146772 146772 0 0.0
.bss 69704 69704 0 0.0
.data 3212 3212 0 0.0
.rodata 79835 79835 0 0.0
.text 507788 507788 0 0.0
pump-app LP_CC2652R7 (read only) 646759 646759 0 0.0
(read/write) 152260 152260 0 0.0
.bss 74392 74392 0 0.0
.data 3244 3244 0 0.0
.rodata 74663 74663 0 0.0
.text 571608 571608 0 0.0
pump-controller-app LP_CC2652R7 (read only) 641099 641099 0 0.0
(read/write) 151952 151952 0 0.0
.bss 74120 74120 0 0.0
.data 3208 3208 0 0.0
.rodata 78443 78443 0 0.0
.text 562168 562168 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 617822 617822 0 0.0
.app_xip_area 524948 524948 0 0.0
.bss 75540 75540 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 575426 575426 0 0.0
.app_xip_area 484088 484088 0 0.0
.bss 74036 74036 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 563918 563918 0 0.0
.app_xip_area 462952 462952 0 0.0
.bss 83368 83368 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906400 906400 0 0.0
(read/write) 132920 132920 0 0.0
.bss 130880 130880 0 0.0
.data 2040 2040 0 0.0
.text 906392 906392 0 0.0
BRD4161A+rpc (read only) 934272 934272 0 0.0
(read/write) 148872 148872 0 0.0
.bss 146648 146648 0 0.0
.data 2220 2220 0 0.0
.text 934264 934264 0 0.0
window-app BRD4161A (read only) 843688 843688 0 0.0
(read/write) 130992 130992 0 0.0
.bss 129040 129040 0 0.0
.data 1948 1948 0 0.0
.text 843680 843680 0 0.0
esp32 all-clusters-app c3devkit (read only) 992918 992918 0 0.0
(read/write) 1462378 1462378 0 0.0
.dram0.bss 62960 62960 0 0.0
.dram0.data 14364 14364 0 0.0
.flash.rodata 199584 199584 0 0.0
.flash.text 992918 992918 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1045579 1045579 0 0.0
(read/write) 463440 463440 0 0.0
.dram0.bss 68480 68480 0 0.0
.dram0.data 34160 34160 0 0.0
.flash.rodata 228656 228656 0 0.0
.flash.text 1040195 1040195 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 686348 686348 0 0.0
.bss 77968 77968 0 0.0
.data 2036 2036 0 0.0
.text 600544 600544 0 0.0
lock k32w061+release (read/write) 690948 690948 0 0.0
.bss 78544 78544 0 0.0
.data 1996 1996 0 0.0
.text 604608 604608 0 0.0
linux all-clusters-app debug (read only) 2627009 2627009 0 0.0
(read/write) 146248 146248 0 0.0
.bss 57664 57664 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 80856 80856 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 222661 222661 0 0.0
.text 2233746 2233746 0 0.0
bridge-app debug+rpc (read only) 1834861 1834861 0 0.0
(read/write) 91592 91592 0 0.0
.bss 44344 44344 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 39240 39240 0 0.0
.dynamic 592 592 0 0.0
.got 3936 3936 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 148473 148473 0 0.0
.text 1568053 1568053 0 0.0
chip-tool debug (read only) 10677589 10677589 0 0.0
(read/write) 371768 371768 0 0.0
.bss 22752 22752 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 341680 341680 0 0.0
.dynamic 624 624 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 538165 538165 0 0.0
.text 9310341 9310341 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10278380 10278380 0 0.0
(read/write) 492193 492193 0 0.0
.bss 41009 41009 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388824 388824 0 0.0
.dynamic 560 560 0 0.0
.got 57392 57392 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512428 512428 0 0.0
.text 8662772 8662772 0 0.0
door-lock-app debug (read only) 2106049 2106049 0 0.0
(read/write) 119344 119344 0 0.0
.bss 47936 47936 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 64392 64392 0 0.0
.dynamic 592 592 0 0.0
.got 4264 4264 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 186505 186505 0 0.0
.text 1763938 1763938 0 0.0
lighting-app debug+rpc (read only) 2308649 2308649 0 0.0
(read/write) 127664 127664 0 0.0
.bss 50144 50144 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 69864 69864 0 0.0
.dynamic 608 608 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 181673 181673 0 0.0
.text 1961234 1961234 0 0.0
ota-provider-app debug (read only) 2043393 2043393 0 0.0
(read/write) 114784 114784 0 0.0
.bss 47840 47840 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 59576 59576 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 172451 172451 0 0.0
.text 1714850 1714850 0 0.0
ota-requestor-app debug (read only) 2073145 2073145 0 0.0
(read/write) 118104 118104 0 0.0
.bss 48800 48800 0 0.0
.data 1864 1864 0 0.0
.data.rel.ro 61832 61832 0 0.0
.dynamic 592 592 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 169132 169132 0 0.0
.text 1746050 1746050 0 0.0
shell debug (read only) 2521825 2521825 0 0.0
(read/write) 149680 149680 0 0.0
.bss 67368 67368 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 75336 75336 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 214290 214290 0 0.0
.text 2146466 2146466 0 0.0
thermostat-no-ble arm64 (read only) 2351852 2351852 0 0.0
(read/write) 150833 150833 0 0.0
.bss 63025 63025 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78600 78600 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144652 144652 0 0.0
.text 1978720 1978720 0 0.0
tv-app debug (read only) 2797297 2797297 0 0.0
(read/write) 251576 251576 0 0.0
.bss 165032 165032 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 75888 75888 0 0.0
.dynamic 592 592 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 213451 213451 0 0.0
.text 2402738 2402738 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2367996 2367996 0 0.0
.bss 185076 185076 0 0.0
.data 5840 5840 0 0.0
.text 1330596 1330596 0 0.0
p6 all-clusters-app default (read/write) 2514008 2514008 0 0.0
.bss 118480 118480 0 0.0
.data 2768 2768 0 0.0
.text 1472272 1472272 0 0.0
light-app default (read/write) 2414840 2414840 0 0.0
.bss 111976 111976 0 0.0
.data 2576 2576 0 0.0
.text 1373104 1373104 0 0.0
lock-app default (read/write) 2378408 2378408 0 0.0
.bss 111720 111720 0 0.0
.data 2536 2536 0 0.0
.text 1336672 1336672 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800600 800600 0 0.0
bss 69828 69828 0 0.0
noinit 40416 40416 0 0.0
text 569474 569474 0 0.0

andy31415
andy31415 requested changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update build_examples.py with this support

@Damian-Nordic
[nrfconnect] Support nRF52840 Dongle in all-clusters-app
d89643d 
The dongle doesn't have external flash, so only build
configurations without the DFU are supported. Also, due
to flash size limitations (nR52840 dongle reserves some
flash for an immutable bootloader), shell commands
must have been disabled, too.

By the way, make fixes in lighting-app which in theory
already had the support for the nRF52840 Dongle, but it
didn't work due to various issues.

Signed-off-by: Damian Krolik <[email protected]>
@Damian-Nordic
Add new targets to build_examples.py
4fc2c13
@Damian-Nordic Damian-Nordic force-pushed the nrf52840dongle-fixes branch from 0f74ead to 4fc2c13 Compare April 8, 2022 16:03
@boring-cyborg boring-cyborg bot added the scripts label Apr 8, 2022
@Damian-Nordic Damian-Nordic requested a review from andy31415 April 8, 2022 16:12
@github-actions
Copy link

github-actions bot commented Apr 8, 2022 •
edited
Loading

PR #17215: Size comparison from ecee86b to 12abd31

Increases above 0.2%:

platform target config section ecee86b 12abd31 change % change
nrfconnect lighting-app nrf52840dongle_nrf52840 bss 140040 146288 6248 4.5
Increases (1 build for nrfconnect)
platform target config section ecee86b 12abd31 change % change
nrfconnect lighting-app nrf52840dongle_nrf52840 bss 140040 146288 6248 4.5
Decreases (1 build for nrfconnect)
platform target config section ecee86b 12abd31 change % change
nrfconnect lighting-app nrf52840dongle_nrf52840 (read/write) 1155815 1050443 -105372 -9.1
rodata 121204 91948 -29256 -24.1
text 804952 731388 -73564 -9.1
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ecee86b 12abd31 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 639379 639379 0 0.0
(read/write) 151052 151052 0 0.0
.bss 73984 73984 0 0.0
.data 3212 3212 0 0.0
.rodata 79955 79955 0 0.0
.text 558932 558932 0 0.0
lock-mtd LP_CC2652R7 (read only) 588115 588115 0 0.0
(read/write) 146772 146772 0 0.0
.bss 69704 69704 0 0.0
.data 3212 3212 0 0.0
.rodata 79835 79835 0 0.0
.text 507788 507788 0 0.0
pump-app LP_CC2652R7 (read only) 646759 646759 0 0.0
(read/write) 152260 152260 0 0.0
.bss 74392 74392 0 0.0
.data 3244 3244 0 0.0
.rodata 74663 74663 0 0.0
.text 571608 571608 0 0.0
pump-controller-app LP_CC2652R7 (read only) 641099 641099 0 0.0
(read/write) 151952 151952 0 0.0
.bss 74120 74120 0 0.0
.data 3208 3208 0 0.0
.rodata 78443 78443 0 0.0
.text 562168 562168 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 617822 617822 0 0.0
.app_xip_area 524948 524948 0 0.0
.bss 75540 75540 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 575426 575426 0 0.0
.app_xip_area 484088 484088 0 0.0
.bss 74036 74036 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 563918 563918 0 0.0
.app_xip_area 462952 462952 0 0.0
.bss 83368 83368 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906400 906400 0 0.0
(read/write) 132920 132920 0 0.0
.bss 130880 130880 0 0.0
.data 2040 2040 0 0.0
.text 906392 906392 0 0.0
BRD4161A+rpc (read only) 934272 934272 0 0.0
(read/write) 148872 148872 0 0.0
.bss 146648 146648 0 0.0
.data 2220 2220 0 0.0
.text 934264 934264 0 0.0
window-app BRD4161A (read only) 843688 843688 0 0.0
(read/write) 130992 130992 0 0.0
.bss 129040 129040 0 0.0
.data 1948 1948 0 0.0
.text 843680 843680 0 0.0
esp32 all-clusters-app c3devkit (read only) 992918 992918 0 0.0
(read/write) 1462514 1462514 0 0.0
.dram0.bss 62960 62960 0 0.0
.dram0.data 14364 14364 0 0.0
.flash.rodata 199720 199720 0 0.0
.flash.text 992918 992918 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1045591 1045591 0 0.0
(read/write) 463576 463576 0 0.0
.dram0.bss 68480 68480 0 0.0
.dram0.data 34160 34160 0 0.0
.flash.rodata 228792 228792 0 0.0
.flash.text 1040207 1040207 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 686348 686348 0 0.0
.bss 77968 77968 0 0.0
.data 2036 2036 0 0.0
.text 600544 600544 0 0.0
lock k32w061+release (read/write) 690948 690948 0 0.0
.bss 78544 78544 0 0.0
.data 1996 1996 0 0.0
.text 604608 604608 0 0.0
linux all-clusters-app debug (read only) 2627169 2627169 0 0.0
(read/write) 146248 146248 0 0.0
.bss 57664 57664 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 80856 80856 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 222821 222821 0 0.0
.text 2233746 2233746 0 0.0
bridge-app debug+rpc (read only) 1834861 1834861 0 0.0
(read/write) 91592 91592 0 0.0
.bss 44344 44344 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 39240 39240 0 0.0
.dynamic 592 592 0 0.0
.got 3936 3936 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 148473 148473 0 0.0
.text 1568053 1568053 0 0.0
chip-tool debug (read only) 10677589 10677589 0 0.0
(read/write) 371768 371768 0 0.0
.bss 22752 22752 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 341680 341680 0 0.0
.dynamic 624 624 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 538165 538165 0 0.0
.text 9310341 9310341 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10278348 10278348 0 0.0
(read/write) 492193 492193 0 0.0
.bss 41009 41009 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388824 388824 0 0.0
.dynamic 560 560 0 0.0
.got 57392 57392 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512428 512428 0 0.0
.text 8662740 8662740 0 0.0
door-lock-app debug (read only) 2106209 2106209 0 0.0
(read/write) 119344 119344 0 0.0
.bss 47936 47936 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 64392 64392 0 0.0
.dynamic 592 592 0 0.0
.got 4264 4264 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 186665 186665 0 0.0
.text 1763938 1763938 0 0.0
lighting-app debug+rpc (read only) 2308649 2308649 0 0.0
(read/write) 127664 127664 0 0.0
.bss 50144 50144 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 69864 69864 0 0.0
.dynamic 608 608 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 181673 181673 0 0.0
.text 1961234 1961234 0 0.0
ota-provider-app debug (read only) 2043393 2043393 0 0.0
(read/write) 114784 114784 0 0.0
.bss 47840 47840 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 59576 59576 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 172451 172451 0 0.0
.text 1714850 1714850 0 0.0
ota-requestor-app debug (read only) 2073145 2073145 0 0.0
(read/write) 118104 118104 0 0.0
.bss 48800 48800 0 0.0
.data 1864 1864 0 0.0
.data.rel.ro 61832 61832 0 0.0
.dynamic 592 592 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 169132 169132 0 0.0
.text 1746050 1746050 0 0.0
shell debug (read only) 2521953 2521953 0 0.0
(read/write) 149680 149680 0 0.0
.bss 67368 67368 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 75336 75336 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 214418 214418 0 0.0
.text 2146466 2146466 0 0.0
thermostat-no-ble arm64 (read only) 2351724 2351724 0 0.0
(read/write) 150833 150833 0 0.0
.bss 63025 63025 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78600 78600 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144652 144652 0 0.0
.text 1978592 1978592 0 0.0
tv-app debug (read only) 2796689 2796689 0 0.0
(read/write) 251576 251576 0 0.0
.bss 165032 165032 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 75888 75888 0 0.0
.dynamic 592 592 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 213451 213451 0 0.0
.text 2402130 2402130 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2367996 2367996 0 0.0
.bss 185076 185076 0 0.0
.data 5840 5840 0 0.0
.text 1330596 1330596 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154967 1154967 0 0.0
bss 135304 135304 0 0.0
rodata 146544 146544 0 0.0
text 794408 794408 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1141399 1141399 0 0.0
bss 139040 139040 0 0.0
rodata 121624 121624 0 0.0
text 802076 802076 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1105651 1105651 0 0.0
bss 139276 139276 0 0.0
rodata 112748 112748 0 0.0
text 774496 774496 0 0.0
nrf52840dongle_nrf52840 (read/write) 1155815 1050443 -105372 -9.1
bss 140040 146288 6248 4.5
rodata 121204 91948 -29256 -24.1
text 804952 731388 -73564 -9.1
nrf5340dk_nrf5340_cpuapp (read/write) 1050110 1050110 0 0.0
bss 136104 136104 0 0.0
rodata 114796 114796 0 0.0
text 717240 717240 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1041639 1041639 0 0.0
bss 128984 128984 0 0.0
rodata 114408 114408 0 0.0
text 719796 719796 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 950694 950694 0 0.0
bss 126080 126080 0 0.0
rodata 107636 107636 0 0.0
text 635116 635116 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1060775 1060775 0 0.0
bss 128900 128900 0 0.0
rodata 116616 116616 0 0.0
text 736580 736580 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1042891 1042891 0 0.0
bss 128644 128644 0 0.0
rodata 112780 112780 0 0.0
text 722812 722812 0 0.0
p6 all-clusters-app default (read/write) 2514152 2514152 0 0.0
.bss 118480 118480 0 0.0
.data 2768 2768 0 0.0
.text 1472416 1472416 0 0.0
light-app default (read/write) 2414840 2414840 0 0.0
.bss 111976 111976 0 0.0
.data 2576 2576 0 0.0
.text 1373104 1373104 0 0.0
lock-app default (read/write) 2378408 2378408 0 0.0
.bss 111720 111720 0 0.0
.data 2536 2536 0 0.0
.text 1336672 1336672 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800600 800600 0 0.0
bss 69828 69828 0 0.0
noinit 40416 40416 0 0.0
text 569474 569474 0 0.0

@pullapprove pullapprove bot requested a review from Byungjoo-Lee April 8, 2022 17:39
andy31415
andy31415 approved these changes Apr 8, 2022
View reviewed changes
scripts/build/builders/nrf.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Apr 8, 2022 •
edited
Loading

PR #17215: Size comparison from ecee86b to 81d9db2

Increases above 0.2%:

platform target config section ecee86b 81d9db2 change % change
nrfconnect lighting-app nrf52840dongle_nrf52840 bss 140040 146288 6248 4.5
Increases (1 build for nrfconnect)
platform target config section ecee86b 81d9db2 change % change
nrfconnect lighting-app nrf52840dongle_nrf52840 bss 140040 146288 6248 4.5
Decreases (1 build for nrfconnect)
platform target config section ecee86b 81d9db2 change % change
nrfconnect lighting-app nrf52840dongle_nrf52840 (read/write) 1155815 1050443 -105372 -9.1
rodata 121204 91948 -29256 -24.1
text 804952 731388 -73564 -9.1
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ecee86b 81d9db2 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 639379 639379 0 0.0
(read/write) 151052 151052 0 0.0
.bss 73984 73984 0 0.0
.data 3212 3212 0 0.0
.rodata 79955 79955 0 0.0
.text 558932 558932 0 0.0
lock-mtd LP_CC2652R7 (read only) 588115 588115 0 0.0
(read/write) 146772 146772 0 0.0
.bss 69704 69704 0 0.0
.data 3212 3212 0 0.0
.rodata 79835 79835 0 0.0
.text 507788 507788 0 0.0
pump-app LP_CC2652R7 (read only) 646759 646759 0 0.0
(read/write) 152260 152260 0 0.0
.bss 74392 74392 0 0.0
.data 3244 3244 0 0.0
.rodata 74663 74663 0 0.0
.text 571608 571608 0 0.0
pump-controller-app LP_CC2652R7 (read only) 641099 641099 0 0.0
(read/write) 151952 151952 0 0.0
.bss 74120 74120 0 0.0
.data 3208 3208 0 0.0
.rodata 78443 78443 0 0.0
.text 562168 562168 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 617822 617822 0 0.0
.app_xip_area 524948 524948 0 0.0
.bss 75540 75540 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 575426 575426 0 0.0
.app_xip_area 484088 484088 0 0.0
.bss 74036 74036 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 563918 563918 0 0.0
.app_xip_area 462952 462952 0 0.0
.bss 83368 83368 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906400 906400 0 0.0
(read/write) 132920 132920 0 0.0
.bss 130880 130880 0 0.0
.data 2040 2040 0 0.0
.text 906392 906392 0 0.0
BRD4161A+rpc (read only) 934272 934272 0 0.0
(read/write) 148872 148872 0 0.0
.bss 146648 146648 0 0.0
.data 2220 2220 0 0.0
.text 934264 934264 0 0.0
window-app BRD4161A (read only) 843688 843688 0 0.0
(read/write) 130992 130992 0 0.0
.bss 129040 129040 0 0.0
.data 1948 1948 0 0.0
.text 843680 843680 0 0.0
esp32 all-clusters-app c3devkit (read only) 992918 992918 0 0.0
(read/write) 1462514 1462514 0 0.0
.dram0.bss 62960 62960 0 0.0
.dram0.data 14364 14364 0 0.0
.flash.rodata 199720 199720 0 0.0
.flash.text 992918 992918 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1045591 1045591 0 0.0
(read/write) 463576 463576 0 0.0
.dram0.bss 68480 68480 0 0.0
.dram0.data 34160 34160 0 0.0
.flash.rodata 228792 228792 0 0.0
.flash.text 1040207 1040207 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 686348 686348 0 0.0
.bss 77968 77968 0 0.0
.data 2036 2036 0 0.0
.text 600544 600544 0 0.0
lock k32w061+release (read/write) 690948 690948 0 0.0
.bss 78544 78544 0 0.0
.data 1996 1996 0 0.0
.text 604608 604608 0 0.0
linux all-clusters-app debug (read only) 2627169 2627169 0 0.0
(read/write) 146248 146248 0 0.0
.bss 57664 57664 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 80856 80856 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 222821 222821 0 0.0
.text 2233746 2233746 0 0.0
bridge-app debug+rpc (read only) 1834861 1834861 0 0.0
(read/write) 91592 91592 0 0.0
.bss 44344 44344 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 39240 39240 0 0.0
.dynamic 592 592 0 0.0
.got 3936 3936 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 148473 148473 0 0.0
.text 1568053 1568053 0 0.0
chip-tool debug (read only) 10677589 10677589 0 0.0
(read/write) 371768 371768 0 0.0
.bss 22752 22752 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 341680 341680 0 0.0
.dynamic 624 624 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 538165 538165 0 0.0
.text 9310341 9310341 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10278348 10278348 0 0.0
(read/write) 492193 492193 0 0.0
.bss 41009 41009 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388824 388824 0 0.0
.dynamic 560 560 0 0.0
.got 57392 57392 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512428 512428 0 0.0
.text 8662740 8662740 0 0.0
door-lock-app debug (read only) 2106209 2106209 0 0.0
(read/write) 119344 119344 0 0.0
.bss 47936 47936 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 64392 64392 0 0.0
.dynamic 592 592 0 0.0
.got 4264 4264 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 186665 186665 0 0.0
.text 1763938 1763938 0 0.0
lighting-app debug+rpc (read only) 2308649 2308649 0 0.0
(read/write) 127664 127664 0 0.0
.bss 50144 50144 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 69864 69864 0 0.0
.dynamic 608 608 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 181673 181673 0 0.0
.text 1961234 1961234 0 0.0
ota-provider-app debug (read only) 2043393 2043393 0 0.0
(read/write) 114784 114784 0 0.0
.bss 47840 47840 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 59576 59576 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 172451 172451 0 0.0
.text 1714850 1714850 0 0.0
ota-requestor-app debug (read only) 2073145 2073145 0 0.0
(read/write) 118104 118104 0 0.0
.bss 48800 48800 0 0.0
.data 1864 1864 0 0.0
.data.rel.ro 61832 61832 0 0.0
.dynamic 592 592 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 169132 169132 0 0.0
.text 1746050 1746050 0 0.0
shell debug (read only) 2521953 2521953 0 0.0
(read/write) 149680 149680 0 0.0
.bss 67368 67368 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 75336 75336 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 214418 214418 0 0.0
.text 2146466 2146466 0 0.0
thermostat-no-ble arm64 (read only) 2351724 2351724 0 0.0
(read/write) 150833 150833 0 0.0
.bss 63025 63025 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78600 78600 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144652 144652 0 0.0
.text 1978592 1978592 0 0.0
tv-app debug (read only) 2796689 2796689 0 0.0
(read/write) 251576 251576 0 0.0
.bss 165032 165032 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 75888 75888 0 0.0
.dynamic 592 592 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 213451 213451 0 0.0
.text 2402130 2402130 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2367996 2367996 0 0.0
.bss 185076 185076 0 0.0
.data 5840 5840 0 0.0
.text 1330596 1330596 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154967 1154967 0 0.0
bss 135304 135304 0 0.0
rodata 146544 146544 0 0.0
text 794408 794408 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1141399 1141399 0 0.0
bss 139040 139040 0 0.0
rodata 121624 121624 0 0.0
text 802076 802076 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1105651 1105651 0 0.0
bss 139276 139276 0 0.0
rodata 112748 112748 0 0.0
text 774496 774496 0 0.0
nrf52840dongle_nrf52840 (read/write) 1155815 1050443 -105372 -9.1
bss 140040 146288 6248 4.5
rodata 121204 91948 -29256 -24.1
text 804952 731388 -73564 -9.1
nrf5340dk_nrf5340_cpuapp (read/write) 1050110 1050110 0 0.0
bss 136104 136104 0 0.0
rodata 114796 114796 0 0.0
text 717240 717240 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1041639 1041639 0 0.0
bss 128984 128984 0 0.0
rodata 114408 114408 0 0.0
text 719796 719796 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 950694 950694 0 0.0
bss 126080 126080 0 0.0
rodata 107636 107636 0 0.0
text 635116 635116 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1060775 1060775 0 0.0
bss 128900 128900 0 0.0
rodata 116616 116616 0 0.0
text 736580 736580 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1042891 1042891 0 0.0
bss 128644 128644 0 0.0
rodata 112780 112780 0 0.0
text 722812 722812 0 0.0
p6 all-clusters-app default (read/write) 2514152 2514152 0 0.0
.bss 118480 118480 0 0.0
.data 2768 2768 0 0.0
.text 1472416 1472416 0 0.0
light-app default (read/write) 2414840 2414840 0 0.0
.bss 111976 111976 0 0.0
.data 2576 2576 0 0.0
.text 1373104 1373104 0 0.0
lock-app default (read/write) 2378408 2378408 0 0.0
.bss 111720 111720 0 0.0
.data 2536 2536 0 0.0
.text 1336672 1336672 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800600 800600 0 0.0
bss 69828 69828 0 0.0
noinit 40416 40416 0 0.0
text 569474 569474 0 0.0

@Damian-Nordic Damian-Nordic merged commit 1123440 into project-chip:master Apr 11, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@Damian-Nordic @andrei-menzopol
[nrfconnect] Support nRF52840 Dongle in all-clusters-app (project-chi…
54ae0c0 
…p#17215)

* [nrfconnect] Support nRF52840 Dongle in all-clusters-app

The dongle doesn't have external flash, so only build
configurations without the DFU are supported. Also, due
to flash size limitations (nR52840 dongle reserves some
flash for an immutable bootloader), shell commands
must have been disabled, too.

By the way, make fixes in lighting-app which in theory
already had the support for the nRF52840 Dongle, but it
didn't work due to various issues.

Signed-off-by: Damian Krolik <[email protected]>

* Add new targets to build_examples.py

* Fix build

* Revert accidentally committed change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@LuDuda LuDuda LuDuda approved these changes

@andy31415 andy31415 andy31415 approved these changes

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

Assignees
No one assigned
Labels
examples review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Damian-Nordic @andy31415 @LuDuda @bzbarsky-apple @jmeg-sfy