Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests in Test_TC_OO_2_4 for OnOff StartupOnOff behaviours #17012

Merged
merged 5 commits into from
Apr 5, 2022
Merged

Add tests in Test_TC_OO_2_4 for OnOff StartupOnOff behaviours #17012

merged 5 commits into from
Apr 5, 2022

Conversation

jmartinez-silabs
Copy link
Member

@jmartinez-silabs jmartinez-silabs commented Apr 4, 2022 •
edited
Loading

Problem

From discussion in #16377, we are lacking a YAML test to validate StartupOnOff different values/behaviours.
TC_OO_2_4 is supposed to test this functionality but isn't implemented.

Change overview

Implement the test cases OnOff 2.4 with the YAML test suite.

Testing

The test is run with the test suites.

@restyled-io restyled-io bot mentioned this pull request Apr 4, 2022
Closed
@github-actions
Copy link

github-actions bot commented Apr 4, 2022 •
edited
Loading

PR #17012: Size comparison from 316e665 to 3153a6c

Increases above 0.2%:

platform target config section 316e665 3153a6c change % change
linux chip-tool-no-interactive-ipv6only arm64 .got 56784 56992 208 0.4
.rodata 506628 508260 1632 0.3
Increases (1 build for linux)
platform target config section 316e665 3153a6c change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10039220 10053908 14688 0.1
(read/write) 478305 478513 208 0.0
.got 56784 56992 208 0.4
.rodata 506628 508260 1632 0.3
.text 8467764 8480196 12432 0.1
Full report (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 316e665 3153a6c change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668211 668211 0 0.0
(read/write) 183500 183500 0 0.0
.bss 81752 81752 0 0.0
.data 3164 3164 0 0.0
.rodata 79683 79683 0 0.0
.text 588048 588048 0 0.0
lock-mtd LP_CC2652R7 (read only) 617339 617339 0 0.0
(read/write) 154500 154500 0 0.0
.bss 77480 77480 0 0.0
.data 3164 3164 0 0.0
.rodata 79571 79571 0 0.0
.text 537280 537280 0 0.0
pump-app LP_CC2652R7 (read only) 687679 687679 0 0.0
(read/write) 165200 165200 0 0.0
.bss 82152 82152 0 0.0
.data 3196 3196 0 0.0
.rodata 81767 81767 0 0.0
.text 605428 605428 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669903 669903 0 0.0
(read/write) 182712 182712 0 0.0
.bss 81888 81888 0 0.0
.data 3160 3160 0 0.0
.rodata 78103 78103 0 0.0
.text 591316 591316 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610854 610854 0 0.0
.app_xip_area 517564 517564 0 0.0
.bss 76004 76004 0 0.0
.data 632 632 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 568362 568362 0 0.0
.app_xip_area 476616 476616 0 0.0
.bss 74500 74500 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 580014 580014 0 0.0
.app_xip_area 478624 478624 0 0.0
.bss 83816 83816 0 0.0
.data 536 536 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916124 916124 0 0.0
(read/write) 129784 129784 0 0.0
.bss 127792 127792 0 0.0
.data 1992 1992 0 0.0
.text 916116 916116 0 0.0
BRD4161A+rpc (read only) 944028 944028 0 0.0
(read/write) 145732 145732 0 0.0
.bss 143560 143560 0 0.0
.data 2172 2172 0 0.0
.text 944020 944020 0 0.0
window-app BRD4161A (read only) 851444 851444 0 0.0
(read/write) 127808 127808 0 0.0
.bss 125936 125936 0 0.0
.data 1872 1872 0 0.0
.text 851436 851436 0 0.0
esp32 all-clusters-app c3devkit (read only) 985898 985898 0 0.0
(read/write) 1460570 1460570 0 0.0
.dram0.bss 62944 62944 0 0.0
.dram0.data 14196 14196 0 0.0
.flash.rodata 197952 197952 0 0.0
.flash.text 985898 985898 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1038407 1038407 0 0.0
(read/write) 461608 461608 0 0.0
.dram0.bss 68472 68472 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 226936 226936 0 0.0
.flash.text 1033023 1033023 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 708068 708068 0 0.0
.bss 77952 77952 0 0.0
.data 1904 1904 0 0.0
.text 622412 622412 0 0.0
lock k32w061+release (read/write) 707492 707492 0 0.0
.bss 77952 77952 0 0.0
.data 1944 1944 0 0.0
.text 621796 621796 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10039220 10053908 14688 0.1
(read/write) 478305 478513 208 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 376264 376264 0 0.0
.dynamic 560 560 0 0.0
.got 56784 56992 208 0.4
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 506628 508260 1632 0.3
.text 8467764 8480196 12432 0.1
thermostat-no-ble arm64 (read only) 2312940 2312940 0 0.0
(read/write) 149361 149361 0 0.0
.bss 62945 62945 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 77640 77640 0 0.0
.dynamic 560 560 0 0.0
.got 4624 4624 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 143116 143116 0 0.0
.text 1944224 1944224 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360332 2360332 0 0.0
.bss 185036 185036 0 0.0
.data 5784 5784 0 0.0
.text 1322932 1322932 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148915 1148915 0 0.0
bss 143060 143060 0 0.0
rodata 143292 143292 0 0.0
text 787692 787692 0 0.0
p6 all-clusters-app default (read/write) 2504504 2504504 0 0.0
.bss 118472 118472 0 0.0
.data 2672 2672 0 0.0
.text 1462768 1462768 0 0.0
light-app default (read/write) 2405680 2405680 0 0.0
.bss 111928 111928 0 0.0
.data 2528 2528 0 0.0
.text 1363944 1363944 0 0.0
lock-app default (read/write) 2369320 2369320 0 0.0
.bss 111672 111672 0 0.0
.data 2488 2488 0 0.0
.text 1327584 1327584 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 792316 792316 0 0.0
bss 70288 70288 0 0.0
noinit 40416 40416 0 0.0
text 562168 562168 0 0.0

woody-apple
woody-apple approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking testing changes.

woody-apple
woody-apple approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rebase

@github-actions
Copy link

github-actions bot commented Apr 4, 2022 •
edited
Loading

PR #17012: Size comparison from 316e665 to f362470

Increases above 0.2%:

platform target config section 316e665 f362470 change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10039220 10083476 44256 0.4
(read/write) 478305 486977 8672 1.8
.data.rel.ro 376264 384712 8448 2.2
.got 56784 57008 224 0.4
.rodata 506628 508404 1776 0.4
Increases (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 316e665 f362470 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668211 668475 264 0.0
.rodata 79683 79755 72 0.1
.text 588048 588240 192 0.0
lock-mtd LP_CC2652R7 (read only) 617339 617595 256 0.0
.rodata 79571 79635 64 0.1
.text 537280 537472 192 0.0
pump-app LP_CC2652R7 (read only) 687679 687935 256 0.0
.rodata 81767 81831 64 0.1
.text 605428 605620 192 0.0
pump-controller-app LP_CC2652R7 (read only) 669903 670167 264 0.0
.rodata 78103 78167 64 0.1
.text 591316 591516 200 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610854 611054 200 0.0
.app_xip_area 517564 517764 200 0.0
lock cyw930739m2evb_01 (read/write) 568362 568570 208 0.0
.app_xip_area 476616 476824 208 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 580014 580246 232 0.0
.app_xip_area 478624 478856 232 0.0
efr32 lighting-app BRD4161A (read only) 916124 916380 256 0.0
.text 916116 916372 256 0.0
BRD4161A+rpc (read only) 944028 944284 256 0.0
.text 944020 944276 256 0.0
window-app BRD4161A (read only) 851444 851604 160 0.0
.text 851436 851596 160 0.0
esp32 all-clusters-app c3devkit (read only) 985898 986106 208 0.0
(read/write) 1460570 1460634 64 0.0
.flash.rodata 197952 198016 64 0.0
.flash.text 985898 986106 208 0.0
m5stack (read only) 1038407 1038563 156 0.0
(read/write) 461608 461664 56 0.0
.flash.rodata 226936 226992 56 0.0
.flash.text 1033023 1033179 156 0.0
k32w light k32w061+release (read/write) 708068 708324 256 0.0
.text 622412 622668 256 0.0
lock k32w061+release (read/write) 707492 707740 248 0.0
.text 621796 622044 248 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10039220 10083476 44256 0.4
(read/write) 478305 486977 8672 1.8
.data.rel.ro 376264 384712 8448 2.2
.got 56784 57008 224 0.4
.rodata 506628 508404 1776 0.4
.text 8467764 8484228 16464 0.2
thermostat-no-ble arm64 (read only) 2312940 2314172 1232 0.1
.rodata 143116 143132 16 0.0
.text 1944224 1945440 1216 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2360332 2360580 248 0.0
.text 1322932 1323180 248 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148915 1149191 276 0.0
rodata 143292 143360 68 0.0
text 787692 787892 200 0.0
p6 all-clusters-app default (read/write) 2504504 2504744 240 0.0
.text 1462768 1463008 240 0.0
light-app default (read/write) 2405680 2405936 256 0.0
.text 1363944 1364200 256 0.0
lock-app default (read/write) 2369320 2369576 256 0.0
.text 1327584 1327840 256 0.0
telink lighting-app tlsr9518adk80d (read/write) 792316 792592 276 0.0
text 562168 562384 216 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section 316e665 f362470 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 183500 183236 -264 -0.1
pump-app LP_CC2652R7 (read/write) 165200 164944 -256 -0.2
pump-controller-app LP_CC2652R7 (read/write) 182712 182448 -264 -0.1
Full report (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 316e665 f362470 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668211 668475 264 0.0
(read/write) 183500 183236 -264 -0.1
.bss 81752 81752 0 0.0
.data 3164 3164 0 0.0
.rodata 79683 79755 72 0.1
.text 588048 588240 192 0.0
lock-mtd LP_CC2652R7 (read only) 617339 617595 256 0.0
(read/write) 154500 154500 0 0.0
.bss 77480 77480 0 0.0
.data 3164 3164 0 0.0
.rodata 79571 79635 64 0.1
.text 537280 537472 192 0.0
pump-app LP_CC2652R7 (read only) 687679 687935 256 0.0
(read/write) 165200 164944 -256 -0.2
.bss 82152 82152 0 0.0
.data 3196 3196 0 0.0
.rodata 81767 81831 64 0.1
.text 605428 605620 192 0.0
pump-controller-app LP_CC2652R7 (read only) 669903 670167 264 0.0
(read/write) 182712 182448 -264 -0.1
.bss 81888 81888 0 0.0
.data 3160 3160 0 0.0
.rodata 78103 78167 64 0.1
.text 591316 591516 200 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610854 611054 200 0.0
.app_xip_area 517564 517764 200 0.0
.bss 76004 76004 0 0.0
.data 632 632 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 568362 568570 208 0.0
.app_xip_area 476616 476824 208 0.0
.bss 74500 74500 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 580014 580246 232 0.0
.app_xip_area 478624 478856 232 0.0
.bss 83816 83816 0 0.0
.data 536 536 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916124 916380 256 0.0
(read/write) 129784 129784 0 0.0
.bss 127792 127792 0 0.0
.data 1992 1992 0 0.0
.text 916116 916372 256 0.0
BRD4161A+rpc (read only) 944028 944284 256 0.0
(read/write) 145732 145732 0 0.0
.bss 143560 143560 0 0.0
.data 2172 2172 0 0.0
.text 944020 944276 256 0.0
window-app BRD4161A (read only) 851444 851604 160 0.0
(read/write) 127808 127808 0 0.0
.bss 125936 125936 0 0.0
.data 1872 1872 0 0.0
.text 851436 851596 160 0.0
esp32 all-clusters-app c3devkit (read only) 985898 986106 208 0.0
(read/write) 1460570 1460634 64 0.0
.dram0.bss 62944 62944 0 0.0
.dram0.data 14196 14196 0 0.0
.flash.rodata 197952 198016 64 0.0
.flash.text 985898 986106 208 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1038407 1038563 156 0.0
(read/write) 461608 461664 56 0.0
.dram0.bss 68472 68472 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 226936 226992 56 0.0
.flash.text 1033023 1033179 156 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 708068 708324 256 0.0
.bss 77952 77952 0 0.0
.data 1904 1904 0 0.0
.text 622412 622668 256 0.0
lock k32w061+release (read/write) 707492 707740 248 0.0
.bss 77952 77952 0 0.0
.data 1944 1944 0 0.0
.text 621796 622044 248 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10039220 10083476 44256 0.4
(read/write) 478305 486977 8672 1.8
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 376264 384712 8448 2.2
.dynamic 560 560 0 0.0
.got 56784 57008 224 0.4
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 506628 508404 1776 0.4
.text 8467764 8484228 16464 0.2
thermostat-no-ble arm64 (read only) 2312940 2314172 1232 0.1
(read/write) 149361 149361 0 0.0
.bss 62945 62945 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 77640 77640 0 0.0
.dynamic 560 560 0 0.0
.got 4624 4624 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 143116 143132 16 0.0
.text 1944224 1945440 1216 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360332 2360580 248 0.0
.bss 185036 185036 0 0.0
.data 5784 5784 0 0.0
.text 1322932 1323180 248 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148915 1149191 276 0.0
bss 143060 143060 0 0.0
rodata 143292 143360 68 0.0
text 787692 787892 200 0.0
p6 all-clusters-app default (read/write) 2504504 2504744 240 0.0
.bss 118472 118472 0 0.0
.data 2672 2672 0 0.0
.text 1462768 1463008 240 0.0
light-app default (read/write) 2405680 2405936 256 0.0
.bss 111928 111928 0 0.0
.data 2528 2528 0 0.0
.text 1363944 1364200 256 0.0
lock-app default (read/write) 2369320 2369576 256 0.0
.bss 111672 111672 0 0.0
.data 2488 2488 0 0.0
.text 1327584 1327840 256 0.0
telink lighting-app tlsr9518adk80d (read/write) 792316 792592 276 0.0
bss 70288 70288 0 0.0
noinit 40416 40416 0 0.0
text 562168 562384 216 0.0

@woody-apple woody-apple merged commit 19bf3a5 into project-chip:master Apr 5, 2022
@jmartinez-silabs jmartinez-silabs deleted the test_startupOnOff branch April 5, 2022 12:19
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@jmartinez-silabs @restyled-commits @chencheung
Add tests in Test_TC_OO_2_4 for OnOff StartupOnOff behaviours (projec…
6f96d8d 
…t-chip#17012)

* Implement test case oo 2_4. test startup on off with reboot

* Wait for commissionned device discovery after reboot + save StartUpOnOff attribute in nvm for all-cluster-app

* Restyled by whitespace

* Restyled by clang-format

* disable Test for Darwin as it does not support reboot command currently

Co-authored-by: Restyled.io <[email protected]>
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@jmartinez-silabs @restyled-commits @chencheung
Add tests in Test_TC_OO_2_4 for OnOff StartupOnOff behaviours (projec…
8dc064b 
…t-chip#17012)

* Implement test case oo 2_4. test startup on off with reboot

* Wait for commissionned device discovery after reboot + save StartUpOnOff attribute in nvm for all-cluster-app

* Restyled by whitespace

* Restyled by clang-format

* disable Test for Darwin as it does not support reboot command currently

Co-authored-by: Restyled.io <[email protected]>
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@jmartinez-silabs @restyled-commits @andrei-menzopol
Add tests in Test_TC_OO_2_4 for OnOff StartupOnOff behaviours (projec…
05a71ec 
…t-chip#17012)

* Implement test case oo 2_4. test startup on off with reboot

* Wait for commissionned device discovery after reboot + save StartUpOnOff attribute in nvm for all-cluster-app

* Restyled by whitespace

* Restyled by clang-format

* disable Test for Darwin as it does not support reboot command currently

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app darwin examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmartinez-silabs @woody-apple @restyled-commits