-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set OnOff StartUpOff attribute as nullable #16377
Merged
jmartinez-silabs
merged 5 commits into
project-chip:master
from
jmartinez-silabs:onoff_startup
Mar 21, 2022
Merged
Set OnOff StartUpOff attribute as nullable #16377
jmartinez-silabs
merged 5 commits into
project-chip:master
from
jmartinez-silabs:onoff_startup
Mar 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu and
chulspro
March 17, 2022 15:59
pullapprove
bot
requested review from
xylophone21,
woody-apple,
yufengwangca and
yunhanw-google
March 17, 2022 15:59
PR #16377: Size comparison from 4f22a79 to 5161f35 Increases (13 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #16377: Size comparison from 4f22a79 to 8aa61b6 Increases (14 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Mar 17, 2022
jmartinez-silabs
force-pushed
the
onoff_startup
branch
from
March 21, 2022 14:18
8aa61b6
to
ef36047
Compare
jepenven-silabs
approved these changes
Mar 21, 2022
PR #16377: Size comparison from 7d1256f to ef36047 Increases (19 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 21, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* OnOff StartUpOnOff attribute is nullable * regen * remove case EMBER_ZCL_START_UP_ON_OFF_VALUE_SET_TO_PREVIOUS. Already handled if startUpOnOff is null * Address PR comments * Fix conflicts by rebase and regen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fixes #16056 as attribute StartUpOff was not nullable
Change overview
set StartUpOff are nullable.
reflect this "type" change in the on-off-server/on-off-server.cpp
Testing
Test writing attribute with null and reading it back.
run test suite to validate there isn't any regression.