Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darwin]Fix segmentation fault on writing userLabelList #17005

Merged
merged 1 commit into from
Apr 4, 2022
Merged

[Darwin]Fix segmentation fault on writing userLabelList #17005

merged 1 commit into from
Apr 4, 2022

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • GetDeviceInfoProvider is currently only installed on Linux platform, we should have null check on it before using it for writing a userLabelList.

Change overview

Do null check for GetDeviceInfoProvider in WriteLabelList.

Testing

How was this tested? (at least one bullet point required)

@boring-cyborg boring-cyborg bot added the app label Apr 4, 2022
@github-actions
Copy link

github-actions bot commented Apr 4, 2022 •
edited
Loading

PR #17005: Size comparison from 3666138 to d894df0

Increases (26 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 3666138 d894df0 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668091 668123 32 0.0
.text 587928 587960 32 0.0
lock-mtd LP_CC2652R7 (read only) 617211 617243 32 0.0
.text 537160 537192 32 0.0
pump-app LP_CC2652R7 (read only) 687543 687575 32 0.0
.text 605300 605332 32 0.0
pump-controller-app LP_CC2652R7 (read only) 669775 669807 32 0.0
.text 591196 591228 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610682 610714 32 0.0
.app_xip_area 517456 517488 32 0.0
lock cyw930739m2evb_01 (read/write) 568202 568226 24 0.0
.app_xip_area 476504 476528 24 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 579790 579814 24 0.0
.app_xip_area 478460 478484 24 0.0
efr32 lighting-app BRD4161A+rpc (read only) 944048 944064 16 0.0
.text 944040 944056 16 0.0
window-app BRD4161A (read only) 851480 851496 16 0.0
.text 851472 851488 16 0.0
esp32 all-clusters-app c3devkit (read only) 985940 985966 26 0.0
.flash.text 985940 985966 26 0.0
m5stack (read only) 1038339 1038343 4 0.0
.flash.text 1032955 1032959 4 0.0
k32w light k32w061+release (read/write) 707908 707924 16 0.0
.text 622296 622312 16 0.0
lock k32w061+release (read/write) 707316 707332 16 0.0
.text 621680 621696 16 0.0
linux all-clusters-app debug (read only) 2576609 2576657 48 0.0
.text 2188642 2188690 48 0.0
bridge-app debug+rpc (read only) 1787181 1787229 48 0.0
.text 1524213 1524261 48 0.0
door-lock-app debug (read only) 2057977 2058041 64 0.0
.text 1719890 1719954 64 0.0
lighting-app debug+rpc (read only) 2236209 2236257 48 0.0
.text 1894514 1894562 48 0.0
ota-provider-app debug (read only) 1995985 1996049 64 0.0
.text 1671154 1671218 64 0.0
ota-requestor-app debug (read only) 2024785 2024849 64 0.0
.text 1702098 1702162 64 0.0
shell debug (read only) 2473937 2473985 48 0.0
.text 2103666 2103714 48 0.0
thermostat-no-ble arm64 (read only) 2311068 2311132 64 0.0
.text 1943040 1943104 64 0.0
tv-app debug (read only) 2741337 2741401 64 0.0
.text 2352882 2352946 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148795 1148827 32 0.0
text 787612 787640 28 0.0
p6 all-clusters-app default (read/write) 2504592 2504608 16 0.0
.text 1462856 1462872 16 0.0
lock-app default (read/write) 2369384 2369400 16 0.0
.text 1327648 1327664 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 792340 792364 24 0.0
text 562250 562276 26 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section 3666138 d894df0 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 183604 183572 -32 -0.0
pump-app LP_CC2652R7 (read/write) 165312 165280 -32 -0.0
pump-controller-app LP_CC2652R7 (read/write) 182824 182792 -32 -0.0
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 3666138 d894df0 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668091 668123 32 0.0
(read/write) 183604 183572 -32 -0.0
.bss 81736 81736 0 0.0
.data 3128 3128 0 0.0
.rodata 79683 79683 0 0.0
.text 587928 587960 32 0.0
lock-mtd LP_CC2652R7 (read only) 617211 617243 32 0.0
(read/write) 154448 154448 0 0.0
.bss 77464 77464 0 0.0
.data 3128 3128 0 0.0
.rodata 79563 79563 0 0.0
.text 537160 537192 32 0.0
pump-app LP_CC2652R7 (read only) 687543 687575 32 0.0
(read/write) 165312 165280 -32 -0.0
.bss 82128 82128 0 0.0
.data 3160 3160 0 0.0
.rodata 81759 81759 0 0.0
.text 605300 605332 32 0.0
pump-controller-app LP_CC2652R7 (read only) 669775 669807 32 0.0
(read/write) 182824 182792 -32 -0.0
.bss 81872 81872 0 0.0
.data 3124 3124 0 0.0
.rodata 78095 78095 0 0.0
.text 591196 591228 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610682 610714 32 0.0
.app_xip_area 517456 517488 32 0.0
.bss 75980 75980 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 568202 568226 24 0.0
.app_xip_area 476504 476528 24 0.0
.bss 74484 74484 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 579790 579814 24 0.0
.app_xip_area 478460 478484 24 0.0
.bss 83796 83796 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916168 916168 0 0.0
(read/write) 129728 129728 0 0.0
.bss 127768 127768 0 0.0
.data 1956 1956 0 0.0
.text 916160 916160 0 0.0
BRD4161A+rpc (read only) 944048 944064 16 0.0
(read/write) 145680 145680 0 0.0
.bss 143544 143544 0 0.0
.data 2136 2136 0 0.0
.text 944040 944056 16 0.0
window-app BRD4161A (read only) 851480 851496 16 0.0
(read/write) 127752 127752 0 0.0
.bss 125912 125912 0 0.0
.data 1836 1836 0 0.0
.text 851472 851488 16 0.0
esp32 all-clusters-app c3devkit (read only) 985940 985966 26 0.0
(read/write) 1460530 1460530 0 0.0
.dram0.bss 62920 62920 0 0.0
.dram0.data 14164 14164 0 0.0
.flash.rodata 197960 197960 0 0.0
.flash.text 985940 985966 26 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1038339 1038343 4 0.0
(read/write) 461544 461544 0 0.0
.dram0.bss 68448 68448 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 226928 226928 0 0.0
.flash.text 1032955 1032959 4 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 707908 707924 16 0.0
.bss 77944 77944 0 0.0
.data 1868 1868 0 0.0
.text 622296 622312 16 0.0
lock k32w061+release (read/write) 707316 707332 16 0.0
.bss 77928 77928 0 0.0
.data 1908 1908 0 0.0
.text 621680 621696 16 0.0
linux all-clusters-app debug (read only) 2576609 2576657 48 0.0
(read/write) 144360 144360 0 0.0
.bss 57536 57536 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 79608 79608 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 220549 220549 0 0.0
.text 2188642 2188690 48 0.0
bridge-app debug+rpc (read only) 1787181 1787229 48 0.0
(read/write) 89912 89912 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 38320 38320 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 146937 146937 0 0.0
.text 1524213 1524261 48 0.0
chip-tool debug (read only) 10436029 10436029 0 0.0
(read/write) 358552 358552 0 0.0
.bss 22016 22016 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 329272 329272 0 0.0
.dynamic 624 624 0 0.0
.got 4896 4896 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 532205 532205 0 0.0
.text 9111349 9111349 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10036540 10036540 0 0.0
(read/write) 478177 478177 0 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 376144 376144 0 0.0
.dynamic 560 560 0 0.0
.got 56768 56768 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 506524 506524 0 0.0
.text 8465492 8465492 0 0.0
door-lock-app debug (read only) 2057977 2058041 64 0.0
(read/write) 117808 117808 0 0.0
.bss 47776 47776 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 63416 63416 0 0.0
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 184873 184873 0 0.0
.text 1719890 1719954 64 0.0
lighting-app debug+rpc (read only) 2236209 2236257 48 0.0
(read/write) 124800 124800 0 0.0
.bss 49120 49120 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 68488 68488 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179017 179017 0 0.0
.text 1894514 1894562 48 0.0
ota-provider-app debug (read only) 1995985 1996049 64 0.0
(read/write) 113408 113408 0 0.0
.bss 47616 47616 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 58728 58728 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 170707 170707 0 0.0
.text 1671154 1671218 64 0.0
ota-requestor-app debug (read only) 2024785 2024849 64 0.0
(read/write) 116632 116632 0 0.0
.bss 48608 48608 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 60936 60936 0 0.0
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 166908 166908 0 0.0
.text 1702098 1702162 64 0.0
shell debug (read only) 2473937 2473985 48 0.0
(read/write) 147888 147888 0 0.0
.bss 67240 67240 0 0.0
.data 784 784 0 0.0
.data.rel.ro 74136 74136 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212338 212338 0 0.0
.text 2103666 2103714 48 0.0
thermostat-no-ble arm64 (read only) 2311068 2311132 64 0.0
(read/write) 149057 149057 0 0.0
.bss 62913 62913 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 77488 77488 0 0.0
.dynamic 560 560 0 0.0
.got 4568 4568 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 142908 142908 0 0.0
.text 1943040 1943104 64 0.0
tv-app debug (read only) 2741337 2741401 64 0.0
(read/write) 249312 249312 0 0.0
.bss 165200 165200 0 0.0
.data 3296 3296 0 0.0
.data.rel.ro 74648 74648 0 0.0
.dynamic 592 592 0 0.0
.got 4656 4656 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 210635 210635 0 0.0
.text 2352882 2352946 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360020 2360020 0 0.0
.bss 185020 185020 0 0.0
.data 5752 5752 0 0.0
.text 1322620 1322620 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148795 1148827 32 0.0
bss 143048 143048 0 0.0
rodata 143292 143292 0 0.0
text 787612 787640 28 0.0
p6 all-clusters-app default (read/write) 2504592 2504608 16 0.0
.bss 118456 118456 0 0.0
.data 2632 2632 0 0.0
.text 1462856 1462872 16 0.0
light-app default (read/write) 2405752 2405752 0 0.0
.bss 111912 111912 0 0.0
.data 2488 2488 0 0.0
.text 1364016 1364016 0 0.0
lock-app default (read/write) 2369384 2369400 16 0.0
.bss 111656 111656 0 0.0
.data 2448 2448 0 0.0
.text 1327648 1327664 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 792340 792364 24 0.0
bss 70264 70264 0 0.0
noinit 40416 40416 0 0.0
text 562250 562276 26 0.0

@woody-apple woody-apple merged commit f03d4df into project-chip:master Apr 4, 2022
@yufengwangca yufengwangca deleted the pr/userlabel/write branch April 4, 2022 18:33
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@yufengwangca @chencheung
[Darwin]Fix segmentation fault on writing userLabelList (project-chip…
25c211c 
…#17005)
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@yufengwangca @chencheung
[Darwin]Fix segmentation fault on writing userLabelList (project-chip…
f323f50 
…#17005)
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@yufengwangca @andrei-menzopol
[Darwin]Fix segmentation fault on writing userLabelList (project-chip…
92bcccd 
…#17005)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yufengwangca @tcarmelveilleux @woody-apple