Skip to content

Commit

Permalink
Fix admin id used in the peer-to-local session in messaging context. (#…
Browse files Browse the repository at this point in the history
…8049)

Without this, trying to use NewExchangeToLocal to simulate an
unsolicited incoming message fails to do the right thing because we
end up not matching up the MRP ack to the message's exchange
correctly, since the admin ids mismatch.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Aug 31, 2021
1 parent 1af8fdb commit 1702162
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/messaging/tests/MessagingContext.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ SecureSessionHandle MessagingContext::GetSessionLocalToPeer()
SecureSessionHandle MessagingContext::GetSessionPeerToLocal()
{
// TODO: temporarily create a SecureSessionHandle from node id, will be fixed in PR 3602
return { GetSourceNodeId(), GetLocalKeyId(), GetAdminId() };
return { GetSourceNodeId(), GetLocalKeyId(), mDestAdminId };
}

Messaging::ExchangeContext * MessagingContext::NewExchangeToPeer(Messaging::ExchangeDelegate * delegate)
Expand Down

0 comments on commit 1702162

Please sign in to comment.