Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for GitHub labeler, fixes #1008 #1693

Merged
merged 19 commits into from
Jul 23, 2020

Conversation

woody-apple
Copy link
Contributor

Problem

Trying to organize issues and PRs a little better as we're scaling out.

Per suggestion, looks like we might have a tool that can help us out: https://github.com/marketplace/actions/labeler

Summary of Changes

fixes #1008

(Note, couple more changes coming as I test a couple things)

@woody-apple
Copy link
Contributor Author

@saurabhst @robszewczyk @jelderton @anush-apple @andy31415 Given the way this labeler works, this will be way easier and faster to iterate on in master if I directly commit, given how labels and GitHub permissions work. Does anyone have any objections about me doing that?

@woody-apple
Copy link
Contributor Author

@jelderton I think this is ready for review now, been testing on my fork... crossing fingers should work now 👍

@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@woody-apple
Copy link
Contributor Author

@robszewczyk @jelderton ?

@woody-apple woody-apple merged commit c8541ef into project-chip:master Jul 23, 2020
@woody-apple woody-apple deleted the label branch June 4, 2021 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CHIP needs components
4 participants