-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHIP needs components #1008
Comments
Assigning to @mrjerryjohns per discussion. Can we have a proposed set of labels here, as well as some process to handle keeping these up to date? |
Broadly speaking, I'd recommend a two-tier labelling schema, with a master component and a sub-component described as "master:sub", with the sub-component being optional/omitted as needed.
|
Is this list different that the directory structure in place? My general questions are (process wise): |
It's derived from, but not an exact match. In some cases, I clumped a bunch of sub-folders together (like platform/* into 'platform', though if we want that granularity in the future, we can add platform-efr32 for example). It was a function of where we needed distinction and the amount of work that will happen there (e.g ZCL will have a fair bit of work and diversity of issues, while the lwip layer, unlikely).
Not sure what you mean - it's defined in Github, by someone like you who has permissions. Once we agree upon this initial set, I was hoping you would add it.
They should be assigned at bug creation time by the initial bug creator. They can be updated by anyone if the scope changes. |
@woody-apple any thoughts? |
One recommendation I would have is to put non-trivial effort into avoiding
generic names like 'utilities', 'helpers', 'core' and similar. I believe
they are unavoidable in the end, but we should at least try and recognize
that when we name something a 'util class' it is admitting defeat to
organize things. At least adding a level, like 'testutils' rather than
'utils'. As a code reader, I would specifically call out that 'core' tells
me nothing about what is or should be in that particular code area.
Regards,
Andrei
…On Wed, Jun 24, 2020 at 6:14 PM Jerry Johns ***@***.***> wrote:
@woody-apple <https://github.com/woody-apple> any thoughts?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1008 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN7KWGIXHK25EYKVMNQYJLRYJ3E5ANCNFSM4NS3E64A>
.
|
Any suggestions to iterate on the above list are welcome, and I would like to see if we can get these figured out this week. |
Problem
CHIP is large, complicated, has many moving parts, some of them labeled, some not.
Proposed Solution
come up with and add component labels to this project
The text was updated successfully, but these errors were encountered: