Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIP needs components #1008

Closed
rwalker-apple opened this issue Jun 4, 2020 · 7 comments · Fixed by #1693
Closed

CHIP needs components #1008

rwalker-apple opened this issue Jun 4, 2020 · 7 comments · Fixed by #1693
Assignees
Milestone

Comments

@rwalker-apple
Copy link
Contributor

Problem

CHIP is large, complicated, has many moving parts, some of them labeled, some not.

Proposed Solution

come up with and add component labels to this project

@woody-apple
Copy link
Contributor

Assigning to @mrjerryjohns per discussion. Can we have a proposed set of labels here, as well as some process to handle keeping these up to date?

@mrjerryjohns
Copy link
Contributor

mrjerryjohns commented Jun 9, 2020

Broadly speaking, I'd recommend a two-tier labelling schema, with a master component and a sub-component described as "master:sub", with the sub-component being optional/omitted as needed.

platform
lwip
inet
crypto
system
core
zcl
zcl:core
zcl:plugins
zcl:codegen
app
tools
misc

@woody-apple
Copy link
Contributor

Is this list different that the directory structure in place?

My general questions are (process wise):
• How are labels defined?
• How are labels assigned/updated/removed?

@mrjerryjohns
Copy link
Contributor

Is this list different that the directory structure in place?

It's derived from, but not an exact match. In some cases, I clumped a bunch of sub-folders together (like platform/* into 'platform', though if we want that granularity in the future, we can add platform-efr32 for example).

It was a function of where we needed distinction and the amount of work that will happen there (e.g ZCL will have a fair bit of work and diversity of issues, while the lwip layer, unlikely).

How are labels defined?

Not sure what you mean - it's defined in Github, by someone like you who has permissions. Once we agree upon this initial set, I was hoping you would add it.

How are labels assigned/updated/removed

They should be assigned at bug creation time by the initial bug creator. They can be updated by anyone if the scope changes.

@mrjerryjohns
Copy link
Contributor

@woody-apple any thoughts?

@andy31415
Copy link
Contributor

andy31415 commented Jun 25, 2020 via email

@mrjerryjohns
Copy link
Contributor

Any suggestions to iterate on the above list are welcome, and I would like to see if we can get these figured out this week.

@woody-apple woody-apple self-assigned this Jul 22, 2020
woody-apple added a commit that referenced this issue Jul 23, 2020
* Initial checkin

* Adding size

* Updating copyrights, and moving to labeller

* Run every few minutes, doesn't work on PRs sadly

* Fixing naming

* Removing size, won't work on forks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants