-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Added Lighting-Switch-App example #16668
Merged
Damian-Nordic
merged 4 commits into
project-chip:master
from
ArekBalysNordic:LightSwitch_Groups
Mar 28, 2022
Merged
[nrfconnect] Added Lighting-Switch-App example #16668
Damian-Nordic
merged 4 commits into
project-chip:master
from
ArekBalysNordic:LightSwitch_Groups
Mar 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov and
LuDuda
March 25, 2022 13:17
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
March 25, 2022 13:17
ArekBalysNordic
force-pushed
the
LightSwitch_Groups
branch
from
March 25, 2022 13:22
f856cda
to
6eed828
Compare
PR #16668: Size comparison from 197f65f to 6eed828 Increases (9 builds for nrfconnect)
Full report (35 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 25, 2022
Damian-Nordic
approved these changes
Mar 25, 2022
PR #16668: Size comparison from 197f65f to 33c1996 Increases (9 builds for nrfconnect)
Decreases (21 builds for cyw30739, efr32, esp32, linux, p6, telink)
Full report (35 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Mar 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking platform changes.
/rebase |
Problem Add Lighting-Switch-App example for nrfconnect boards. Change overview Added example of Light-Switch-App for nRF52DK and nRF53DK boards Added documentation for example Testing Tested manually on nRF52DK and nRF53DK using lighting-app example as bound device.
woody-apple
force-pushed
the
LightSwitch_Groups
branch
from
March 26, 2022 04:23
33c1996
to
4cfadf1
Compare
PR #16668: Size comparison from e5c39d4 to 4cfadf1 Increases (9 builds for nrfconnect)
Full report (35 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Mar 31, 2022
* [nrfconnect] Added Lighting-Switch-App example Problem Add Lighting-Switch-App example for nrfconnect boards. Change overview Added example of Light-Switch-App for nRF52DK and nRF53DK boards Added documentation for example Testing Tested manually on nRF52DK and nRF53DK using lighting-app example as bound device. * Restyled by clang-format * Restyled by prettier-markdown * Restyled by prettier-markdown Co-authored-by: Restyled.io <[email protected]>
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* [nrfconnect] Added Lighting-Switch-App example Problem Add Lighting-Switch-App example for nrfconnect boards. Change overview Added example of Light-Switch-App for nRF52DK and nRF53DK boards Added documentation for example Testing Tested manually on nRF52DK and nRF53DK using lighting-app example as bound device. * Restyled by clang-format * Restyled by prettier-markdown * Restyled by prettier-markdown Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Added example of Light-Switch-App for nRF52DK and nRF53DK boards
Added documentation
Testing