Skip to content

Commit

Permalink
Adds chip_enable_icd_server=true for lock app gn command
Browse files Browse the repository at this point in the history
Renames GnBuildArgs to GnBuildArgsLocal in gn.py as it was being overriden by HostBuilder in host.py
  • Loading branch information
raul-marquez-csa committed Jan 29, 2024
1 parent 723efe0 commit 2436633
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions scripts/build/builders/gn.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,18 @@ def __init__(self, root, runner):

self.build_command = None

def GnBuildArgs(self):
def GnBuildArgsLocal(self):
"""Extra gn build `--args`
If used, returns a list of arguments.
"""
return None

extra_args = []

if "/lock-app" in self.root:
extra_args.append("chip_enable_icd_server=true")

return extra_args

def GnBuildEnv(self):
"""Extra environment variables needed for the GN build to run.
Expand Down Expand Up @@ -67,7 +73,7 @@ def generate(self):
if self.options.pregen_dir:
extra_args.append('chip_code_pre_generated_directory="%s"' % self.options.pregen_dir)

extra_args.extend(self.GnBuildArgs() or [])
extra_args.extend(self.GnBuildArgsLocal())
if extra_args:
cmd += ['--args=%s' % ' '.join(extra_args)]

Expand Down

0 comments on commit 2436633

Please sign in to comment.