Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address DNS-SD issues #16625

Merged
merged 5 commits into from
Mar 25, 2022
Merged

Address DNS-SD issues #16625

merged 5 commits into from
Mar 25, 2022

Conversation

chrisdecenzo
Copy link
Contributor

@chrisdecenzo chrisdecenzo commented Mar 24, 2022

Problem

Change overview

  • use "initial" pairing hint value when not yet commissioned, and not only during ECM (current logic)
  • change extended discovery timeout value from int16 to int32 to allow longer values
  • do not prefer v4 address in UDC when v4 is disabled (prefer v6 address)

Testing

How was this tested? (at least one bullet point required)

  • Run sample device, use chip-tool to discover commissionables and check the PH values when not commissioned, and when put in commissioning mode via BCM and ECM.

@github-actions
Copy link

PR #16625: Size comparison from 011efcf to 4038dc0

Decreases (1 build for nrfconnect)
platform target config section 011efcf0 4038dc0 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 780764 780760 -4 -0.0
Full report (1 build for nrfconnect)
platform target config section 011efcf0 4038dc0 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1140039 1140039 0 0.0
bss 142512 142512 0 0.0
rodata 141912 141912 0 0.0
text 780764 780760 -4 -0.0

@chrisdecenzo chrisdecenzo merged commit a57bd4d into master Mar 25, 2022
@chrisdecenzo chrisdecenzo deleted the tv-apps9 branch March 25, 2022 22:34
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Mar 31, 2022
* fix PH, allow for longer extended discovery timeout

* ci fix

* address comments

* fix v6-only tv-app casting

* fix CI
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
* fix PH, allow for longer extended discovery timeout

* ci fix

* address comments

* fix v6-only tv-app casting

* fix CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants