Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS-SD pairing hint field is incorrect when using BCM and already commissioned #16237

Closed
chrisdecenzo opened this issue Mar 15, 2022 · 0 comments
Assignees
Labels

Comments

@chrisdecenzo
Copy link
Contributor

Problem

  • The pairing hint field must have bit 2 set (see admin UX) when a device has been commissioned before
  • Currently, bit 2 is set only when the device is put into commissioning mode using ECM. When using BCM, bit 2 is not set.

Proposed Solution

Bug is in Dnssd.cpp, method DnssdServer::Advertise, approximate line 379, the following check:

if (mode != chip::Dnssd::CommissioningMode::kEnabledEnhanced)

The fix would be to check if CommissioningMode::kEnabledEnhanced or if CommissioningMode::kEnabledBasic when already commissioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant