[logging] Refactored logged messages #16528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
app
config
examples
lib
openthread
platform
system
zephyr
labels
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton and
jepenven-silabs
pullapprove
bot
requested review from
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
msandstedt,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
|
PR #16528: Size comparison from 2e658fb to 99b8876 Increases (20 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
Decreases (11 builds for cyw30739, nrfconnect)
Full report (35 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 23, 2022
Many messages are logged in the scope that doesn't seem to be appropriate (errors as progress, very detail info as progress etc.) * Briefly reviewed ChipLog calls and changed scopes where it seemed to be valuable For nrfconnect: * Added setting gn chip logging flags depending on Kconfig CONFIG_MATTER_LOG_LEVEL option * Disabled not used shell modules * Changed Zephyr modules default log level from info to warning (all Zephyr modules are set to warning and only those that are important are set to info)
kkasperczyk-no
force-pushed
the
logs_and_shell_optimization_p
branch
from
99b8876 to
cd9ff14
Compare
|
Rebased |
|
PR #16528: Size comparison from dd2f7e0 to cd9ff14 Increases (14 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
Decreases (11 builds for cyw30739, nrfconnect)
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
approved these changes
Mar 23, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
Many messages are logged in the scope that doesn't seem to be appropriate (errors as progress, very detail info as progress etc.) * Briefly reviewed ChipLog calls and changed scopes where it seemed to be valuable For nrfconnect: * Added setting gn chip logging flags depending on Kconfig CONFIG_MATTER_LOG_LEVEL option * Disabled not used shell modules * Changed Zephyr modules default log level from info to warning (all Zephyr modules are set to warning and only those that are important are set to info)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Many messages are logged in the scope that doesn't seem to be appropriate (errors as progress, very detail info as progress etc.)
Change overview
For nrfconnect:
important are set to info)
Testing
Manually tested building and log levels filtering.