Add Application Callback for Subscription Handling #16517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new ReadHandler::ApplicationCallback that permits notifying the application of notable happenings on subscriptions as well as giving them a chance to alter the min/max intervals setup as part of subscriptions. Tests: - Add some unit tests to TestRead to validate the positive/negative behaviors added.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google and
msandstedt
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #16517: Size comparison from 6443a56 to 0db0f41 Increases (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
requested changes
Mar 23, 2022
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #16517: Size comparison from 0fe4757 to 152f28c Increases (25 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (4 builds for linux)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #16517: Size comparison from 125e73c to 1ad2d83 Increases (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 29, 2022
yunhanw-google
approved these changes
Mar 30, 2022
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Mar 31, 2022
* Add Application Callback for Subscription Handling Adds a new ReadHandler::ApplicationCallback that permits notifying the application of notable happenings on subscriptions as well as giving them a chance to alter the min/max intervals setup as part of subscriptions. Tests: - Add some unit tests to TestRead to validate the positive/negative behaviors added. * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Review feedback. * Removing a bunch of accidentally added files... Co-authored-by: Boris Zbarsky <[email protected]>
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* Add Application Callback for Subscription Handling Adds a new ReadHandler::ApplicationCallback that permits notifying the application of notable happenings on subscriptions as well as giving them a chance to alter the min/max intervals setup as part of subscriptions. Tests: - Add some unit tests to TestRead to validate the positive/negative behaviors added. * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Review feedback. * Removing a bunch of accidentally added files... Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
ReadHandler::ApplicationCallbackthat permits notifying the application of notable happenings on subscriptions as well as giving them a chance to alter the min/max intervals setup as part ofsubscriptions.
This also alters the public/private slicing of the APIs in
ReadHandlerwhere 'public' previously denoted APIs that otherIM-internal classes (like
reporting::EngineorInteractionModelEngine) accessed. Since this PR makes it such that the application-proper can now access some of the APIs inReadHandler, I've madepublicreally denote application-facing APIs, and moved the rest into private + friends.Tests: