-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CommissionableDataProvider on android platform #16475
Merged
lazarkov
merged 9 commits into
project-chip:master
from
xylophone21:android-platform-CommissionableDataProvider
Mar 25, 2022
Merged
add CommissionableDataProvider on android platform #16475
lazarkov
merged 9 commits into
project-chip:master
from
xylophone21:android-platform-CommissionableDataProvider
Mar 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt and
robszewczyk
March 19, 2022 12:35
PR #16475: Size comparison from a3390fd to 789a4dd Increases (5 builds for efr32, esp32, linux, nrfconnect, p6)
Decreases (15 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
reviewed
Mar 21, 2022
...es/tv-app/android/App/app/src/main/java/com/tcl/chip/chiptvserver/service/MatterServant.java
Outdated
Show resolved
Hide resolved
xylophone21
force-pushed
the
android-platform-CommissionableDataProvider
branch
2 times, most recently
from
March 23, 2022 09:20
7fa047e
to
c6b98c0
Compare
PR #16475: Size comparison from ae5a36a to b2577d7 Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
xylophone21
force-pushed
the
android-platform-CommissionableDataProvider
branch
from
March 23, 2022 14:17
b2577d7
to
df8c63c
Compare
andy31415
approved these changes
Mar 23, 2022
PR #16475: Size comparison from 4a33c98 to df8c63c Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
lazarkov
approved these changes
Mar 24, 2022
chrisdecenzo
approved these changes
Mar 24, 2022
xylophone21
force-pushed
the
android-platform-CommissionableDataProvider
branch
from
March 25, 2022 06:39
df8c63c
to
0f76aa6
Compare
PR #16475: Size comparison from 197f65f to 0f76aa6 Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
lazarkov
approved these changes
Mar 25, 2022
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Mar 31, 2022
* add CommissionableDataProvider on android platform * fix restyled-io and ci errors * remove commented * fix restyled-io and ci errors * fix PR comment * fix restyled-io and ci errors * fix PR comment * fix restyled-io and ci errors * fix restyled-io and ci errors
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* add CommissionableDataProvider on android platform * fix restyled-io and ci errors * remove commented * fix restyled-io and ci errors * fix PR comment * fix restyled-io and ci errors * fix PR comment * fix restyled-io and ci errors * fix restyled-io and ci errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing