-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTA] Remove global resolver initialization from OTA Requestor #16388
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
carol-apple:ota_requestor_remove_init_resolver
Mar 18, 2022
Merged
[OTA] Remove global resolver initialization from OTA Requestor #16388
bzbarsky-apple
merged 1 commit into
project-chip:master
from
carol-apple:ota_requestor_remove_init_resolver
Mar 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is already done in Server
pullapprove
bot
requested review from
andy31415,
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
mrjerryjohns,
msandstedt,
mspang and
robszewczyk
March 17, 2022 19:13
pullapprove
bot
requested review from
lzgrablic02,
mrjerryjohns,
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
March 17, 2022 19:13
bauerschwan
approved these changes
Mar 17, 2022
selissia
approved these changes
Mar 17, 2022
andy31415
approved these changes
Mar 17, 2022
PR #16388: Size comparison from 84c150a to c31ecfc Decreases (1 build for linux)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
approved these changes
Mar 17, 2022
bzbarsky-apple
approved these changes
Mar 18, 2022
ArekBalysNordic
pushed a commit
to ArekBalysNordic/connectedhomeip
that referenced
this pull request
Mar 18, 2022
…ct-chip#16388) - This is already done in Server
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…ct-chip#16388) - This is already done in Server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After #16230, the global resolver is already initialized in the Server class
Change overview
Remove the extraneous init call in the requestor app
Testing
Verified happy path for OTA transfer succeeds