Ensure ResolverProxy maintains callbacks until init is called. Ensure… #16230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… server app always initializes the global resolver
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02 and
mlepage-google
pullapprove
bot
requested review from
kghost,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #16230: Size comparison from 494cfb2 to 876341d Increases (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
selissia
approved these changes
Mar 15, 2022
carol-apple
reviewed
Mar 15, 2022
| @@ -197,6 +197,8 @@ CHIP_ERROR Server::Init(AppDelegate * delegate, uint16_t secureServicePort, uint | |||
| err = chip::app::InteractionModelEngine::GetInstance()->Init(&mExchangeMgr); | |||
| SuccessOrExit(err); | |||
|
|
|||
| chip::Dnssd::Resolver::Instance().Init(DeviceLayer::UDPEndPointManager()); | |||
There was a problem hiding this comment.
This is already done in OTA Requestor... should it be removed there? https://github.com/project-chip/connectedhomeip/blob/master/examples/ota-requestor-app/linux/main.cpp#L184
There was a problem hiding this comment.
Yes, I'd think Server.cpp is the right home for this bit of logic.
There was a problem hiding this comment.
Maybe as a followup? I believe I had added that bit to make CI pass, however it seems obvious now that this needs to be more generic (i.e. all servers have it) instead of just for the requestor app.
mrjerryjohns
approved these changes
Mar 15, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
… server app always initializes the global resolver (project-chip#16230)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… server app always initializes the global resolver
Problem
OTA on thread does not work (address resolution fails):
ResolverProxywill only store callbacks after it is initialized, but initialization is async and happens late (e.g. on SRP init, which is only available very late, after thread is set up and working).Change overview
ResolverProxystore callbacks until init is calledTesting
Manual OTA announcement on a EFR device.