-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default value of cluster revision attribute on identify cluster #16375
Fix default value of cluster revision attribute on identify cluster #16375
Conversation
Yes, need to add the same change for other apps too |
I will do the same change in other apps and then will do restyle |
Similar change would be required for On/Off cluster as well: https://github.com/CHIP-Specifications/chip-test-plans/issues/282. |
@bzbarsky-apple should this change be done for all the other clusters too? |
Maybe, but those should be separate PRs. One PR per cluster that needs this. |
c3e15ec
to
5d5da78
Compare
PR #16375: Size comparison from 2e658fb to 5d5da78 Full report (11 builds for cyw30739, linux, mbed, nrfconnect, p6, telink)
|
5d5da78
to
0497197
Compare
PR #16375: Size comparison from 2e658fb to 0497197 Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
0497197
to
60431a3
Compare
PR #16375: Size comparison from d57c3b3 to 60431a3 Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
ebb5d5c
to
016709b
Compare
@bzbarsky-apple @andy31415 @dhrishi Added default value of cluster revision =4 and also max allowed value of attribute IdentifyTime is changed to 65534 (0xFFFE) in xml and regenerated all the zap files for all the applications |
PR #16375: Size comparison from 4505e87 to 016709b Increases (4 builds for efr32, linux)
Decreases (1 build for efr32)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
016709b
to
131ed40
Compare
@PSONALl Please resolve the conflicts |
131ed40
to
259969a
Compare
done |
PR #16375: Size comparison from 197f65f to 259969a Decreases (14 builds for cyw30739, efr32, esp32, linux, nrfconnect, p6, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
259969a
to
a31a3b5
Compare
PR #16375: Size comparison from 197f65f to a31a3b5 Decreases (14 builds for cyw30739, efr32, esp32, linux, nrfconnect, p6, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Problem
TE 8 Identify Cluster - Read Cluster Revision global attribute return version 2 instead of 4
Change overview
Testing
How was this tested?