Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spec] Update field ids of existing FabricIndex fields to 0xFE #16208

Merged
merged 6 commits into from
Mar 17, 2022
Merged

[spec] Update field ids of existing FabricIndex fields to 0xFE #16208

merged 6 commits into from
Mar 17, 2022

Conversation

erjiaqing
Copy link
Contributor

@erjiaqing erjiaqing commented Mar 15, 2022 •
edited
Loading

Problem

Change FabricIndex field ids to 0xFE as needed

Fixes #15835

Fixes #15835

Change overview

Change field id
Run Codegen

Testing

Build should pass

@github-actions
Copy link

github-actions bot commented Mar 15, 2022 •
edited
Loading

PR #16208: Size comparison from b18b03a to 4443dd6

Increases (2 builds for k32w)
platform target config section b18b03a 4443dd6 change % change
k32w light k32w061+release (read/write) 699340 699356 16 0.0
.text 614092 614108 16 0.0
lock k32w061+release (read/write) 699644 699660 16 0.0
.text 614384 614400 16 0.0
Full report (3 builds for k32w, mbed)
platform target config section b18b03a 4443dd6 change % change
k32w light k32w061+release (read/write) 699340 699356 16 0.0
.bss 77560 77560 0 0.0
.data 1888 1888 0 0.0
.text 614092 614108 16 0.0
lock k32w061+release (read/write) 699644 699660 16 0.0
.bss 77552 77552 0 0.0
.data 1908 1908 0 0.0
.text 614384 614400 16 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352756 2352756 0 0.0
.bss 186652 186652 0 0.0
.data 5752 5752 0 0.0
.text 1315356 1315356 0 0.0

@github-actions
Copy link

PR #16208: Size comparison from b18b03a to 2e17e93

Increases (10 builds for cyw30739, k32w, linux, nrfconnect, p6, telink)
platform target config section b18b03a 2e17e93 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602586 8 0.0
.app_xip_area 509756 509764 8 0.0
lock cyw930739m2evb_01 (read/write) 560430 560446 16 0.0
.app_xip_area 469136 469152 16 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 570506 8 0.0
.app_xip_area 469556 469564 8 0.0
k32w light k32w061+release (read/write) 699340 699356 16 0.0
.text 614092 614108 16 0.0
lock k32w061+release (read/write) 699644 699660 16 0.0
.text 614384 614400 16 0.0
linux chip-tool-ipv6only arm64 .text 8186052 8186132 80 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154027 16 0.0
text 786976 787004 28 0.0
p6 all-clusters-app default (read/write) 2492152 2492184 32 0.0
.text 1450416 1450448 32 0.0
lock-app default (read/write) 2359544 2359560 16 0.0
.text 1317808 1317824 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 893794 24 0.0
text 631868 631930 62 0.0
Decreases (2 builds for linux)
platform target config section b18b03a 2e17e93 change % change
linux chip-tool-ipv6only arm64 .rodata 492196 492116 -80 -0.0
thermostat-no-ble arm64 (read only) 2207236 2207180 -56 -0.0
.rodata 136756 136716 -40 -0.0
.text 1851168 1851152 -16 -0.0
Full report (13 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b18b03a 2e17e93 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602586 8 0.0
.app_xip_area 509756 509764 8 0.0
.bss 75576 75576 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560430 560446 16 0.0
.app_xip_area 469136 469152 16 0.0
.bss 74080 74080 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 570506 8 0.0
.app_xip_area 469556 469564 8 0.0
.bss 83384 83384 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 699340 699356 16 0.0
.bss 77560 77560 0 0.0
.data 1888 1888 0 0.0
.text 614092 614108 16 0.0
lock k32w061+release (read/write) 699644 699660 16 0.0
.bss 77552 77552 0 0.0
.data 1908 1908 0 0.0
.text 614384 614400 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9728092 9728092 0 0.0
(read/write) 475425 475425 0 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371232 0 0.0
.dynamic 560 560 0 0.0
.got 55256 55256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492196 492116 -80 -0.0
.text 8186052 8186132 80 0.0
thermostat-no-ble arm64 (read only) 2207236 2207180 -56 -0.0
(read/write) 149377 149377 0 0.0
.bss 65649 65649 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136756 136716 -40 -0.0
.text 1851168 1851152 -16 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352756 2352756 0 0.0
.bss 186652 186652 0 0.0
.data 5752 5752 0 0.0
.text 1315356 1315356 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154027 16 0.0
bss 146644 146644 0 0.0
rodata 145276 145276 0 0.0
text 786976 787004 28 0.0
p6 all-clusters-app default (read/write) 2492152 2492184 32 0.0
.bss 120080 120080 0 0.0
.data 2632 2632 0 0.0
.text 1450416 1450448 32 0.0
light-app default (read/write) 2396000 2396000 0 0.0
.bss 113544 113544 0 0.0
.data 2488 2488 0 0.0
.text 1354264 1354264 0 0.0
lock-app default (read/write) 2359544 2359560 16 0.0
.bss 113288 113288 0 0.0
.data 2448 2448 0 0.0
.text 1317808 1317824 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 893794 24 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 631868 631930 62 0.0

@github-actions
Copy link

github-actions bot commented Mar 15, 2022 •
edited
Loading

PR #16208: Size comparison from b18b03a to 170d147

Increases (14 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section b18b03a 170d147 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602586 8 0.0
.app_xip_area 509756 509764 8 0.0
lock cyw930739m2evb_01 (read/write) 560430 560446 16 0.0
.app_xip_area 469136 469152 16 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 570506 8 0.0
.app_xip_area 469556 469564 8 0.0
efr32 lighting-app BRD4161A (read only) 919652 919668 16 0.0
.text 919644 919660 16 0.0
BRD4161A+rpc (read only) 948440 948456 16 0.0
.text 948432 948448 16 0.0
window-app BRD4161A (read only) 850392 850408 16 0.0
.text 850384 850400 16 0.0
esp32 all-clusters-app m5stack (read only) 1017011 1017015 4 0.0
.flash.text 1011627 1011631 4 0.0
k32w light k32w061+release (read/write) 699340 699356 16 0.0
.text 614092 614108 16 0.0
lock k32w061+release (read/write) 699644 699660 16 0.0
.text 614384 614400 16 0.0
linux chip-tool-ipv6only arm64 .text 8186052 8186132 80 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154027 16 0.0
text 786976 787004 28 0.0
p6 all-clusters-app default (read/write) 2492152 2492184 32 0.0
.text 1450416 1450448 32 0.0
lock-app default (read/write) 2359544 2359560 16 0.0
.text 1317808 1317824 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 893794 24 0.0
text 631868 631930 62 0.0
Decreases (3 builds for esp32, linux)
platform target config section b18b03a 170d147 change % change
esp32 all-clusters-app c3devkit (read only) 961388 961366 -22 -0.0
.flash.text 961388 961366 -22 -0.0
linux chip-tool-ipv6only arm64 .rodata 492196 492116 -80 -0.0
thermostat-no-ble arm64 (read only) 2207236 2207180 -56 -0.0
.rodata 136756 136716 -40 -0.0
.text 1851168 1851152 -16 -0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b18b03a 170d147 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602586 8 0.0
.app_xip_area 509756 509764 8 0.0
.bss 75576 75576 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560430 560446 16 0.0
.app_xip_area 469136 469152 16 0.0
.bss 74080 74080 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 570506 8 0.0
.app_xip_area 469556 469564 8 0.0
.bss 83384 83384 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919652 919668 16 0.0
(read/write) 128672 128672 0 0.0
.bss 126664 126664 0 0.0
.data 2008 2008 0 0.0
.text 919644 919660 16 0.0
BRD4161A+rpc (read only) 948440 948456 16 0.0
(read/write) 144632 144632 0 0.0
.bss 142440 142440 0 0.0
.data 2188 2188 0 0.0
.text 948432 948448 16 0.0
window-app BRD4161A (read only) 850392 850408 16 0.0
(read/write) 126632 126632 0 0.0
.bss 124768 124768 0 0.0
.data 1864 1864 0 0.0
.text 850384 850400 16 0.0
esp32 all-clusters-app c3devkit (read only) 961388 961366 -22 -0.0
(read/write) 1394938 1394938 0 0.0
.dram0.bss 64056 64056 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197776 197776 0 0.0
.flash.text 961388 961366 -22 -0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017011 1017015 4 0.0
(read/write) 462148 462148 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226720 226720 0 0.0
.flash.text 1011627 1011631 4 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699340 699356 16 0.0
.bss 77560 77560 0 0.0
.data 1888 1888 0 0.0
.text 614092 614108 16 0.0
lock k32w061+release (read/write) 699644 699660 16 0.0
.bss 77552 77552 0 0.0
.data 1908 1908 0 0.0
.text 614384 614400 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9728092 9728092 0 0.0
(read/write) 475425 475425 0 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371232 0 0.0
.dynamic 560 560 0 0.0
.got 55256 55256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492196 492116 -80 -0.0
.text 8186052 8186132 80 0.0
thermostat-no-ble arm64 (read only) 2207236 2207180 -56 -0.0
(read/write) 149377 149377 0 0.0
.bss 65649 65649 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136756 136716 -40 -0.0
.text 1851168 1851152 -16 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352756 2352756 0 0.0
.bss 186652 186652 0 0.0
.data 5752 5752 0 0.0
.text 1315356 1315356 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154027 16 0.0
bss 146644 146644 0 0.0
rodata 145276 145276 0 0.0
text 786976 787004 28 0.0
p6 all-clusters-app default (read/write) 2492152 2492184 32 0.0
.bss 120080 120080 0 0.0
.data 2632 2632 0 0.0
.text 1450416 1450448 32 0.0
light-app default (read/write) 2396000 2396000 0 0.0
.bss 113544 113544 0 0.0
.data 2488 2488 0 0.0
.text 1354264 1354264 0 0.0
lock-app default (read/write) 2359544 2359560 16 0.0
.bss 113288 113288 0 0.0
.data 2448 2448 0 0.0
.text 1317808 1317824 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 893794 24 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 631868 631930 62 0.0

@github-actions
Copy link

github-actions bot commented Mar 15, 2022 •
edited
Loading

PR #16208: Size comparison from b18b03a to f5bb0a3

Increases (14 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section b18b03a f5bb0a3 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602586 8 0.0
.app_xip_area 509756 509764 8 0.0
lock cyw930739m2evb_01 (read/write) 560430 560446 16 0.0
.app_xip_area 469136 469152 16 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 570506 8 0.0
.app_xip_area 469556 469564 8 0.0
efr32 lighting-app BRD4161A (read only) 919652 919668 16 0.0
.text 919644 919660 16 0.0
BRD4161A+rpc (read only) 948440 948456 16 0.0
.text 948432 948448 16 0.0
window-app BRD4161A (read only) 850392 850408 16 0.0
.text 850384 850400 16 0.0
esp32 all-clusters-app m5stack (read only) 1017011 1017015 4 0.0
.flash.text 1011627 1011631 4 0.0
k32w light k32w061+release (read/write) 699340 699356 16 0.0
.text 614092 614108 16 0.0
lock k32w061+release (read/write) 699644 699660 16 0.0
.text 614384 614400 16 0.0
linux chip-tool-ipv6only arm64 .text 8186052 8186132 80 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154027 16 0.0
text 786976 787004 28 0.0
p6 all-clusters-app default (read/write) 2492152 2492184 32 0.0
.text 1450416 1450448 32 0.0
lock-app default (read/write) 2359544 2359560 16 0.0
.text 1317808 1317824 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 893794 24 0.0
text 631868 631930 62 0.0
Decreases (3 builds for esp32, linux)
platform target config section b18b03a f5bb0a3 change % change
esp32 all-clusters-app c3devkit (read only) 961388 961366 -22 -0.0
.flash.text 961388 961366 -22 -0.0
linux chip-tool-ipv6only arm64 .rodata 492196 492116 -80 -0.0
thermostat-no-ble arm64 (read only) 2207236 2207180 -56 -0.0
.rodata 136756 136716 -40 -0.0
.text 1851168 1851152 -16 -0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b18b03a f5bb0a3 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602586 8 0.0
.app_xip_area 509756 509764 8 0.0
.bss 75576 75576 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560430 560446 16 0.0
.app_xip_area 469136 469152 16 0.0
.bss 74080 74080 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 570506 8 0.0
.app_xip_area 469556 469564 8 0.0
.bss 83384 83384 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919652 919668 16 0.0
(read/write) 128672 128672 0 0.0
.bss 126664 126664 0 0.0
.data 2008 2008 0 0.0
.text 919644 919660 16 0.0
BRD4161A+rpc (read only) 948440 948456 16 0.0
(read/write) 144632 144632 0 0.0
.bss 142440 142440 0 0.0
.data 2188 2188 0 0.0
.text 948432 948448 16 0.0
window-app BRD4161A (read only) 850392 850408 16 0.0
(read/write) 126632 126632 0 0.0
.bss 124768 124768 0 0.0
.data 1864 1864 0 0.0
.text 850384 850400 16 0.0
esp32 all-clusters-app c3devkit (read only) 961388 961366 -22 -0.0
(read/write) 1394938 1394938 0 0.0
.dram0.bss 64056 64056 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197776 197776 0 0.0
.flash.text 961388 961366 -22 -0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017011 1017015 4 0.0
(read/write) 462148 462148 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226720 226720 0 0.0
.flash.text 1011627 1011631 4 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699340 699356 16 0.0
.bss 77560 77560 0 0.0
.data 1888 1888 0 0.0
.text 614092 614108 16 0.0
lock k32w061+release (read/write) 699644 699660 16 0.0
.bss 77552 77552 0 0.0
.data 1908 1908 0 0.0
.text 614384 614400 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9728092 9728092 0 0.0
(read/write) 475425 475425 0 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371232 0 0.0
.dynamic 560 560 0 0.0
.got 55256 55256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492196 492116 -80 -0.0
.text 8186052 8186132 80 0.0
thermostat-no-ble arm64 (read only) 2207236 2207180 -56 -0.0
(read/write) 149377 149377 0 0.0
.bss 65649 65649 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136756 136716 -40 -0.0
.text 1851168 1851152 -16 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352756 2352756 0 0.0
.bss 186652 186652 0 0.0
.data 5752 5752 0 0.0
.text 1315356 1315356 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154027 16 0.0
bss 146644 146644 0 0.0
rodata 145276 145276 0 0.0
text 786976 787004 28 0.0
p6 all-clusters-app default (read/write) 2492152 2492184 32 0.0
.bss 120080 120080 0 0.0
.data 2632 2632 0 0.0
.text 1450416 1450448 32 0.0
light-app default (read/write) 2396000 2396000 0 0.0
.bss 113544 113544 0 0.0
.data 2488 2488 0 0.0
.text 1354264 1354264 0 0.0
lock-app default (read/write) 2359544 2359560 16 0.0
.bss 113288 113288 0 0.0
.data 2448 2448 0 0.0
.text 1317808 1317824 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 893794 24 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 631868 631930 62 0.0

@github-actions
Copy link

github-actions bot commented Mar 16, 2022 •
edited
Loading

PR #16208: Size comparison from 046100b to 0eb2f2c

Increases (13 builds for cyw30739, efr32, k32w, linux, nrfconnect, p6, telink)
platform target config section 046100b 0eb2f2c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602866 602874 8 0.0
.app_xip_area 509948 509956 8 0.0
lock cyw930739m2evb_01 (read/write) 560654 560670 16 0.0
.app_xip_area 469264 469280 16 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570530 570538 8 0.0
.app_xip_area 469492 469500 8 0.0
efr32 lighting-app BRD4161A+rpc (read only) 948872 948888 16 0.0
.text 948864 948880 16 0.0
window-app BRD4161A (read only) 850816 850832 16 0.0
.text 850808 850824 16 0.0
k32w light k32w061+release (read/write) 699568 699584 16 0.0
.text 614240 614256 16 0.0
lock k32w061+release (read/write) 699872 699888 16 0.0
.text 614532 614548 16 0.0
linux chip-tool-ipv6only arm64 .text 8211444 8211524 80 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154267 1154283 16 0.0
text 787028 787052 24 0.0
p6 all-clusters-app default (read/write) 2492256 2492288 32 0.0
.text 1450520 1450552 32 0.0
light-app default (read/write) 2396104 2396120 16 0.0
.text 1354368 1354384 16 0.0
lock-app default (read/write) 2359648 2359664 16 0.0
.text 1317912 1317928 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 894098 894114 16 0.0
text 632098 632160 62 0.0
Decreases (4 builds for esp32, linux)
platform target config section 046100b 0eb2f2c change % change
esp32 all-clusters-app c3devkit (read only) 961626 961604 -22 -0.0
.flash.text 961626 961604 -22 -0.0
m5stack (read only) 1017135 1017123 -12 -0.0
.flash.text 1011751 1011739 -12 -0.0
linux chip-tool-ipv6only arm64 .rodata 492348 492268 -80 -0.0
thermostat-no-ble arm64 (read only) 2207772 2207716 -56 -0.0
.rodata 136908 136868 -40 -0.0
.text 1851552 1851536 -16 -0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 046100b 0eb2f2c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602866 602874 8 0.0
.app_xip_area 509948 509956 8 0.0
.bss 75672 75672 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560654 560670 16 0.0
.app_xip_area 469264 469280 16 0.0
.bss 74176 74176 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570530 570538 8 0.0
.app_xip_area 469492 469500 8 0.0
.bss 83480 83480 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920068 920068 0 0.0
(read/write) 128768 128768 0 0.0
.bss 126760 126760 0 0.0
.data 2008 2008 0 0.0
.text 920060 920060 0 0.0
BRD4161A+rpc (read only) 948872 948888 16 0.0
(read/write) 144728 144728 0 0.0
.bss 142536 142536 0 0.0
.data 2188 2188 0 0.0
.text 948864 948880 16 0.0
window-app BRD4161A (read only) 850816 850832 16 0.0
(read/write) 126728 126728 0 0.0
.bss 124864 124864 0 0.0
.data 1864 1864 0 0.0
.text 850808 850824 16 0.0
esp32 all-clusters-app c3devkit (read only) 961626 961604 -22 -0.0
(read/write) 1395066 1395066 0 0.0
.dram0.bss 64064 64064 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197904 197904 0 0.0
.flash.text 961626 961604 -22 -0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017135 1017123 -12 -0.0
(read/write) 462284 462284 0 0.0
.dram0.bss 69592 69592 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226840 226840 0 0.0
.flash.text 1011751 1011739 -12 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699568 699584 16 0.0
.bss 77640 77640 0 0.0
.data 1888 1888 0 0.0
.text 614240 614256 16 0.0
lock k32w061+release (read/write) 699872 699888 16 0.0
.bss 77632 77632 0 0.0
.data 1908 1908 0 0.0
.text 614532 614548 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9753668 9753668 0 0.0
(read/write) 475441 475441 0 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371232 0 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492348 492268 -80 -0.0
.text 8211444 8211524 80 0.0
thermostat-no-ble arm64 (read only) 2207772 2207716 -56 -0.0
(read/write) 149409 149409 0 0.0
.bss 65681 65681 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136908 136868 -40 -0.0
.text 1851552 1851536 -16 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352908 2352908 0 0.0
.bss 186660 186660 0 0.0
.data 5752 5752 0 0.0
.text 1315508 1315508 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154267 1154283 16 0.0
bss 146740 146740 0 0.0
rodata 145356 145356 0 0.0
text 787028 787052 24 0.0
p6 all-clusters-app default (read/write) 2492256 2492288 32 0.0
.bss 120088 120088 0 0.0
.data 2632 2632 0 0.0
.text 1450520 1450552 32 0.0
light-app default (read/write) 2396104 2396120 16 0.0
.bss 113552 113552 0 0.0
.data 2488 2488 0 0.0
.text 1354368 1354384 16 0.0
lock-app default (read/write) 2359648 2359664 16 0.0
.bss 113296 113296 0 0.0
.data 2448 2448 0 0.0
.text 1317912 1317928 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 894098 894114 16 0.0
bss 87448 87448 0 0.0
noinit 37160 37160 0 0.0
text 632098 632160 62 0.0

@github-actions
Copy link

github-actions bot commented Mar 16, 2022 •
edited
Loading

PR #16208: Size comparison from 046100b to 10322ca

Increases (15 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 046100b 10322ca change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602866 602874 8 0.0
.app_xip_area 509948 509956 8 0.0
lock cyw930739m2evb_01 (read/write) 560654 560670 16 0.0
.app_xip_area 469264 469280 16 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570530 570538 8 0.0
.app_xip_area 469492 469500 8 0.0
efr32 lighting-app BRD4161A (read only) 920068 920084 16 0.0
.text 920060 920076 16 0.0
BRD4161A+rpc (read only) 948872 948888 16 0.0
.text 948864 948880 16 0.0
window-app BRD4161A (read only) 850816 850832 16 0.0
.text 850808 850824 16 0.0
esp32 all-clusters-app c3devkit (read only) 961626 961644 18 0.0
.flash.text 961626 961644 18 0.0
m5stack (read only) 1017135 1017139 4 0.0
.flash.text 1011751 1011755 4 0.0
k32w lock k32w061+release (read/write) 699872 699888 16 0.0
.text 614532 614548 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9753668 9754204 536 0.0
(read/write) 475441 475457 16 0.0
.data.rel.ro 371232 371256 24 0.0
.text 8211444 8212116 672 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154267 1154331 64 0.0
text 787028 787088 60 0.0
p6 all-clusters-app default (read/write) 2492256 2492368 112 0.0
.text 1450520 1450632 112 0.0
light-app default (read/write) 2396104 2396136 32 0.0
.text 1354368 1354400 32 0.0
lock-app default (read/write) 2359648 2359664 16 0.0
.text 1317912 1317928 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 894098 894114 16 0.0
text 632098 632160 62 0.0
Decreases (2 builds for linux)
platform target config section 046100b 10322ca change % change
linux chip-tool-ipv6only arm64 .rodata 492348 492196 -152 -0.0
thermostat-no-ble arm64 (read only) 2207772 2207716 -56 -0.0
.rodata 136908 136868 -40 -0.0
.text 1851552 1851536 -16 -0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 046100b 10322ca change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602866 602874 8 0.0
.app_xip_area 509948 509956 8 0.0
.bss 75672 75672 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560654 560670 16 0.0
.app_xip_area 469264 469280 16 0.0
.bss 74176 74176 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570530 570538 8 0.0
.app_xip_area 469492 469500 8 0.0
.bss 83480 83480 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920068 920084 16 0.0
(read/write) 128768 128768 0 0.0
.bss 126760 126760 0 0.0
.data 2008 2008 0 0.0
.text 920060 920076 16 0.0
BRD4161A+rpc (read only) 948872 948888 16 0.0
(read/write) 144728 144728 0 0.0
.bss 142536 142536 0 0.0
.data 2188 2188 0 0.0
.text 948864 948880 16 0.0
window-app BRD4161A (read only) 850816 850832 16 0.0
(read/write) 126728 126728 0 0.0
.bss 124864 124864 0 0.0
.data 1864 1864 0 0.0
.text 850808 850824 16 0.0
esp32 all-clusters-app c3devkit (read only) 961626 961644 18 0.0
(read/write) 1395066 1395066 0 0.0
.dram0.bss 64064 64064 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197904 197904 0 0.0
.flash.text 961626 961644 18 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017135 1017139 4 0.0
(read/write) 462284 462284 0 0.0
.dram0.bss 69592 69592 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226840 226840 0 0.0
.flash.text 1011751 1011755 4 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699568 699568 0 0.0
.bss 77640 77640 0 0.0
.data 1888 1888 0 0.0
.text 614240 614240 0 0.0
lock k32w061+release (read/write) 699872 699888 16 0.0
.bss 77632 77632 0 0.0
.data 1908 1908 0 0.0
.text 614532 614548 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9753668 9754204 536 0.0
(read/write) 475441 475457 16 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371256 24 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492348 492196 -152 -0.0
.text 8211444 8212116 672 0.0
thermostat-no-ble arm64 (read only) 2207772 2207716 -56 -0.0
(read/write) 149409 149409 0 0.0
.bss 65681 65681 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136908 136868 -40 -0.0
.text 1851552 1851536 -16 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352908 2352908 0 0.0
.bss 186660 186660 0 0.0
.data 5752 5752 0 0.0
.text 1315508 1315508 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154267 1154331 64 0.0
bss 146740 146740 0 0.0
rodata 145356 145356 0 0.0
text 787028 787088 60 0.0
p6 all-clusters-app default (read/write) 2492256 2492368 112 0.0
.bss 120088 120088 0 0.0
.data 2632 2632 0 0.0
.text 1450520 1450632 112 0.0
light-app default (read/write) 2396104 2396136 32 0.0
.bss 113552 113552 0 0.0
.data 2488 2488 0 0.0
.text 1354368 1354400 32 0.0
lock-app default (read/write) 2359648 2359664 16 0.0
.bss 113296 113296 0 0.0
.data 2448 2448 0 0.0
.text 1317912 1317928 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 894098 894114 16 0.0
bss 87448 87448 0 0.0
noinit 37160 37160 0 0.0
text 632098 632160 62 0.0

@erjiaqing erjiaqing merged commit cd08938 into project-chip:master Mar 17, 2022
@erjiaqing erjiaqing deleted the im/issue15835 branch March 17, 2022 05:31
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@erjiaqing @andrei-menzopol
[spec] Update field ids of existing FabricIndex fields to 0xFE (proje…
719718e 
…ct-chip#16208)

* [spec] Update field ids of existing FabricIndex fields to 0xFE

* Run Codegen

* Misc: Adjust field order

* Fix missing structs

* Run Codegen

* Fix Code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change FabricIndex field ids to 0xFE as needed
3 participants
@erjiaqing @msandstedt @bzbarsky-apple