Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change FabricIndex field ids to 0xFE as needed #15835

Closed
bzbarsky-apple opened this issue Mar 4, 2022 · 1 comment · Fixed by #16208
Closed

Change FabricIndex field ids to 0xFE as needed #15835

bzbarsky-apple opened this issue Mar 4, 2022 · 1 comment · Fixed by #16208
Assignees
@erjiaqing
Labels
app-clusters Application cluster work feature work Interaction Model Work spec Mismatch between spec and implementation utility-cluster Work for Utility Clusters V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

The global FabricIndex bits landed in the spec, with 0xFE as field id.

Proposed Solution

We need to change to that in our implementation. The simplest way to do that is to just set the field id in our XML to 0xFE for the relevant fields.
@bzbarsky-apple
Copy link
Contributor Author

@mrjerryjohns @tcarmelveilleux

@bzbarsky-apple bzbarsky-apple mentioned this issue Mar 4, 2022
Closed
@bzbarsky-apple bzbarsky-apple added app-clusters Application cluster work utility-cluster Work for Utility Clusters V1.0 spec Mismatch between spec and implementation labels Mar 4, 2022
@bzbarsky-apple bzbarsky-apple mentioned this issue Mar 4, 2022
Merged
@erjiaqing erjiaqing mentioned this issue Mar 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erjiaqing erjiaqing

Labels
app-clusters Application cluster work feature work Interaction Model Work spec Mismatch between spec and implementation utility-cluster Work for Utility Clusters V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[spec] Update field ids of existing FabricIndex fields to 0xFE erjiaqing/connectedhomeip
3 participants
@erjiaqing @mrjerryjohns @bzbarsky-apple