Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PersistentStorageDelegate 0-storage behavior #16139

Merged
merged 7 commits into from
Mar 14, 2022
Merged

Fix PersistentStorageDelegate 0-storage behavior #16139

merged 7 commits into from
Mar 14, 2022

Conversation

tcarmelveilleux
Copy link
Contributor

Problem

PersistentStorageDelegate's backends do not deal with
nullptr input yet in SDK. This can be addressed with pre-checks
in the default PersistentStorageDelegate implementations
in the short term.

Issue #16130

Change overview

  • Make Server's PersistentStorageDelegate and
    TestPersistentStorage delegate properly handle nullptr
    input for zero-length.
  • Document behavior expected of PersistentStorageDelegate interface

Testing

  • Unit tests still pass
  • Cert tests still pass

@tcarmelveilleux
Fix PersistentStorageDelegate 0-storage behavior
fe14524 
- Make Server's PersistentStorageDelegate and
  TestPersistentStorage delegate properly handle nullptr
  input for zero-length.
- Document behavior expected of PersistentStorageDelegate interface

Issue project-chip#16130
@github-actions
Copy link

github-actions bot commented Mar 11, 2022 •
edited
Loading

PR #16139: Size comparison from 31037c1 to fe14524

Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 31037c1 fe14524 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599102 599158 56 0.0
.app_xip_area 506700 506756 56 0.0
lock cyw930739m2evb_01 (read/write) 556986 557042 56 0.0
.app_xip_area 466112 466168 56 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566766 566822 56 0.0
.app_xip_area 466228 466284 56 0.0
efr32 lighting-app BRD4161A (read only) 921128 921144 16 0.0
.text 921120 921136 16 0.0
BRD4161A+rpc (read only) 949940 949972 32 0.0
.text 949932 949964 32 0.0
window-app BRD4161A (read only) 853732 853764 32 0.0
.text 853724 853756 32 0.0
esp32 all-clusters-app c3devkit (read only) 958524 958550 26 0.0
.flash.text 958524 958550 26 0.0
m5stack (read only) 1014127 1014143 16 0.0
.flash.text 1008743 1008759 16 0.0
k32w light k32w061+release (read/write) 695388 695420 32 0.0
.text 610548 610580 32 0.0
lock k32w061+release (read/write) 696360 696392 32 0.0
.text 611528 611560 32 0.0
linux all-clusters-app debug (read only) 2436881 2436945 64 0.0
.text 2067730 2067794 64 0.0
bridge-app debug+rpc (read only) 1742165 1742213 48 0.0
.text 1483893 1483941 48 0.0
chip-tool debug (read only) 10096133 10096389 256 0.0
.text 8799365 8799621 256 0.0
chip-tool-ipv6only arm64 (read only) 9729660 9729820 160 0.0
.text 8186868 8187028 160 0.0
door-lock-app debug (read only) 1956545 1956609 64 0.0
.text 1633618 1633682 64 0.0
lighting-app debug+rpc (read only) 2088681 2088745 64 0.0
.text 1766578 1766642 64 0.0
ota-provider-app debug (read only) 1889961 1890009 48 0.0
.text 1579746 1579794 48 0.0
ota-requestor-app debug (read only) 1917593 1917657 64 0.0
.text 1611266 1611330 64 0.0
shell debug (read only) 2402881 2403201 320 0.0
.text 2040194 2040514 320 0.0
thermostat-no-ble arm64 (read only) 2181588 2181668 80 0.0
.text 1829984 1830064 80 0.0
tv-app debug (read only) 2628553 2628617 64 0.0
.text 2254706 2254770 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152643 1152659 16 0.0
text 786676 786700 24 0.0
p6 all-clusters-app default (read/write) 2495680 2495696 16 0.0
.text 1453944 1453960 16 0.0
light-app default (read/write) 2399680 2399712 32 0.0
.text 1357944 1357976 32 0.0
lock-app default (read/write) 2363240 2363272 32 0.0
.text 1321504 1321536 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 889766 889790 24 0.0
text 628970 628996 26 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 31037c1 fe14524 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599102 599158 56 0.0
.app_xip_area 506700 506756 56 0.0
.bss 75108 75108 0 0.0
.data 640 640 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556986 557042 56 0.0
.app_xip_area 466112 466168 56 0.0
.bss 73612 73612 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566766 566822 56 0.0
.app_xip_area 466228 466284 56 0.0
.bss 82932 82932 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921128 921144 16 0.0
(read/write) 128232 128232 0 0.0
.bss 126176 126176 0 0.0
.data 2052 2052 0 0.0
.text 921120 921136 16 0.0
BRD4161A+rpc (read only) 949940 949972 32 0.0
(read/write) 144184 144184 0 0.0
.bss 141952 141952 0 0.0
.data 2232 2232 0 0.0
.text 949932 949964 32 0.0
window-app BRD4161A (read only) 853732 853764 32 0.0
(read/write) 126216 126216 0 0.0
.bss 124312 124312 0 0.0
.data 1904 1904 0 0.0
.text 853724 853756 32 0.0
esp32 all-clusters-app c3devkit (read only) 958524 958550 26 0.0
(read/write) 1393858 1393858 0 0.0
.dram0.bss 63584 63584 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197144 197144 0 0.0
.flash.text 958524 958550 26 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1014127 1014143 16 0.0
(read/write) 461092 461092 0 0.0
.dram0.bss 69104 69104 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 226104 226104 0 0.0
.flash.text 1008743 1008759 16 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 695388 695420 32 0.0
.bss 77112 77112 0 0.0
.data 1928 1928 0 0.0
.text 610548 610580 32 0.0
lock k32w061+release (read/write) 696360 696392 32 0.0
.bss 77080 77080 0 0.0
.data 1952 1952 0 0.0
.text 611528 611560 32 0.0
linux all-clusters-app debug (read only) 2436881 2436945 64 0.0
(read/write) 145840 145840 0 0.0
.bss 60352 60352 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 206213 206213 0 0.0
.text 2067730 2067794 64 0.0
bridge-app debug+rpc (read only) 1742165 1742213 48 0.0
(read/write) 92784 92784 0 0.0
.bss 47624 47624 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 38064 38064 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 142348 142348 0 0.0
.text 1483893 1483941 48 0.0
chip-tool debug (read only) 10096133 10096389 256 0.0
(read/write) 357976 357976 0 0.0
.bss 25640 25640 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 325208 325208 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514516 514516 0 0.0
.text 8799365 8799621 256 0.0
chip-tool-ipv6only arm64 (read only) 9729660 9729820 160 0.0
(read/write) 475729 475729 0 0.0
.bss 43953 43953 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 371520 371520 0 0.0
.dynamic 560 560 0 0.0
.got 55280 55280 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492148 492148 0 0.0
.text 8186868 8187028 160 0.0
door-lock-app debug (read only) 1956545 1956609 64 0.0
(read/write) 119264 119264 0 0.0
.bss 50656 50656 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 174332 174332 0 0.0
.text 1633618 1633682 64 0.0
lighting-app debug+rpc (read only) 2088681 2088745 64 0.0
(read/write) 124584 124584 0 0.0
.bss 51456 51456 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66104 66104 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 166492 166492 0 0.0
.text 1766578 1766642 64 0.0
ota-provider-app debug (read only) 1889961 1890009 48 0.0
(read/write) 114896 114896 0 0.0
.bss 50496 50496 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 159539 159539 0 0.0
.text 1579746 1579794 48 0.0
ota-requestor-app debug (read only) 1917593 1917657 64 0.0
(read/write) 117960 117960 0 0.0
.bss 51552 51552 0 0.0
.data 1448 1448 0 0.0
.data.rel.ro 59512 59512 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 155500 155500 0 0.0
.text 1611266 1611330 64 0.0
shell debug (read only) 2402881 2403201 320 0.0
(read/write) 150088 150088 0 0.0
.bss 70472 70472 0 0.0
.data 848 848 0 0.0
.data.rel.ro 73064 73064 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 206162 206162 0 0.0
.text 2040194 2040514 320 0.0
thermostat-no-ble arm64 (read only) 2181588 2181668 80 0.0
(read/write) 148625 148625 0 0.0
.bss 65409 65409 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 74968 74968 0 0.0
.dynamic 560 560 0 0.0
.got 4256 4256 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133444 133444 0 0.0
.text 1829984 1830064 80 0.0
tv-app debug (read only) 2628553 2628617 64 0.0
(read/write) 250360 250360 0 0.0
.bss 167520 167520 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199805 199805 0 0.0
.text 2254706 2254770 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351012 2351012 0 0.0
.bss 186212 186212 0 0.0
.data 5784 5784 0 0.0
.text 1313612 1313612 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152643 1152659 16 0.0
bss 146188 146188 0 0.0
rodata 144516 144516 0 0.0
text 786676 786700 24 0.0
p6 all-clusters-app default (read/write) 2495680 2495696 16 0.0
.bss 119640 119640 0 0.0
.data 2672 2672 0 0.0
.text 1453944 1453960 16 0.0
light-app default (read/write) 2399680 2399712 32 0.0
.bss 113104 113104 0 0.0
.data 2528 2528 0 0.0
.text 1357944 1357976 32 0.0
lock-app default (read/write) 2363240 2363272 32 0.0
.bss 112848 112848 0 0.0
.data 2488 2488 0 0.0
.text 1321504 1321536 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 889766 889790 24 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 628970 628996 26 0.0

@github-actions
Copy link

github-actions bot commented Mar 11, 2022 •
edited
Loading

PR #16139: Size comparison from 31037c1 to a3ceb5a

Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 31037c1 a3ceb5a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599102 599198 96 0.0
.app_xip_area 506700 506796 96 0.0
lock cyw930739m2evb_01 (read/write) 556986 557074 88 0.0
.app_xip_area 466112 466200 88 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566766 566862 96 0.0
.app_xip_area 466228 466324 96 0.0
efr32 lighting-app BRD4161A (read only) 921128 921192 64 0.0
.text 921120 921184 64 0.0
BRD4161A+rpc (read only) 949940 950020 80 0.0
.text 949932 950012 80 0.0
window-app BRD4161A (read only) 853732 853796 64 0.0
.text 853724 853788 64 0.0
esp32 all-clusters-app c3devkit (read only) 958524 958576 52 0.0
.flash.text 958524 958576 52 0.0
m5stack (read only) 1014127 1014167 40 0.0
.flash.text 1008743 1008783 40 0.0
k32w light k32w061+release (read/write) 695388 695436 48 0.0
.text 610548 610596 48 0.0
lock k32w061+release (read/write) 696360 696408 48 0.0
.text 611528 611576 48 0.0
linux all-clusters-app debug (read only) 2436881 2437057 176 0.0
.text 2067730 2067906 176 0.0
bridge-app debug+rpc (read only) 1742165 1742341 176 0.0
.text 1483893 1484069 176 0.0
chip-tool debug (read only) 10096133 10096469 336 0.0
.text 8799365 8799701 336 0.0
chip-tool-ipv6only arm64 (read only) 9729660 9729868 208 0.0
.text 8186868 8187076 208 0.0
door-lock-app debug (read only) 1956545 1956721 176 0.0
.text 1633618 1633794 176 0.0
lighting-app debug+rpc (read only) 2088681 2088857 176 0.0
.text 1766578 1766754 176 0.0
ota-provider-app debug (read only) 1889961 1890137 176 0.0
.text 1579746 1579922 176 0.0
ota-requestor-app debug (read only) 1917593 1917769 176 0.0
.text 1611266 1611442 176 0.0
shell debug (read only) 2402881 2403345 464 0.0
.text 2040194 2040658 464 0.0
thermostat-no-ble arm64 (read only) 2181588 2181812 224 0.0
.text 1829984 1830208 224 0.0
tv-app debug (read only) 2628553 2628729 176 0.0
.text 2254706 2254882 176 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2351012 2351076 64 0.0
.text 1313612 1313676 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152643 1152691 48 0.0
text 786676 786724 48 0.0
p6 all-clusters-app default (read/write) 2495680 2495744 64 0.0
.text 1453944 1454008 64 0.0
light-app default (read/write) 2399680 2399760 80 0.0
.text 1357944 1358024 80 0.0
lock-app default (read/write) 2363240 2363304 64 0.0
.text 1321504 1321568 64 0.0
telink lighting-app tlsr9518adk80d (read/write) 889766 889814 48 0.0
text 628970 629022 52 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 31037c1 a3ceb5a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599102 599198 96 0.0
.app_xip_area 506700 506796 96 0.0
.bss 75108 75108 0 0.0
.data 640 640 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556986 557074 88 0.0
.app_xip_area 466112 466200 88 0.0
.bss 73612 73612 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566766 566862 96 0.0
.app_xip_area 466228 466324 96 0.0
.bss 82932 82932 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921128 921192 64 0.0
(read/write) 128232 128232 0 0.0
.bss 126176 126176 0 0.0
.data 2052 2052 0 0.0
.text 921120 921184 64 0.0
BRD4161A+rpc (read only) 949940 950020 80 0.0
(read/write) 144184 144184 0 0.0
.bss 141952 141952 0 0.0
.data 2232 2232 0 0.0
.text 949932 950012 80 0.0
window-app BRD4161A (read only) 853732 853796 64 0.0
(read/write) 126216 126216 0 0.0
.bss 124312 124312 0 0.0
.data 1904 1904 0 0.0
.text 853724 853788 64 0.0
esp32 all-clusters-app c3devkit (read only) 958524 958576 52 0.0
(read/write) 1393858 1393858 0 0.0
.dram0.bss 63584 63584 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197144 197144 0 0.0
.flash.text 958524 958576 52 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1014127 1014167 40 0.0
(read/write) 461092 461092 0 0.0
.dram0.bss 69104 69104 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 226104 226104 0 0.0
.flash.text 1008743 1008783 40 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 695388 695436 48 0.0
.bss 77112 77112 0 0.0
.data 1928 1928 0 0.0
.text 610548 610596 48 0.0
lock k32w061+release (read/write) 696360 696408 48 0.0
.bss 77080 77080 0 0.0
.data 1952 1952 0 0.0
.text 611528 611576 48 0.0
linux all-clusters-app debug (read only) 2436881 2437057 176 0.0
(read/write) 145840 145840 0 0.0
.bss 60352 60352 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 206213 206213 0 0.0
.text 2067730 2067906 176 0.0
bridge-app debug+rpc (read only) 1742165 1742341 176 0.0
(read/write) 92784 92784 0 0.0
.bss 47624 47624 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 38064 38064 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 142348 142348 0 0.0
.text 1483893 1484069 176 0.0
chip-tool debug (read only) 10096133 10096469 336 0.0
(read/write) 357976 357976 0 0.0
.bss 25640 25640 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 325208 325208 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514516 514516 0 0.0
.text 8799365 8799701 336 0.0
chip-tool-ipv6only arm64 (read only) 9729660 9729868 208 0.0
(read/write) 475729 475729 0 0.0
.bss 43953 43953 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 371520 371520 0 0.0
.dynamic 560 560 0 0.0
.got 55280 55280 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492148 492148 0 0.0
.text 8186868 8187076 208 0.0
door-lock-app debug (read only) 1956545 1956721 176 0.0
(read/write) 119264 119264 0 0.0
.bss 50656 50656 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 174332 174332 0 0.0
.text 1633618 1633794 176 0.0
lighting-app debug+rpc (read only) 2088681 2088857 176 0.0
(read/write) 124584 124584 0 0.0
.bss 51456 51456 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66104 66104 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 166492 166492 0 0.0
.text 1766578 1766754 176 0.0
ota-provider-app debug (read only) 1889961 1890137 176 0.0
(read/write) 114896 114896 0 0.0
.bss 50496 50496 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 159539 159539 0 0.0
.text 1579746 1579922 176 0.0
ota-requestor-app debug (read only) 1917593 1917769 176 0.0
(read/write) 117960 117960 0 0.0
.bss 51552 51552 0 0.0
.data 1448 1448 0 0.0
.data.rel.ro 59512 59512 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 155500 155500 0 0.0
.text 1611266 1611442 176 0.0
shell debug (read only) 2402881 2403345 464 0.0
(read/write) 150088 150088 0 0.0
.bss 70472 70472 0 0.0
.data 848 848 0 0.0
.data.rel.ro 73064 73064 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 206162 206162 0 0.0
.text 2040194 2040658 464 0.0
thermostat-no-ble arm64 (read only) 2181588 2181812 224 0.0
(read/write) 148625 148625 0 0.0
.bss 65409 65409 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 74968 74968 0 0.0
.dynamic 560 560 0 0.0
.got 4256 4256 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133444 133444 0 0.0
.text 1829984 1830208 224 0.0
tv-app debug (read only) 2628553 2628729 176 0.0
(read/write) 250360 250360 0 0.0
.bss 167520 167520 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199805 199805 0 0.0
.text 2254706 2254882 176 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351012 2351076 64 0.0
.bss 186212 186212 0 0.0
.data 5784 5784 0 0.0
.text 1313612 1313676 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152643 1152691 48 0.0
bss 146188 146188 0 0.0
rodata 144516 144516 0 0.0
text 786676 786724 48 0.0
p6 all-clusters-app default (read/write) 2495680 2495744 64 0.0
.bss 119640 119640 0 0.0
.data 2672 2672 0 0.0
.text 1453944 1454008 64 0.0
light-app default (read/write) 2399680 2399760 80 0.0
.bss 113104 113104 0 0.0
.data 2528 2528 0 0.0
.text 1357944 1358024 80 0.0
lock-app default (read/write) 2363240 2363304 64 0.0
.bss 112848 112848 0 0.0
.data 2488 2488 0 0.0
.text 1321504 1321568 64 0.0
telink lighting-app tlsr9518adk80d (read/write) 889766 889814 48 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 628970 629022 52 0.0

@restyled-io restyled-io bot mentioned this pull request Mar 14, 2022
Closed
bzbarsky-apple
bzbarsky-apple approved these changes Mar 14, 2022
View reviewed changes
src/lib/core/CHIPPersistentStorageDelegate.h Outdated Show resolved Hide resolved
src/lib/core/CHIPPersistentStorageDelegate.h Outdated Show resolved Hide resolved
src/lib/core/CHIPPersistentStorageDelegate.h Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 14, 2022 •
edited
Loading

PR #16139: Size comparison from 121263f to 03e01be

Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 121263f 03e01be change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602530 602642 112 0.0
.app_xip_area 509708 509820 112 0.0
lock cyw930739m2evb_01 (read/write) 560390 560494 104 0.0
.app_xip_area 469096 469200 104 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570490 570602 112 0.0
.app_xip_area 469548 469660 112 0.0
efr32 lighting-app BRD4161A (read only) 918764 918844 80 0.0
.text 918756 918836 80 0.0
BRD4161A+rpc (read only) 947568 947648 80 0.0
.text 947560 947640 80 0.0
window-app BRD4161A (read only) 850616 850696 80 0.0
.text 850608 850688 80 0.0
esp32 all-clusters-app c3devkit (read only) 961344 961404 60 0.0
.flash.text 961344 961404 60 0.0
m5stack (read only) 1016963 1017031 68 0.0
.flash.text 1011579 1011647 68 0.0
k32w light k32w061+release (read/write) 699636 699684 48 0.0
.text 614388 614436 48 0.0
lock k32w061+release (read/write) 699884 699932 48 0.0
.text 614624 614672 48 0.0
linux all-clusters-app debug (read only) 2465073 2465393 320 0.0
.text 2090994 2091314 320 0.0
bridge-app debug+rpc (read only) 1749589 1749925 336 0.0
.text 1490581 1490917 336 0.0
chip-tool debug (read only) 10094445 10094797 352 0.0
.text 8798229 8798581 352 0.0
chip-tool-ipv6only arm64 (read only) 9727740 9727964 224 0.0
.text 8185652 8185876 224 0.0
door-lock-app debug (read only) 1984225 1984545 320 0.0
.text 1656786 1657106 320 0.0
lighting-app debug+rpc (read only) 2115785 2116121 336 0.0
.text 1788786 1789122 336 0.0
ota-provider-app debug (read only) 1917489 1917825 336 0.0
.text 1602738 1603074 336 0.0
ota-requestor-app debug (read only) 1949105 1949425 320 0.0
.text 1637442 1637762 320 0.0
shell debug (read only) 2410913 2411553 640 0.0
.text 2047138 2047778 640 0.0
thermostat-no-ble arm64 (read only) 2206980 2207316 336 0.0
.text 1850848 1851184 336 0.0
tv-app debug (read only) 2655553 2655873 320 0.0
.text 2277170 2277490 320 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352748 2352812 64 0.0
.text 1315348 1315412 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156843 1156907 64 0.0
text 789688 789744 56 0.0
p6 all-clusters-app default (read/write) 2492128 2492208 80 0.0
.text 1450392 1450472 80 0.0
light-app default (read/write) 2395992 2396056 64 0.0
.text 1354256 1354320 64 0.0
lock-app default (read/write) 2359536 2359616 80 0.0
.text 1317800 1317880 80 0.0
telink lighting-app tlsr9518adk80d (read/write) 893842 893898 56 0.0
text 631882 631942 60 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 121263f 03e01be change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602530 602642 112 0.0
.app_xip_area 509708 509820 112 0.0
.bss 75576 75576 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560390 560494 104 0.0
.app_xip_area 469096 469200 104 0.0
.bss 74080 74080 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570490 570602 112 0.0
.app_xip_area 469548 469660 112 0.0
.bss 83384 83384 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 918764 918844 80 0.0
(read/write) 128656 128656 0 0.0
.bss 126648 126648 0 0.0
.data 2008 2008 0 0.0
.text 918756 918836 80 0.0
BRD4161A+rpc (read only) 947568 947648 80 0.0
(read/write) 144616 144616 0 0.0
.bss 142424 142424 0 0.0
.data 2188 2188 0 0.0
.text 947560 947640 80 0.0
window-app BRD4161A (read only) 850616 850696 80 0.0
(read/write) 126632 126632 0 0.0
.bss 124768 124768 0 0.0
.data 1864 1864 0 0.0
.text 850608 850688 80 0.0
esp32 all-clusters-app c3devkit (read only) 961344 961404 60 0.0
(read/write) 1394994 1394994 0 0.0
.dram0.bss 64056 64056 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197832 197832 0 0.0
.flash.text 961344 961404 60 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1016963 1017031 68 0.0
(read/write) 462204 462204 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226776 226776 0 0.0
.flash.text 1011579 1011647 68 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699636 699684 48 0.0
.bss 77560 77560 0 0.0
.data 1888 1888 0 0.0
.text 614388 614436 48 0.0
lock k32w061+release (read/write) 699884 699932 48 0.0
.bss 77552 77552 0 0.0
.data 1908 1908 0 0.0
.text 614624 614672 48 0.0
linux all-clusters-app debug (read only) 2465073 2465393 320 0.0
(read/write) 146384 146384 0 0.0
.bss 60640 60640 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210757 210757 0 0.0
.text 2090994 2091314 320 0.0
bridge-app debug+rpc (read only) 1749589 1749925 336 0.0
(read/write) 92912 92912 0 0.0
.bss 47752 47752 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 38128 38128 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143372 143372 0 0.0
.text 1490581 1490917 336 0.0
chip-tool debug (read only) 10094445 10094797 352 0.0
(read/write) 357680 357680 0 0.0
.bss 25696 25696 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324864 324864 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514965 514965 0 0.0
.text 8798229 8798581 352 0.0
chip-tool-ipv6only arm64 (read only) 9727740 9727964 224 0.0
(read/write) 475425 475425 0 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371232 0 0.0
.dynamic 560 560 0 0.0
.got 55256 55256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492244 492244 0 0.0
.text 8185652 8185876 224 0.0
door-lock-app debug (read only) 1984225 1984545 320 0.0
(read/write) 119776 119776 0 0.0
.bss 50944 50944 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 178460 178460 0 0.0
.text 1656786 1657106 320 0.0
lighting-app debug+rpc (read only) 2115785 2116121 336 0.0
(read/write) 125160 125160 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66408 66408 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 171004 171004 0 0.0
.text 1788786 1789122 336 0.0
ota-provider-app debug (read only) 1917489 1917825 336 0.0
(read/write) 115536 115536 0 0.0
.bss 50816 50816 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 57816 57816 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 163691 163691 0 0.0
.text 1602738 1603074 336 0.0
ota-requestor-app debug (read only) 1949105 1949425 320 0.0
(read/write) 118568 118568 0 0.0
.bss 51840 51840 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 59880 59880 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160356 160356 0 0.0
.text 1637442 1637762 320 0.0
shell debug (read only) 2410913 2411553 640 0.0
(read/write) 150184 150184 0 0.0
.bss 70600 70600 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73088 73088 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 207538 207538 0 0.0
.text 2047138 2047778 640 0.0
thermostat-no-ble arm64 (read only) 2206980 2207316 336 0.0
(read/write) 149377 149377 0 0.0
.bss 65649 65649 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136820 136820 0 0.0
.text 1850848 1851184 336 0.0
tv-app debug (read only) 2655553 2655873 320 0.0
(read/write) 250776 250776 0 0.0
.bss 167840 167840 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 73800 73800 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 204245 204245 0 0.0
.text 2277170 2277490 320 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352748 2352812 64 0.0
.bss 186652 186652 0 0.0
.data 5752 5752 0 0.0
.text 1315348 1315412 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156843 1156907 64 0.0
bss 146644 146644 0 0.0
rodata 145364 145364 0 0.0
text 789688 789744 56 0.0
p6 all-clusters-app default (read/write) 2492128 2492208 80 0.0
.bss 120080 120080 0 0.0
.data 2632 2632 0 0.0
.text 1450392 1450472 80 0.0
light-app default (read/write) 2395992 2396056 64 0.0
.bss 113544 113544 0 0.0
.data 2488 2488 0 0.0
.text 1354256 1354320 64 0.0
lock-app default (read/write) 2359536 2359616 80 0.0
.bss 113288 113288 0 0.0
.data 2448 2448 0 0.0
.text 1317800 1317880 80 0.0
telink lighting-app tlsr9518adk80d (read/write) 893842 893898 56 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 631882 631942 60 0.0

@andy31415 andy31415 merged commit 1f0307d into project-chip:master Mar 14, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@tcarmelveilleux @restyled-commits
@bzbarsky-apple @andrei-menzopol
Fix PersistentStorageDelegate 0-storage behavior (project-chip#16139)
e3d7816 
* Fix PersistentStorageDelegate 0-storage behavior

- Make Server's PersistentStorageDelegate and
  TestPersistentStorage delegate properly handle nullptr
  input for zero-length.
- Document behavior expected of PersistentStorageDelegate interface

Issue project-chip#16130

* Add unit tests for TestPersistentStorageDelegate

* Address review comments

* Restyled by clang-format

* Apply suggestions from code review

Co-authored-by: Boris Zbarsky <[email protected]>

Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@emargolis emargolis emargolis approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tcarmelveilleux @emargolis @bzbarsky-apple @andy31415 @restyled-commits