-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to sort out storage (PersistentStorageDelegate and KVS) behavior for 0-length nullptr data #16130
Comments
- Make Server's PersistentStorageDelegate and TestPersistentStorage delegate properly handle nullptr input for zero-length. - Document behavior expected of PersistentStorageDelegate interface Issue project-chip#16130
* Fix PersistentStorageDelegate 0-storage behavior - Make Server's PersistentStorageDelegate and TestPersistentStorage delegate properly handle nullptr input for zero-length. - Document behavior expected of PersistentStorageDelegate interface Issue #16130 * Add unit tests for TestPersistentStorageDelegate * Address review comments * Restyled by clang-format * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
* Fix PersistentStorageDelegate 0-storage behavior - Make Server's PersistentStorageDelegate and TestPersistentStorage delegate properly handle nullptr input for zero-length. - Document behavior expected of PersistentStorageDelegate interface Issue project-chip#16130 * Add unit tests for TestPersistentStorageDelegate * Address review comments * Restyled by clang-format * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
It's possible that the storage audit addressed this.... |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Fixed by storage audit. |
Problem
Some of our storage backends allow storing a nullptr with 0 length; others do not. We should be consistent and either always allow it (preferred) or always disallow it. The current setup means that code can work against one backend but fail against another, reducing the value of testing we do.
Proposed Solution
PersistentStorageDelegate
what the expected behavior is.KeyValueStoreManager
what the expected behavior is.The text was updated successfully, but these errors were encountered: