[mrp] Fix #15799 - add exponential backoff. #16026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #16026: Size comparison from 8a07515 to 87de146 Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #16026: Size comparison from a8567aa to 69ece1b Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #16026: Size comparison from a8567aa to a8b4057 Increases above 0.2%:
Increases (3 builds for linux)
Decreases (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #16026: Size comparison from a8567aa to b690e72 Increases above 0.2%:
Increases (3 builds for linux)
Decreases (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple and
jelderton
|
PR #16026: Size comparison from 32e7c70 to acce9f6 Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
turon
force-pushed
the
fix/15799
branch
2 times, most recently
from
868f716 to
f47e807
Compare
|
PR #16026: Size comparison from 1456eb1 to f47e807 Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
…over saturation case.
Co-authored-by: Michael Sandstedt <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
bzbarsky-apple
approved these changes
Mar 30, 2022
|
PR #16026: Size comparison from 0d98cc2 to cd79d33 Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Mar 31, 2022
…#16026) Fix project-chip#15799 - Add exponential backoff. - Add unit test for exponential backoff calculation. - Add spec refs to backoff implementation. Implements the backoff algorithm as specified but in fixed point: ``` t = i⋅MRP_BACKOFF_BASE^max(0,n−MRP_BACKOFF_THRESHOLD) ⋅ (1.0+random(0,1)⋅MRP_BACKOFF_JITTER) Where: t = the resultant retransmission timeout for this transmission n = the transmission count of the message, starting with 0 i = the base retry interval for the Exchange (either IDLE or ACTIVE) MRP_BACKOFF_BASE | 1.6 | The base number for the exponential backoff equation. MRP_BACKOFF_JITTER | 0.25 | The scaler for random jitter in the backoff equation. MRP_BACKOFF_THRESHOLD | 1 | # of retransmissions before transition from linear to exponential backoff. ```
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…#16026) Fix project-chip#15799 - Add exponential backoff. - Add unit test for exponential backoff calculation. - Add spec refs to backoff implementation. Implements the backoff algorithm as specified but in fixed point: ``` t = i⋅MRP_BACKOFF_BASE^max(0,n−MRP_BACKOFF_THRESHOLD) ⋅ (1.0+random(0,1)⋅MRP_BACKOFF_JITTER) Where: t = the resultant retransmission timeout for this transmission n = the transmission count of the message, starting with 0 i = the base retry interval for the Exchange (either IDLE or ACTIVE) MRP_BACKOFF_BASE | 1.6 | The base number for the exponential backoff equation. MRP_BACKOFF_JITTER | 0.25 | The scaler for random jitter in the backoff equation. MRP_BACKOFF_THRESHOLD | 1 | # of retransmissions before transition from linear to exponential backoff. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fix #15799 - implement exponential backoff in MRP..
#15800 is related, but would come as a separate PR.
Change overview
Implements the backoff algorithm as specified but in fixed point:
Testing
How was this tested? (at least one bullet point required)