Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msg] [mrp] MRP_ACTIVE_TIMEOUT seems to never be used #15800

Closed
turon opened this issue Mar 3, 2022 · 0 comments · Fixed by #17003
Closed

[msg] [mrp] MRP_ACTIVE_TIMEOUT seems to never be used #15800

turon opened this issue Mar 3, 2022 · 0 comments · Fixed by #17003
Assignees
@turon
Labels
sleepy

Comments

@turon
Copy link
Contributor

turon commented Mar 3, 2022

Problem

The sdk doesn't fully implement MRP retransmission timing calculations.

Per slack discussion: https://app.slack.com/team/U01CPER8YCA
There are tickets like this that show some symptoms of this missing support:
#12680

Proposed Solution

Implement ACTIVE/IDLE behavior with pending spec updates to track peer active state per-session rather than per-exchange.
@turon turon mentioned this issue Mar 9, 2022
Merged
@turon turon changed the title [msg] [mrp] MRP_IDLE_TIMEOUT seems to never be used [msg] [mrp] MRP_ACTIVE_TIMEOUT seems to never be used Mar 30, 2022
turon added a commit to turon/connectedhomeip that referenced this issue Mar 30, 2022
@turon
[mrp] Fix project-chip#15800 - Add start of peer active tracking
ef5295b
turon added a commit to turon/connectedhomeip that referenced this issue Mar 30, 2022
@turon
[mrp] Fix project-chip#15800 - Add start of peer active tracking
fd359a8
turon added a commit to turon/connectedhomeip that referenced this issue Apr 1, 2022
@turon
[mrp] Fix project-chip#15800 - Add start of peer active tracking
df50d3a
@turon turon mentioned this issue Apr 1, 2022
Closed
turon added a commit to turon/connectedhomeip that referenced this issue Apr 4, 2022
@turon
[mrp] Fix project-chip#15800 - Add start of peer active tracking
bbf05d2
turon added a commit to turon/connectedhomeip that referenced this issue Apr 4, 2022
@turon
[mrp] Fix project-chip#15800 - Add start of peer active tracking
b828309
@turon turon mentioned this issue Apr 4, 2022
Merged
@turon turon self-assigned this Apr 4, 2022
andy31415 pushed a commit that referenced this issue Apr 11, 2022
@turon
[sleepy] Fix #15800 - track idle/active of peer and use dynamic timeo…
06c6e06 
…ut (#17003)

* [mrp] Fix #15800 - Add start of peer active tracking

* [sleepy] Add switching between active / idle based on peer tracking.

* [sleepy] Use constexpr for kMinActiveTime.

* [sleepy] Fix review comments + restyle.
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this issue Apr 14, 2022
@turon @andrei-menzopol
[sleepy] Fix project-chip#15800 - track idle/active of peer and use d…
8fe1dbd 
…ynamic timeout (project-chip#17003)

* [mrp] Fix project-chip#15800 - Add start of peer active tracking

* [sleepy] Add switching between active / idle based on peer tracking.

* [sleepy] Use constexpr for kMinActiveTime.

* [sleepy] Fix review comments + restyle.
@turon turon mentioned this issue May 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turon turon

Labels
sleepy
Projects
None yet
Milestone
No milestone
1 participant
@turon