The Linux platform KVS init should ignore multiple init calls #15963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #15963: Size comparison from 2822511 to 0dab87c Increases (11 builds for linux)
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
andy31415
reviewed
Mar 8, 2022
| @@ -53,6 +53,11 @@ CHIP_ERROR ChipLinuxStorage::Init(const char * configFile) | |||
| { | |||
| CHIP_ERROR retval = CHIP_NO_ERROR; | |||
|
|
|||
| if (mInitialized) | |||
| { | |||
| return CHIP_NO_ERROR; | |||
There was a problem hiding this comment.
Maybe add a log here that we double-initialize.
Also check if configFile matches and if they do not, then we should error out instead of saying ok.
There was a problem hiding this comment.
Good points.
There was a problem hiding this comment.
I am going to simply log an error message for now, since returning an error causes ChipLinuxAppInit() to fail, which causes all example applications to fail.
There was a problem hiding this comment.
This should have failed when different config paths are specified, since there is no guarantee they are the same.
|
PR #15963: Size comparison from 2822511 to cfd41f6 Increases (11 builds for linux)
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
carol-apple
approved these changes
Mar 8, 2022
harsha-rajendran
force-pushed
the
Custom-KVS-Init-broken-on-Linux
branch
from
cfd41f6 to
9f2e518
Compare
|
PR #15963: Size comparison from a69fde3 to 9f2e518 Increases (11 builds for linux)
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
selissia
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Linux KVS should ignore multiple calls to Init().
As an example, all Linux applications initialize the KVS (based on a custom provided path) in ChipLinuxAppInit(). Immediately following this, the KVS gets "re-initialized" in InitChipStack(), due to the change in #15741.
Ideally we will need to trace all Init() calls and ensure an application has just one such call, but that's probably a different story.
Change overview
Return from Init() safely if called again
Testing