Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kvs in linux #15741

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Fix kvs in linux #15741

merged 1 commit into from
Mar 2, 2022

Conversation

jepenven-silabs
Copy link
Contributor

@jepenven-silabs jepenven-silabs commented Mar 2, 2022 •
edited
Loading

Problem

PR #15644 fixed a silent failure in the SessionManager Init.

In short if the KVS impl isn't initialized before calling the SessionManager.Init() GroupMessageCounter wouldn't be initialized correctly.

Turns out that by adding this error check within the SessionManager Init function, it highlighted the fact that the KVS isn't initialized when running Unit test in Linux platform.

Change overview

Add KVS init in PosixConfig for Linux (same as for Darwin)

Testing

Unit test and test suite

@woody-apple woody-apple merged commit cd7fd48 into project-chip:master Mar 2, 2022
@github-actions
Copy link

github-actions bot commented Mar 2, 2022 •
edited
Loading

PR #15741: Size comparison from 7706d0c to a4f53ac

Increases above 0.2%:

platform target config section 7706d0c a4f53ac change % change
linux chip-tool debug .bss 25248 25408 160 0.6
.init_array 600 608 8 1.3
chip-tool-ipv6only arm64 .bss 43617 43745 128 0.3
.init_array 184 192 8 4.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039967 1076235 36268 3.5
bss 125828 127680 1852 1.5
rodata 135736 141636 5900 4.3
text 701156 729516 28360 4.0
Increases (9 builds for linux, nrfconnect)
platform target config section 7706d0c a4f53ac change % change
linux all-clusters-app debug (read only) 2402689 2402705 16 0.0
.rodata 204933 204965 32 0.0
bridge-app debug+rpc (read only) 1728141 1728237 96 0.0
.text 1470805 1470901 96 0.0
chip-tool debug (read only) 9008445 9008789 344 0.0
(read/write) 283328 283496 168 0.1
.bss 25248 25408 160 0.6
.init_array 600 608 8 1.3
.text 7920037 7920357 320 0.0
chip-tool-ipv6only arm64 (read only) 8762836 8763140 304 0.0
(read/write) 396977 397105 128 0.0
.bss 43617 43745 128 0.3
.got 51800 51816 16 0.0
.init_array 184 192 8 4.3
.rodata 457884 457900 16 0.0
.text 7439668 7439908 240 0.0
door-lock-app debug (read only) 1943257 1943289 32 0.0
.rodata 173564 173596 32 0.0
shell debug (read only) 2371081 2371177 96 0.0
.text 2009666 2009762 96 0.0
thermostat-no-ble arm64 .text 1818160 1818176 16 0.0
tv-app debug (read only) 2607705 2607737 32 0.0
.rodata 199069 199101 32 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039967 1076235 36268 3.5
bss 125828 127680 1852 1.5
rodata 135736 141636 5900 4.3
text 701156 729516 28360 4.0
Decreases (6 builds for linux)
platform target config section 7706d0c a4f53ac change % change
linux all-clusters-app debug .text 2035010 2034994 -16 -0.0
chip-tool-ipv6only arm64 .data.rel.ro 296592 296568 -24 -0.0
ota-provider-app debug (read only) 1875425 1875409 -16 -0.0
.text 1566082 1566066 -16 -0.0
ota-requestor-app debug (read only) 1886401 1886385 -16 -0.0
.text 1585074 1585058 -16 -0.0
shell debug (read/write) 147272 147248 -24 -0.0
.bss 67648 67624 -24 -0.0
thermostat-no-ble arm64 (read only) 2169412 2169396 -16 -0.0
(read/write) 148641 148625 -16 -0.0
.data.rel.ro 75056 75032 -24 -0.0
Full report (28 builds for cyw30739, efr32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 7706d0c a4f53ac change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600590 600590 0 0.0
.app_xip_area 505364 505364 0 0.0
.bss 77908 77908 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558586 558586 0 0.0
.app_xip_area 464896 464896 0 0.0
.bss 76412 76412 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578998 578998 0 0.0
.app_xip_area 475876 475876 0 0.0
.bss 85516 85516 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 917696 917696 0 0.0
(read/write) 128672 128672 0 0.0
.bss 126616 126616 0 0.0
.data 2056 2056 0 0.0
.text 917688 917688 0 0.0
BRD4161A+rpc (read only) 947788 947788 0 0.0
(read/write) 145612 145612 0 0.0
.bss 143392 143392 0 0.0
.data 2220 2220 0 0.0
.text 947780 947780 0 0.0
lock-app BRD4161A+wf200 (read only) 987536 987536 0 0.0
(read/write) 120436 120436 0 0.0
.bss 118500 118500 0 0.0
.data 1932 1932 0 0.0
.text 987528 987528 0 0.0
window-app BRD4161A (read only) 851648 851648 0 0.0
(read/write) 126912 126912 0 0.0
.bss 124984 124984 0 0.0
.data 1924 1924 0 0.0
.text 851640 851640 0 0.0
k32w light k32w061+release (read/write) 692704 692704 0 0.0
.bss 77544 77544 0 0.0
.data 1932 1932 0 0.0
.text 607428 607428 0 0.0
lock k32w061+release (read/write) 696048 696048 0 0.0
.bss 77744 77744 0 0.0
.data 1972 1972 0 0.0
.text 610532 610532 0 0.0
linux all-clusters-app debug (read only) 2402689 2402705 16 0.0
(read/write) 144824 144824 0 0.0
.bss 59328 59328 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 204933 204965 32 0.0
.text 2035010 2034994 -16 -0.0
bridge-app debug+rpc (read only) 1728141 1728237 96 0.0
(read/write) 92784 92784 0 0.0
.bss 47624 47624 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38040 38040 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141556 141556 0 0.0
.text 1470805 1470901 96 0.0
chip-tool debug (read only) 9008445 9008789 344 0.0
(read/write) 283328 283496 168 0.1
.bss 25248 25408 160 0.6
.data 1136 1136 0 0.0
.data.rel.ro 250912 250912 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 600 608 8 1.3
.rodata 480245 480245 0 0.0
.text 7920037 7920357 320 0.0
chip-tool-ipv6only arm64 (read only) 8762836 8763140 304 0.0
(read/write) 396977 397105 128 0.0
.bss 43617 43745 128 0.3
.data 1192 1192 0 0.0
.data.rel.ro 296592 296568 -24 -0.0
.dynamic 560 560 0 0.0
.got 51800 51816 16 0.0
.init 24 24 0 0.0
.init_array 184 192 8 4.3
.rodata 457884 457900 16 0.0
.text 7439668 7439908 240 0.0
door-lock-app debug (read only) 1943257 1943289 32 0.0
(read/write) 119232 119232 0 0.0
.bss 50624 50624 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62168 62168 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173564 173596 32 0.0
.text 1621234 1621234 0 0.0
lighting-app debug+rpc (read only) 2079121 2079121 0 0.0
(read/write) 124624 124624 0 0.0
.bss 51552 51552 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66120 66120 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 166364 166364 0 0.0
.text 1757330 1757330 0 0.0
ota-provider-app debug (read only) 1875425 1875409 -16 -0.0
(read/write) 114864 114864 0 0.0
.bss 50432 50432 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57448 57448 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158803 158803 0 0.0
.text 1566082 1566066 -16 -0.0
ota-requestor-app debug (read only) 1886401 1886385 -16 -0.0
(read/write) 116632 116632 0 0.0
.bss 51296 51296 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 58696 58696 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152516 152516 0 0.0
.text 1585074 1585058 -16 -0.0
shell debug (read only) 2371081 2371177 96 0.0
(read/write) 147272 147248 -24 -0.0
.bss 67648 67624 -24 -0.0
.data 864 864 0 0.0
.data.rel.ro 73112 73112 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 204882 204882 0 0.0
.text 2009666 2009762 96 0.0
thermostat-no-ble arm64 (read only) 2169412 2169396 -16 -0.0
(read/write) 148641 148625 -16 -0.0
.bss 65345 65345 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75056 75032 -24 -0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132996 132996 0 0.0
.text 1818160 1818176 16 0.0
tv-app debug (read only) 2607705 2607737 32 0.0
(read/write) 250904 250904 0 0.0
.bss 168096 168096 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73576 73576 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199069 199101 32 0.0
.text 2234850 2234850 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039967 1076235 36268 3.5
bss 125828 127680 1852 1.5
rodata 135736 141636 5900 4.3
text 701156 729516 28360 4.0
p6 all-clusters-app default (read/write) 2489400 2489400 0 0.0
.bss 118736 118736 0 0.0
.data 2696 2696 0 0.0
.text 1447664 1447664 0 0.0
light-app default (read/write) 2396568 2396568 0 0.0
.bss 113048 113048 0 0.0
.data 2544 2544 0 0.0
.text 1354832 1354832 0 0.0
lock-app default (read/write) 2360080 2360080 0 0.0
.bss 112792 112792 0 0.0
.data 2504 2504 0 0.0
.text 1318344 1318344 0 0.0
qpg lighting-app qpg6105+debug (read only) 602140 602140 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90928 90928 0 0.0
.data 1132 1132 0 0.0
.text 596820 596820 0 0.0
lock-app qpg6105+debug (read only) 567856 567856 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1084 1084 0 0.0
.text 562536 562536 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 884190 884190 0 0.0
bss 86408 86408 0 0.0
noinit 37160 37160 0 0.0
text 625148 625148 0 0.0

@harsha-rajendran harsha-rajendran mentioned this pull request Mar 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@saurabhst saurabhst saurabhst approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
linux platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jepenven-silabs @saurabhst @woody-apple