Switch device type to use a uint32 #15918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel and
lazarkov
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
|
PR #15918: Size comparison from dde4a8f to d06cc0d Increases (12 builds for linux, nrfconnect)
Decreases (2 builds for nrfconnect, telink)
Full report (13 builds for linux, nrfconnect, telink)
|
|
PR #15918: Size comparison from dde4a8f to ec39956 Increases (13 builds for esp32, linux, nrfconnect)
Decreases (4 builds for esp32, nrfconnect, telink)
Full report (15 builds for esp32, linux, nrfconnect, telink)
|
cecille
force-pushed
the
fix_size_on_DT_field_in_TXT_record
branch
from
ec39956 to
e29aa96
Compare
|
DataModelTypes.h has |
woody-apple
approved these changes
Mar 8, 2022
…eld_in_TXT_record
|
PR #15918: Size comparison from 2822511 to 7d1bd5a Increases (20 builds for cyw30739, efr32, k32w, linux, nrfconnect)
Decreases (12 builds for cyw30739, esp32, k32w, nrfconnect, p6, telink)
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
|
The remainder of the types in the mdns don't use that (wasn't around when it was written). I'd like to eventually centralize all the mdns stuff, but do it at once. Perhaps as a cleanup post 1.0. |
Co-authored-by: Boris Zbarsky <[email protected]>
…eld_in_TXT_record
|
PR #15918: Size comparison from 1c74a21 to d2bb97f Increases (10 builds for cyw30739, efr32, k32w, linux)
Decreases (12 builds for cyw30739, esp32, k32w, mbed, p6, telink)
Full report (17 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
|
andy31415
approved these changes
Mar 14, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* Switch device type to use a uint32 * fix print size. * Update src/lib/dnssd/tests/TestTxtFields.cpp Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Device type is uint32. We had it as uint16.
Change overview
Changes device type to uint32
Testing