Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device Type (DT) TXT field is 16 bits but should be 32 #14142

Closed
woody-apple opened this issue Jan 25, 2022 · 2 comments
Closed

Device Type (DT) TXT field is 16 bits but should be 32 #14142

woody-apple opened this issue Jan 25, 2022 · 2 comments
Assignees
Labels
commissioning Involves placing devices on the network, initial setup todo 🗒️ V1.0

Comments

@woody-apple
Copy link
Contributor

false


// TODO: possibly 32-bit? see spec issue #3226
uint16_t GetDeviceType(const ByteSpan & value);
void GetDeviceName(const ByteSpan & value, char * name);
void GetRotatingDeviceId(const ByteSpan & value, uint8_t * rotatingId, size_t * len);
uint16_t GetPairingHint(const ByteSpan & value);
void GetPairingInstruction(const ByteSpan & value, char * pairingInstruction);


This issue was generated by todo-issue based on a TODO comment in f0f5de0.
@tcarmelveilleux tcarmelveilleux changed the title possibly 32-bit? see spec issue #3226 Device Type (DT) TXT field is 16 bits but should be 32 Jan 31, 2022
@tcarmelveilleux
Copy link
Contributor

DeviceTypeID is 32 bits in the spec, but only vendor-specific device types are >16 bits. Suggest moving to 32 bits at this line.

@tcarmelveilleux tcarmelveilleux added commissioning Involves placing devices on the network, initial setup and removed v1_triage_split_3 labels Jan 31, 2022
@cecille
Copy link
Contributor

cecille commented Mar 15, 2022

Fixed by #15918

@cecille cecille closed this as completed Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commissioning Involves placing devices on the network, initial setup todo 🗒️ V1.0
Projects
None yet
Development

No branches or pull requests

4 participants