Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support empty subjects in group ACL entries #15608

Merged
merged 2 commits into from
Feb 26, 2022
Merged

Support empty subjects in group ACL entries #15608

merged 2 commits into from
Feb 26, 2022

Conversation

mlepage-google
Copy link
Contributor

Problem

Change code and tests to accommodate small but important spec change.

#15355

Change overview

Update the code, unit tests, YAML integration tests.

Testing

  • Tested on Linux
  • CI

@mlepage-google
Support empty subjects in group ACL entries
b740b18 
Spec was revised to allow empty subjects as wildcard for group
auth mode (as for CASE auth mode). This PR updates the code,
unit tests, and YAML tests.

Fixes project-chip#15355
@boring-cyborg boring-cyborg bot added the app label Feb 25, 2022
@restyled-io restyled-io bot mentioned this pull request Feb 25, 2022
Closed
@bzbarsky-apple bzbarsky-apple linked an issue Feb 25, 2022 that may be closed by this pull request
Update code to allow wildcard group subject in ACL #15355
Closed
@github-actions
Copy link

github-actions bot commented Feb 25, 2022 •
edited
Loading

PR #15608: Size comparison from c1d14cc to 0d72567

Increases (2 builds for linux)
platform target config section c1d14cc 0d72567 change % change
linux chip-tool debug (read only) 9002309 9003269 960 0.0
.rodata 481109 481173 64 0.0
.text 7912293 7913189 896 0.0
chip-tool-ipv6only arm64 (read only) 8756588 8757372 784 0.0
(read/write) 412033 412049 16 0.0
.got 51496 51512 16 0.0
.rodata 456964 456996 32 0.0
.text 7434388 7435092 704 0.0
Decreases (39 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c1d14cc 0d72567 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599614 599574 -40 -0.0
.app_xip_area 504460 504420 -40 -0.0
lock cyw930739m2evb_01 (read/write) 557686 557646 -40 -0.0
.app_xip_area 464068 464028 -40 -0.0
ota-requestor cyw930739m2evb_01 (read/write) 578210 578170 -40 -0.0
.app_xip_area 475160 475120 -40 -0.0
efr32 lighting-app BRD4161A (read only) 916556 916516 -40 -0.0
.text 916548 916508 -40 -0.0
BRD4161A+rpc (read only) 946644 946604 -40 -0.0
.text 946636 946596 -40 -0.0
lock-app BRD4161A+wf200 (read only) 986476 986436 -40 -0.0
.text 986468 986428 -40 -0.0
window-app BRD4161A (read only) 850620 850596 -24 -0.0
.text 850612 850588 -24 -0.0
esp32 all-clusters-app c3devkit (read only) 956550 956534 -16 -0.0
(read/write) 1393010 1392986 -24 -0.0
.flash.rodata 197272 197248 -24 -0.0
.flash.text 956550 956534 -16 -0.0
m5stack (read only) 1004691 1004671 -20 -0.0
(read/write) 458288 458264 -24 -0.0
.flash.rodata 224624 224600 -24 -0.0
.flash.text 999307 999287 -20 -0.0
k32w light k32w061+release (read/write) 691972 691936 -36 -0.0
.text 606768 606732 -36 -0.0
lock k32w061+release (read/write) 695244 695208 -36 -0.0
.text 609792 609756 -36 -0.0
linux all-clusters-app debug (read only) 2394729 2394697 -32 -0.0
.text 2027250 2027218 -32 -0.0
bridge-app debug+rpc (read only) 1720805 1720741 -64 -0.0
.rodata 141492 141460 -32 -0.0
.text 1463509 1463477 -32 -0.0
door-lock-app debug (read only) 1936273 1936241 -32 -0.0
.text 1614258 1614226 -32 -0.0
lighting-app debug+rpc (read only) 2071137 2071073 -64 -0.0
.rodata 166129 166097 -32 -0.0
.text 1749554 1749522 -32 -0.0
ota-provider-app debug (read only) 1868393 1868329 -64 -0.0
.rodata 158739 158707 -32 -0.0
.text 1559090 1559058 -32 -0.0
ota-requestor-app debug (read only) 1879385 1879321 -64 -0.0
.rodata 152452 152420 -32 -0.0
.text 1578098 1578066 -32 -0.0
shell debug (read only) 2362961 2362929 -32 -0.0
.text 2001746 2001714 -32 -0.0
thermostat-no-ble arm64 (read only) 2162948 2162852 -96 -0.0
.rodata 132980 132964 -16 -0.0
.text 1811664 1811584 -80 -0.0
tv-app debug (read only) 2589489 2589457 -32 -0.0
.text 2217074 2217042 -32 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2449728 2449624 -104 -0.0
.text 1412300 1412196 -104 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2414424 2414320 -104 -0.0
.text 1376996 1376892 -104 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2350244 2350140 -104 -0.0
.text 1312844 1312740 -104 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2340240 2340136 -104 -0.0
.text 1302812 1302708 -104 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038947 1038907 -40 -0.0
rodata 135924 135900 -24 -0.0
text 700060 700044 -16 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1002171 1002135 -36 -0.0
rodata 116164 116144 -20 -0.0
text 686440 686424 -16 -0.0
nrf52840dk_nrf52840+rpc (read/write) 968503 968463 -40 -0.0
rodata 107544 107520 -24 -0.0
text 663668 663652 -16 -0.0
nrf52840dongle_nrf52840 (read/write) 1018263 1018223 -40 -0.0
rodata 115852 115828 -24 -0.0
text 691148 691132 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904986 904946 -40 -0.0
rodata 108280 108256 -24 -0.0
text 596152 596136 -16 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 931259 931223 -36 -0.0
rodata 104996 104976 -20 -0.0
text 628928 628912 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 834886 834846 -40 -0.0
rodata 97028 97004 -24 -0.0
text 539404 539388 -16 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 929519 929483 -36 -0.0
rodata 103976 103956 -20 -0.0
text 628356 628340 -16 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 925479 925443 -36 -0.0
rodata 103672 103652 -20 -0.0
text 624612 624596 -16 -0.0
p6 all-clusters-app default (read/write) 2488128 2488104 -24 -0.0
.text 1446392 1446368 -24 -0.0
light-app default (read/write) 2395344 2395304 -40 -0.0
.text 1353608 1353568 -40 -0.0
lock-app default (read/write) 2358920 2358880 -40 -0.0
.text 1317184 1317144 -40 -0.0
qpg lighting-app qpg6105+debug (read only) 601248 601208 -40 -0.0
.text 595928 595888 -40 -0.0
lock-app qpg6105+debug (read only) 567044 567004 -40 -0.0
.text 561724 561684 -40 -0.0
telink lighting-app tlsr9518adk80d (read/write) 883158 883118 -40 -0.0
text 623996 623978 -18 -0.0
Full report (45 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c1d14cc 0d72567 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599614 599574 -40 -0.0
.app_xip_area 504460 504420 -40 -0.0
.bss 77844 77844 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557686 557646 -40 -0.0
.app_xip_area 464068 464028 -40 -0.0
.bss 76348 76348 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578210 578170 -40 -0.0
.app_xip_area 475160 475120 -40 -0.0
.bss 85452 85452 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916556 916516 -40 -0.0
(read/write) 128608 128608 0 0.0
.bss 126560 126560 0 0.0
.data 2048 2048 0 0.0
.text 916548 916508 -40 -0.0
BRD4161A+rpc (read only) 946644 946604 -40 -0.0
(read/write) 145548 145548 0 0.0
.bss 143336 143336 0 0.0
.data 2212 2212 0 0.0
.text 946636 946596 -40 -0.0
lock-app BRD4161A+wf200 (read only) 986476 986436 -40 -0.0
(read/write) 120360 120360 0 0.0
.bss 118436 118436 0 0.0
.data 1924 1924 0 0.0
.text 986468 986428 -40 -0.0
window-app BRD4161A (read only) 850620 850596 -24 -0.0
(read/write) 126844 126844 0 0.0
.bss 124928 124928 0 0.0
.data 1916 1916 0 0.0
.text 850612 850588 -24 -0.0
esp32 all-clusters-app c3devkit (read only) 956550 956534 -16 -0.0
(read/write) 1393010 1392986 -24 -0.0
.dram0.bss 62592 62592 0 0.0
.dram0.data 14228 14228 0 0.0
.flash.rodata 197272 197248 -24 -0.0
.flash.text 956550 956534 -16 -0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1004691 1004671 -20 -0.0
(read/write) 458288 458264 -24 -0.0
.dram0.bss 68096 68096 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 224624 224600 -24 -0.0
.flash.text 999307 999287 -20 -0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 691972 691936 -36 -0.0
.bss 77480 77480 0 0.0
.data 1924 1924 0 0.0
.text 606768 606732 -36 -0.0
lock k32w061+release (read/write) 695244 695208 -36 -0.0
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 609792 609756 -36 -0.0
linux all-clusters-app debug (read only) 2394729 2394697 -32 -0.0
(read/write) 144696 144696 0 0.0
.bss 59232 59232 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 204709 204709 0 0.0
.text 2027250 2027218 -32 -0.0
bridge-app debug+rpc (read only) 1720805 1720741 -64 -0.0
(read/write) 92744 92744 0 0.0
.bss 47552 47552 0 0.0
.data 2042 2042 0 0.0
.data.rel.ro 38088 38088 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141492 141460 -32 -0.0
.text 1463509 1463477 -32 -0.0
chip-tool debug (read only) 9002309 9003269 960 0.0
(read/write) 298816 298816 0 0.0
.bss 40448 40448 0 0.0
.data 1164 1164 0 0.0
.data.rel.ro 251144 251144 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 481109 481173 64 0.0
.text 7912293 7913189 896 0.0
chip-tool-ipv6only arm64 (read only) 8756588 8757372 784 0.0
(read/write) 412033 412049 16 0.0
.bss 58673 58673 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 296840 296840 0 0.0
.dynamic 560 560 0 0.0
.got 51496 51512 16 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456964 456996 32 0.0
.text 7434388 7435092 704 0.0
door-lock-app debug (read only) 1936273 1936241 -32 -0.0
(read/write) 119136 119136 0 0.0
.bss 50496 50496 0 0.0
.data 1050 1050 0 0.0
.data.rel.ro 62200 62200 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173532 173532 0 0.0
.text 1614258 1614226 -32 -0.0
lighting-app debug+rpc (read only) 2071137 2071073 -64 -0.0
(read/write) 124496 124496 0 0.0
.bss 51424 51424 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66144 66144 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 166129 166097 -32 -0.0
.text 1749554 1749522 -32 -0.0
ota-provider-app debug (read only) 1868393 1868329 -64 -0.0
(read/write) 114800 114800 0 0.0
.bss 50368 50368 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158739 158707 -32 -0.0
.text 1559090 1559058 -32 -0.0
ota-requestor-app debug (read only) 1879385 1879321 -64 -0.0
(read/write) 116568 116568 0 0.0
.bss 51232 51232 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 58744 58744 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152452 152420 -32 -0.0
.text 1578098 1578066 -32 -0.0
shell debug (read only) 2362961 2362929 -32 -0.0
(read/write) 147176 147176 0 0.0
.bss 67552 67552 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73096 73096 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 204658 204658 0 0.0
.text 2001746 2001714 -32 -0.0
thermostat-no-ble arm64 (read only) 2162948 2162852 -96 -0.0
(read/write) 148577 148577 0 0.0
.bss 65265 65265 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132980 132964 -16 -0.0
.text 1811664 1811584 -80 -0.0
tv-app debug (read only) 2589489 2589457 -32 -0.0
(read/write) 148632 148632 0 0.0
.bss 65824 65824 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 198653 198653 0 0.0
.text 2217074 2217042 -32 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449728 2449624 -104 -0.0
.bss 191016 191016 0 0.0
.data 5512 5512 0 0.0
.text 1412300 1412196 -104 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2414424 2414320 -104 -0.0
.bss 188188 188188 0 0.0
.data 5800 5800 0 0.0
.text 1376996 1376892 -104 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350244 2350140 -104 -0.0
.bss 187092 187092 0 0.0
.data 5776 5776 0 0.0
.text 1312844 1312740 -104 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1155428 1155428 0 0.0
.bss 11952 11952 0 0.0
.data 4512 4512 0 0.0
.text 118812 118812 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2340240 2340136 -104 -0.0
.bss 185736 185736 0 0.0
.data 5608 5608 0 0.0
.text 1302812 1302708 -104 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038947 1038907 -40 -0.0
bss 125756 125756 0 0.0
rodata 135924 135900 -24 -0.0
text 700060 700044 -16 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1002171 1002135 -36 -0.0
bss 122064 122064 0 0.0
rodata 116164 116144 -20 -0.0
text 686440 686424 -16 -0.0
nrf52840dk_nrf52840+rpc (read/write) 968503 968463 -40 -0.0
bss 119148 119148 0 0.0
rodata 107544 107520 -24 -0.0
text 663668 663652 -16 -0.0
nrf52840dongle_nrf52840 (read/write) 1018263 1018223 -40 -0.0
bss 123112 123112 0 0.0
rodata 115852 115828 -24 -0.0
text 691148 691132 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904986 904946 -40 -0.0
bss 119352 119352 0 0.0
rodata 108280 108256 -24 -0.0
text 596152 596136 -16 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 931259 931223 -36 -0.0
bss 120280 120280 0 0.0
rodata 104996 104976 -20 -0.0
text 628928 628912 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 834886 834846 -40 -0.0
bss 117600 117600 0 0.0
rodata 97028 97004 -24 -0.0
text 539404 539388 -16 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 501603 501603 0 0.0
bss 52584 52584 0 0.0
rodata 44500 44500 0 0.0
text 342712 342712 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 929519 929483 -36 -0.0
bss 120012 120012 0 0.0
rodata 103976 103956 -20 -0.0
text 628356 628340 -16 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 925479 925443 -36 -0.0
bss 120016 120016 0 0.0
rodata 103672 103652 -20 -0.0
text 624612 624596 -16 -0.0
shell nrf52840dk_nrf52840 (read/write) 788811 788811 0 0.0
bss 112360 112360 0 0.0
rodata 74836 74836 0 0.0
text 525504 525504 0 0.0
p6 all-clusters-app default (read/write) 2488128 2488104 -24 -0.0
.bss 118664 118664 0 0.0
.data 2688 2688 0 0.0
.text 1446392 1446368 -24 -0.0
light-app default (read/write) 2395344 2395304 -40 -0.0
.bss 112984 112984 0 0.0
.data 2536 2536 0 0.0
.text 1353608 1353568 -40 -0.0
lock-app default (read/write) 2358920 2358880 -40 -0.0
.bss 112728 112728 0 0.0
.data 2496 2496 0 0.0
.text 1317184 1317144 -40 -0.0
qpg lighting-app qpg6105+debug (read only) 601248 601208 -40 -0.0
(read/write) 146936 146936 0 0.0
.bss 90904 90904 0 0.0
.data 1124 1124 0 0.0
.text 595928 595888 -40 -0.0
lock-app qpg6105+debug (read only) 567044 567004 -40 -0.0
(read/write) 146936 146936 0 0.0
.bss 90912 90912 0 0.0
.data 1076 1076 0 0.0
.text 561724 561684 -40 -0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883158 883118 -40 -0.0
bss 86336 86336 0 0.0
noinit 37160 37160 0 0.0
text 623996 623978 -18 -0.0

@mlepage-google mlepage-google merged commit db7ab8c into project-chip:master Feb 26, 2022
@mlepage-google mlepage-google deleted the support-acl-group-wildcard branch February 26, 2022 04:49
tcarmelveilleux
tcarmelveilleux reviewed Feb 28, 2022
View reviewed changes
Copy link
Contributor

@tcarmelveilleux tcarmelveilleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees

@jepenven-silabs jepenven-silabs

Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update code to allow wildcard group subject in ACL
5 participants
@mlepage-google @tcarmelveilleux @andy31415 @bzbarsky-apple @jepenven-silabs