Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code to allow wildcard group subject in ACL #15355

Closed
mlepage-google opened this issue Feb 18, 2022 · 0 comments · Fixed by #15608
Closed

Update code to allow wildcard group subject in ACL #15355

mlepage-google opened this issue Feb 18, 2022 · 0 comments · Fixed by #15608
Assignees
@mlepage-google
Labels
acl Access Control feature group messaging V1.0

Comments

@mlepage-google
Copy link
Contributor

Per spec issue and PR
https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/4952
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/4954

will need to change code, tests, etc. to allow group wildcard.
@mlepage-google mlepage-google added acl Access Control feature group messaging V1.0 labels Feb 18, 2022
@mlepage-google mlepage-google changed the title Update code to allow wilcard group subject Update code to allow wilcard group subject in ACL Feb 18, 2022
@bzbarsky-apple bzbarsky-apple changed the title Update code to allow wilcard group subject in ACL Update code to allow wildcard group subject in ACL Feb 25, 2022
mlepage-google added a commit to mlepage-google/connectedhomeip that referenced this issue Feb 25, 2022
@mlepage-google
Support empty subjects in group ACL entries
b740b18 
Spec was revised to allow empty subjects as wildcard for group
auth mode (as for CASE auth mode). This PR updates the code,
unit tests, and YAML tests.

Fixes project-chip#15355
@mlepage-google mlepage-google mentioned this issue Feb 25, 2022
Merged
@bzbarsky-apple bzbarsky-apple linked a pull request Feb 25, 2022 that will close this issue
Support empty subjects in group ACL entries #15608
Merged
mlepage-google added a commit that referenced this issue Feb 26, 2022
@mlepage-google
Support empty subjects in group ACL entries (#15608)
db7ab8c 
Spec was revised to allow empty subjects as wildcard for group
auth mode (as for CASE auth mode). This PR updates the code,
unit tests, and YAML tests.

Fixes #15355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlepage-google mlepage-google

Labels
acl Access Control feature group messaging V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support empty subjects in group ACL entries mlepage-google/connectedhomeip
1 participant
@mlepage-google