Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary debug logs #15470

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Remove unnecessary debug logs #15470

merged 2 commits into from
Feb 23, 2022

Conversation

mkardous-silabs
Copy link
Contributor

Problem

Change overview

  • Removed logs

Testing

  • Manual test with MG24

@boring-cyborg boring-cyborg bot added the app label Feb 23, 2022
@github-actions
Copy link

github-actions bot commented Feb 23, 2022 •
edited
Loading

PR #15470: Size comparison from 9f09e52 to d7a2fb2

Decreases (37 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 9f09e52 d7a2fb2 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598714 598598 -116 -0.0
.app_xip_area 503520 503404 -116 -0.0
lock cyw930739m2evb_01 (read/write) 556750 556634 -116 -0.0
.app_xip_area 463100 462984 -116 -0.0
ota-requestor cyw930739m2evb_01 (read/write) 577754 577630 -124 -0.0
.app_xip_area 474672 474548 -124 -0.0
efr32 lighting-app BRD4161A (read only) 915708 915584 -124 -0.0
.text 915700 915576 -124 -0.0
BRD4161A+rpc (read only) 944432 944308 -124 -0.0
(read/write) 145568 145564 -4 -0.0
.text 944424 944300 -124 -0.0
window-app BRD4161A (read only) 850088 849964 -124 -0.0
(read/write) 126552 126548 -4 -0.0
.text 850080 849956 -124 -0.0
esp32 all-clusters-app c3devkit (read only) 951282 951232 -50 -0.0
(read/write) 1399522 1399442 -80 -0.0
.flash.rodata 199784 199704 -80 -0.0
.flash.text 951282 951232 -50 -0.0
m5stack (read only) 1001243 1001207 -36 -0.0
(read/write) 464920 464848 -72 -0.0
.flash.rodata 226896 226824 -72 -0.0
.flash.text 995859 995823 -36 -0.0
k32w light k32w061+release (read/write) 691396 691272 -124 -0.0
.text 606152 606028 -124 -0.0
lock k32w061+release (read/write) 694204 694080 -124 -0.0
.text 608720 608596 -124 -0.0
linux all-clusters-app debug (read only) 2393169 2392993 -176 -0.0
.rodata 206501 206437 -64 -0.0
.text 2023346 2023234 -112 -0.0
bridge-app debug+rpc (read only) 1716325 1716133 -192 -0.0
.rodata 140596 140532 -64 -0.0
.text 1459685 1459557 -128 -0.0
door-lock-app debug (read only) 1931697 1931473 -224 -0.0
.rodata 172284 172188 -96 -0.1
.text 1610642 1610514 -128 -0.0
lighting-app debug+rpc (read only) 2061049 2060857 -192 -0.0
.rodata 164721 164657 -64 -0.0
.text 1741426 1741298 -128 -0.0
ota-provider-app debug (read only) 1865025 1864801 -224 -0.0
.rodata 157075 156979 -96 -0.1
.text 1557074 1556946 -128 -0.0
ota-requestor-app debug (read only) 1876497 1876289 -208 -0.0
.rodata 151268 151172 -96 -0.1
.text 1576034 1575922 -112 -0.0
shell debug (read only) 2361625 2361449 -176 -0.0
.rodata 206770 206706 -64 -0.0
.text 1997746 1997634 -112 -0.0
thermostat-no-ble arm64 (read only) 2160220 2160028 -192 -0.0
.rodata 132700 132620 -80 -0.1
.text 1808816 1808704 -112 -0.0
tv-app debug (read only) 2586729 2586537 -192 -0.0
.rodata 199741 199677 -64 -0.0
.text 2212530 2212402 -128 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2439820 2439676 -144 -0.0
.text 1402392 1402248 -144 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2400940 2400868 -72 -0.0
.text 1363512 1363440 -72 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2336696 2336624 -72 -0.0
.text 1299296 1299224 -72 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2327348 2327204 -144 -0.0
.text 1289920 1289776 -144 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1022187 1022063 -124 -0.0
rodata 120768 120692 -76 -0.1
text 699748 699704 -44 -0.0
nrf52840dk_nrf52840+rpc (read/write) 991447 991323 -124 -0.0
rodata 112292 112216 -76 -0.1
text 679628 679584 -44 -0.0
nrf52840dongle_nrf52840 (read/write) 1037183 1037059 -124 -0.0
rodata 119616 119540 -76 -0.1
text 703796 703752 -44 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 928830 928706 -124 -0.0
rodata 114024 113948 -76 -0.1
text 614780 614736 -44 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 951227 951103 -124 -0.0
rodata 109608 109532 -76 -0.1
text 642144 642100 -44 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 858702 858578 -124 -0.0
rodata 102776 102700 -76 -0.1
text 557952 557904 -48 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 949371 949247 -124 -0.0
rodata 108560 108484 -76 -0.1
text 641532 641488 -44 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 945331 945207 -124 -0.0
rodata 108256 108180 -76 -0.1
text 637772 637728 -44 -0.0
p6 all-clusters-app default (read/write) 2490400 2490272 -128 -0.0
.text 1448664 1448536 -128 -0.0
light-app default (read/write) 2394376 2394248 -128 -0.0
.text 1352640 1352512 -128 -0.0
lock-app default (read/write) 2357952 2357824 -128 -0.0
.text 1316216 1316088 -128 -0.0
qpg lighting-app qpg6105+debug (read only) 600268 600144 -124 -0.0
.text 594948 594824 -124 -0.0
lock-app qpg6105+debug (read only) 566036 565912 -124 -0.0
.text 560716 560592 -124 -0.0
telink lighting-app tlsr9518adk80d (read/write) 881402 881278 -124 -0.0
text 622708 622658 -50 -0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 9f09e52 d7a2fb2 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598714 598598 -116 -0.0
.app_xip_area 503520 503404 -116 -0.0
.bss 77884 77884 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556750 556634 -116 -0.0
.app_xip_area 463100 462984 -116 -0.0
.bss 76380 76380 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577754 577630 -124 -0.0
.app_xip_area 474672 474548 -124 -0.0
.bss 85484 85484 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915708 915584 -124 -0.0
(read/write) 128648 128648 0 0.0
.bss 126600 126600 0 0.0
.data 2048 2048 0 0.0
.text 915700 915576 -124 -0.0
BRD4161A+rpc (read only) 944432 944308 -124 -0.0
(read/write) 145568 145564 -4 -0.0
.bss 143376 143376 0 0.0
.data 2188 2188 0 0.0
.text 944424 944300 -124 -0.0
window-app BRD4161A (read only) 850088 849964 -124 -0.0
(read/write) 126552 126548 -4 -0.0
.bss 124632 124632 0 0.0
.data 1916 1916 0 0.0
.text 850080 849956 -124 -0.0
esp32 all-clusters-app c3devkit (read only) 951282 951232 -50 -0.0
(read/write) 1399522 1399442 -80 -0.0
.dram0.bss 66672 66672 0 0.0
.dram0.data 14172 14172 0 0.0
.flash.rodata 199784 199704 -80 -0.0
.flash.text 951282 951232 -50 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 1001243 1001207 -36 -0.0
(read/write) 464920 464848 -72 -0.0
.dram0.bss 71824 71824 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 226896 226824 -72 -0.0
.flash.text 995859 995823 -36 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691396 691272 -124 -0.0
.bss 77520 77520 0 0.0
.data 1924 1924 0 0.0
.text 606152 606028 -124 -0.0
lock k32w061+release (read/write) 694204 694080 -124 -0.0
.bss 77720 77720 0 0.0
.data 1964 1964 0 0.0
.text 608720 608596 -124 -0.0
linux all-clusters-app debug (read only) 2393169 2392993 -176 -0.0
(read/write) 148560 148560 0 0.0
.bss 62944 62944 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78552 78552 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206501 206437 -64 -0.0
.text 2023346 2023234 -112 -0.0
bridge-app debug+rpc (read only) 1716325 1716133 -192 -0.0
(read/write) 93824 93824 0 0.0
.bss 48480 48480 0 0.0
.data 2042 2042 0 0.0
.data.rel.ro 38232 38232 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 140596 140532 -64 -0.0
.text 1459685 1459557 -128 -0.0
chip-tool debug (read only) 9068637 9068637 0 0.0
(read/write) 321592 321592 0 0.0
.bss 41024 41024 0 0.0
.data 1164 1164 0 0.0
.data.rel.ro 273352 273352 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 479829 479829 0 0.0
.text 7926645 7926645 0 0.0
chip-tool-ipv6only arm64 (read only) 8821412 8821412 0 0.0
(read/write) 434705 434705 0 0.0
.bss 59265 59265 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 319024 319024 0 0.0
.dynamic 560 560 0 0.0
.got 51392 51392 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456540 456540 0 0.0
.text 7446548 7446548 0 0.0
door-lock-app debug (read only) 1931697 1931473 -224 -0.0
(read/write) 119928 119928 0 0.0
.bss 51168 51168 0 0.0
.data 1050 1050 0 0.0
.data.rel.ro 62352 62352 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 172284 172188 -96 -0.1
.text 1610642 1610514 -128 -0.0
lighting-app debug+rpc (read only) 2061049 2060857 -192 -0.0
(read/write) 124840 124840 0 0.0
.bss 52128 52128 0 0.0
.data 1408 1408 0 0.0
.data.rel.ro 65856 65856 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 164721 164657 -64 -0.0
.text 1741426 1741298 -128 -0.0
ota-provider-app debug (read only) 1865025 1864801 -224 -0.0
(read/write) 115592 115592 0 0.0
.bss 51008 51008 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 57672 57672 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 157075 156979 -96 -0.1
.text 1557074 1556946 -128 -0.0
ota-requestor-app debug (read only) 1876497 1876289 -208 -0.0
(read/write) 117392 117392 0 0.0
.bss 51872 51872 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 58936 58936 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 151268 151172 -96 -0.1
.text 1576034 1575922 -112 -0.0
shell debug (read only) 2361625 2361449 -176 -0.0
(read/write) 151072 151072 0 0.0
.bss 71296 71296 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73280 73280 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206770 206706 -64 -0.0
.text 1997746 1997634 -112 -0.0
thermostat-no-ble arm64 (read only) 2160220 2160028 -192 -0.0
(read/write) 149873 149873 0 0.0
.bss 66433 66433 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75216 75216 0 0.0
.dynamic 560 560 0 0.0
.got 4208 4208 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132700 132620 -80 -0.1
.text 1808816 1808704 -112 -0.0
tv-app debug (read only) 2586729 2586537 -192 -0.0
(read/write) 152176 152176 0 0.0
.bss 69120 69120 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73864 73864 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 199741 199677 -64 -0.0
.text 2212530 2212402 -128 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439820 2439676 -144 -0.0
.bss 194612 194612 0 0.0
.data 5360 5360 0 0.0
.text 1402392 1402248 -144 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2400940 2400868 -72 -0.0
.bss 188712 188712 0 0.0
.data 5656 5656 0 0.0
.text 1363512 1363440 -72 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2336696 2336624 -72 -0.0
.bss 187608 187608 0 0.0
.data 5632 5632 0 0.0
.text 1299296 1299224 -72 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2327348 2327204 -144 -0.0
.bss 186244 186244 0 0.0
.data 5464 5464 0 0.0
.text 1289920 1289776 -144 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1022187 1022063 -124 -0.0
bss 122664 122664 0 0.0
rodata 120768 120692 -76 -0.1
text 699748 699704 -44 -0.0
nrf52840dk_nrf52840+rpc (read/write) 991447 991323 -124 -0.0
bss 119852 119852 0 0.0
rodata 112292 112216 -76 -0.1
text 679628 679584 -44 -0.0
nrf52840dongle_nrf52840 (read/write) 1037183 1037059 -124 -0.0
bss 123868 123868 0 0.0
rodata 119616 119540 -76 -0.1
text 703796 703752 -44 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 928830 928706 -124 -0.0
bss 119224 119224 0 0.0
rodata 114024 113948 -76 -0.1
text 614780 614736 -44 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 951227 951103 -124 -0.0
bss 120876 120876 0 0.0
rodata 109608 109532 -76 -0.1
text 642144 642100 -44 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 858702 858578 -124 -0.0
bss 117468 117468 0 0.0
rodata 102776 102700 -76 -0.1
text 557952 557904 -48 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527567 527567 0 0.0
bss 53632 53632 0 0.0
rodata 49948 49948 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 949371 949247 -124 -0.0
bss 120596 120596 0 0.0
rodata 108560 108484 -76 -0.1
text 641532 641488 -44 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 945331 945207 -124 -0.0
bss 120600 120600 0 0.0
rodata 108256 108180 -76 -0.1
text 637772 637728 -44 -0.0
shell nrf52840dk_nrf52840 (read/write) 811667 811667 0 0.0
bss 113348 113348 0 0.0
rodata 79752 79752 0 0.0
text 540932 540932 0 0.0
p6 all-clusters-app default (read/write) 2490400 2490272 -128 -0.0
.bss 122400 122400 0 0.0
.data 2688 2688 0 0.0
.text 1448664 1448536 -128 -0.0
light-app default (read/write) 2394376 2394248 -128 -0.0
.bss 113648 113648 0 0.0
.data 2536 2536 0 0.0
.text 1352640 1352512 -128 -0.0
lock-app default (read/write) 2357952 2357824 -128 -0.0
.bss 113400 113400 0 0.0
.data 2496 2496 0 0.0
.text 1316216 1316088 -128 -0.0
qpg lighting-app qpg6105+debug (read only) 600268 600144 -124 -0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1124 1124 0 0.0
.text 594948 594824 -124 -0.0
lock-app qpg6105+debug (read only) 566036 565912 -124 -0.0
(read/write) 146936 146936 0 0.0
.bss 90944 90944 0 0.0
.data 1076 1076 0 0.0
.text 560716 560592 -124 -0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 881402 881278 -124 -0.0
bss 86372 86372 0 0.0
noinit 37160 37160 0 0.0
text 622708 622658 -50 -0.0

@jmartinez-silabs jmartinez-silabs merged commit cb0e243 into project-chip:master Feb 23, 2022
@mkardous-silabs mkardous-silabs deleted the fix/mg24_write branch February 23, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkardous-silabs @tcarmelveilleux @jmartinez-silabs