Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BasicInformationCluster use AttributeAccessInterface to save RAM #13885

Merged
merged 33 commits into from
Jan 27, 2022
Merged

Make BasicInformationCluster use AttributeAccessInterface to save RAM #13885

merged 33 commits into from
Jan 27, 2022

Conversation

tcarmelveilleux
Copy link
Contributor

@tcarmelveilleux tcarmelveilleux commented Jan 24, 2022 •
edited
Loading

Problem

BasicInformationCluster round-trips through RAM with every attribute currently "RAM" configured. Since most values of BasicInformationCluster are constants that are fixed for an entire build, and that they are currently all returned by ConfigurationManager accessor, the round trips to RAM take more space than required and prevent using the direct source of truth for when values change.

Issue #9261

Change overview

  • Make BasicInformation Cluster employ AttributeAccessInterface
  • Move all fixed attributes to External storage
  • Better document the AttributeAccessInterface fallback path

Testing

  • Unit tests still pass
  • Integration tests still pass

@github-actions
Copy link

github-actions bot commented Jan 26, 2022 •
edited
Loading

PR #13885: Size comparison from 12db26d to 41d65a7

Decreases (9 builds for cyw30739, k32w, p6, qpg, telink)
platform target config section 12db26db 41d65a7 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580290 577818 -2472 -0.4
.app_xip_area 485180 483996 -1184 -0.2
.bss 77856 76568 -1288 -1.7
k32w light k32w061+release (read/write) 665096 662628 -2468 -0.4
.bss 77628 76340 -1288 -1.7
.text 579800 578620 -1180 -0.2
lock k32w061+release (read/write) 666080 663556 -2524 -0.4
.bss 77892 76596 -1296 -1.7
.text 580496 579268 -1228 -0.2
p6 all-clusters-app default (read/write) 2415424 2414296 -1128 -0.0
.bss 117924 116628 -1296 -1.1
.text 1373688 1372560 -1128 -0.1
light-app default (read/write) 2338904 2337760 -1144 -0.0
.bss 105684 104396 -1288 -1.2
.text 1297168 1296024 -1144 -0.1
lock-app default (read/write) 2304440 2303312 -1128 -0.0
.bss 105428 104140 -1288 -1.2
.text 1262704 1261576 -1128 -0.1
qpg lighting-app qpg6105+debug (read only) 571860 570628 -1232 -0.2
.bss 89840 88552 -1288 -1.4
.text 566540 565308 -1232 -0.2
lock-app qpg6105+debug (read only) 518060 516812 -1248 -0.2
.bss 89312 88016 -1296 -1.5
.text 512740 511492 -1248 -0.2
telink lighting-app tlsr9518adk80d (read/write) 848046 845470 -2576 -0.3
bss 87640 86352 -1288 -1.5
text 592818 591958 -860 -0.1
Full report (10 builds for cyw30739, k32w, p6, qpg, telink)
platform target config section 12db26db 41d65a7 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580290 577818 -2472 -0.4
.app_xip_area 485180 483996 -1184 -0.2
.bss 77856 76568 -1288 -1.7
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
k32w light k32w061+release (read/write) 665096 662628 -2468 -0.4
.bss 77628 76340 -1288 -1.7
.data 1868 1868 0 0.0
.text 579800 578620 -1180 -0.2
lock k32w061+release (read/write) 666080 663556 -2524 -0.4
.bss 77892 76596 -1296 -1.7
.data 1892 1892 0 0.0
.text 580496 579268 -1228 -0.2
p6 all-clusters-app default (read/write) 2415424 2414296 -1128 -0.0
.bss 117924 116628 -1296 -1.1
.data 2584 2584 0 0.0
.text 1373688 1372560 -1128 -0.1
light-app default (read/write) 2338904 2337760 -1144 -0.0
.bss 105684 104396 -1288 -1.2
.data 2408 2408 0 0.0
.text 1297168 1296024 -1144 -0.1
lock-app default (read/write) 2304440 2303312 -1128 -0.0
.bss 105428 104140 -1288 -1.2
.data 2360 2360 0 0.0
.text 1262704 1261576 -1128 -0.1
qpg lighting-app qpg6105+debug (read only) 571860 570628 -1232 -0.2
(read/write) 146936 146936 0 0.0
.bss 89840 88552 -1288 -1.4
.data 1060 1060 0 0.0
.text 566540 565308 -1232 -0.2
lock-app qpg6105+debug (read only) 518060 516812 -1248 -0.2
(read/write) 146940 146940 0 0.0
.bss 89312 88016 -1296 -1.5
.data 992 992 0 0.0
.text 512740 511492 -1248 -0.2
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848046 845470 -2576 -0.3
bss 87640 86352 -1288 -1.5
noinit 37160 37160 0 0.0
text 592818 591958 -860 -0.1

@github-actions
Copy link

github-actions bot commented Jan 26, 2022 •
edited
Loading

PR #13885: Size comparison from 12db26d to aca6232

Increases (1 build for linux)
platform target config section 12db26db aca6232 change % change
linux chip-tool-ipv6only arm64 (read only) 8904716 8904796 80 0.0
.rodata 542916 542996 80 0.0
Decreases (13 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section 12db26db aca6232 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580290 577842 -2448 -0.4
.app_xip_area 485180 484020 -1160 -0.2
.bss 77856 76568 -1288 -1.7
efr32 lighting-app BRD4161A (read only) 843316 842168 -1148 -0.1
(read/write) 127396 126112 -1284 -1.0
.bss 125496 124208 -1288 -1.0
.text 843308 842160 -1148 -0.1
BRD4161A+rpc (read only) 830672 829544 -1128 -0.1
(read/write) 144056 142768 -1288 -0.9
.bss 142056 140768 -1288 -0.9
.text 830664 829536 -1128 -0.1
window-app BRD4161A (read only) 815948 814800 -1148 -0.1
(read/write) 126052 124756 -1296 -1.0
.bss 124196 122900 -1296 -1.0
.text 815940 814792 -1148 -0.1
k32w light k32w061+release (read/write) 665096 662756 -2340 -0.4
.bss 77628 76340 -1288 -1.7
.text 579800 578748 -1052 -0.2
lock k32w061+release (read/write) 666080 663588 -2492 -0.4
.bss 77892 76596 -1296 -1.7
.text 580496 579300 -1196 -0.2
linux thermostat-no-ble arm64 (read only) 2061828 2059716 -2112 -0.1
(read/write) 148113 145537 -2576 -1.7
.bss 66417 63841 -2576 -3.9
.rodata 131428 131012 -416 -0.3
.text 1714416 1712816 -1600 -0.1
p6 all-clusters-app default (read/write) 2415424 2414296 -1128 -0.0
.bss 117924 116628 -1296 -1.1
.text 1373688 1372560 -1128 -0.1
light-app default (read/write) 2338904 2337760 -1144 -0.0
.bss 105684 104396 -1288 -1.2
.text 1297168 1296024 -1144 -0.1
lock-app default (read/write) 2304440 2303312 -1128 -0.0
.bss 105428 104140 -1288 -1.2
.text 1262704 1261576 -1128 -0.1
qpg lighting-app qpg6105+debug (read only) 571860 570764 -1096 -0.2
.bss 89840 88552 -1288 -1.4
.text 566540 565444 -1096 -0.2
lock-app qpg6105+debug (read only) 518060 516844 -1216 -0.2
.bss 89312 88016 -1296 -1.5
.text 512740 511524 -1216 -0.2
telink lighting-app tlsr9518adk80d (read/write) 848046 845486 -2560 -0.3
bss 87640 86352 -1288 -1.5
text 592818 591980 -838 -0.1
Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section 12db26db aca6232 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580290 577842 -2448 -0.4
.app_xip_area 485180 484020 -1160 -0.2
.bss 77856 76568 -1288 -1.7
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843316 842168 -1148 -0.1
(read/write) 127396 126112 -1284 -1.0
.bss 125496 124208 -1288 -1.0
.data 1900 1900 0 0.0
.text 843308 842160 -1148 -0.1
BRD4161A+rpc (read only) 830672 829544 -1128 -0.1
(read/write) 144056 142768 -1288 -0.9
.bss 142056 140768 -1288 -0.9
.data 2000 2000 0 0.0
.text 830664 829536 -1128 -0.1
window-app BRD4161A (read only) 815948 814800 -1148 -0.1
(read/write) 126052 124756 -1296 -1.0
.bss 124196 122900 -1296 -1.0
.data 1856 1856 0 0.0
.text 815940 814792 -1148 -0.1
k32w light k32w061+release (read/write) 665096 662756 -2340 -0.4
.bss 77628 76340 -1288 -1.7
.data 1868 1868 0 0.0
.text 579800 578748 -1052 -0.2
lock k32w061+release (read/write) 666080 663588 -2492 -0.4
.bss 77892 76596 -1296 -1.7
.data 1892 1892 0 0.0
.text 580496 579300 -1196 -0.2
linux chip-tool-ipv6only arm64 (read only) 8904716 8904796 80 0.0
(read/write) 393649 393649 0 0.0
.bss 55377 55377 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 263656 263656 0 0.0
.dynamic 560 560 0 0.0
.got 69728 69728 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 542916 542996 80 0.0
.text 7514868 7514868 0 0.0
thermostat-no-ble arm64 (read only) 2061828 2059716 -2112 -0.1
(read/write) 148113 145537 -2576 -1.7
.bss 66417 63841 -2576 -3.9
.data 904 904 0 0.0
.data.rel.ro 73712 73712 0 0.0
.dynamic 560 560 0 0.0
.got 4128 4128 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131428 131012 -416 -0.3
.text 1714416 1712816 -1600 -0.1
p6 all-clusters-app default (read/write) 2415424 2414296 -1128 -0.0
.bss 117924 116628 -1296 -1.1
.data 2584 2584 0 0.0
.text 1373688 1372560 -1128 -0.1
light-app default (read/write) 2338904 2337760 -1144 -0.0
.bss 105684 104396 -1288 -1.2
.data 2408 2408 0 0.0
.text 1297168 1296024 -1144 -0.1
lock-app default (read/write) 2304440 2303312 -1128 -0.0
.bss 105428 104140 -1288 -1.2
.data 2360 2360 0 0.0
.text 1262704 1261576 -1128 -0.1
qpg lighting-app qpg6105+debug (read only) 571860 570764 -1096 -0.2
(read/write) 146936 146936 0 0.0
.bss 89840 88552 -1288 -1.4
.data 1060 1060 0 0.0
.text 566540 565444 -1096 -0.2
lock-app qpg6105+debug (read only) 518060 516844 -1216 -0.2
(read/write) 146940 146940 0 0.0
.bss 89312 88016 -1296 -1.5
.data 992 992 0 0.0
.text 512740 511524 -1216 -0.2
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848046 845486 -2560 -0.3
bss 87640 86352 -1288 -1.5
noinit 37160 37160 0 0.0
text 592818 591980 -838 -0.1

@github-actions
Copy link

github-actions bot commented Jan 26, 2022 •
edited
Loading

PR #13885: Size comparison from 12db26d to 0c09801

Decreases (6 builds for esp32, mbed)
platform target config section 12db26db 0c09801 change % change
esp32 all-clusters-app c3devkit (read only) 921116 920434 -682 -0.1
(read/write) 1384722 1382938 -1784 -0.1
.dram0.bss 70872 69576 -1296 -1.8
.flash.rodata 180672 180184 -488 -0.3
.flash.text 921116 920434 -682 -0.1
m5stack (read only) 970111 969623 -488 -0.1
(read/write) 451744 449976 -1768 -0.4
.dram0.bss 75616 74328 -1288 -1.7
.flash.rodata 209968 209488 -480 -0.2
.flash.text 964727 964239 -488 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2355056 2353936 -1120 -0.0
.bss 189580 188292 -1288 -0.7
.text 1317656 1316536 -1120 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2341048 2339864 -1184 -0.1
.bss 181104 179808 -1296 -0.7
.text 1303648 1302464 -1184 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2307792 2306680 -1112 -0.0
.bss 181000 179712 -1288 -0.7
.text 1270392 1269280 -1112 -0.1
shell CY8CPROTO_062_4343W+release (read/write) 2293956 2292948 -1008 -0.0
.bss 177732 176436 -1296 -0.7
.text 1256528 1255520 -1008 -0.1
Full report (7 builds for esp32, mbed)
platform target config section 12db26db 0c09801 change % change
esp32 all-clusters-app c3devkit (read only) 921116 920434 -682 -0.1
(read/write) 1384722 1382938 -1784 -0.1
.dram0.bss 70872 69576 -1296 -1.8
.dram0.data 14244 14244 0 0.0
.flash.rodata 180672 180184 -488 -0.3
.flash.text 921116 920434 -682 -0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 970111 969623 -488 -0.1
(read/write) 451744 449976 -1768 -0.4
.dram0.bss 75616 74328 -1288 -1.7
.dram0.data 34032 34032 0 0.0
.flash.rodata 209968 209488 -480 -0.2
.flash.text 964727 964239 -488 -0.1
.iram0.text 123399 123399 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355056 2353936 -1120 -0.0
.bss 189580 188292 -1288 -0.7
.data 5296 5296 0 0.0
.text 1317656 1316536 -1120 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2341048 2339864 -1184 -0.1
.bss 181104 179808 -1296 -0.7
.data 5584 5584 0 0.0
.text 1303648 1302464 -1184 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307792 2306680 -1112 -0.0
.bss 181000 179712 -1288 -0.7
.data 5568 5568 0 0.0
.text 1270392 1269280 -1112 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293956 2292948 -1008 -0.0
.bss 177732 176436 -1296 -0.7
.data 5384 5384 0 0.0
.text 1256528 1255520 -1008 -0.1

@github-actions
Copy link

github-actions bot commented Jan 27, 2022 •
edited
Loading

PR #13885: Size comparison from 777fec7 to cb84ab4

Increases (1 build for linux)
platform target config section 777fec7 cb84ab4 change % change
linux chip-tool-ipv6only arm64 (read only) 8934988 8935068 80 0.0
.rodata 544340 544420 80 0.0
Decreases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 777fec7 cb84ab4 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580466 577818 -2648 -0.5
.app_xip_area 485360 484008 -1352 -0.3
.bss 77852 76556 -1296 -1.7
efr32 lighting-app BRD4161A (read only) 843508 842200 -1308 -0.2
(read/write) 127396 126104 -1292 -1.0
.bss 125496 124200 -1296 -1.0
.text 843500 842192 -1308 -0.2
BRD4161A+rpc (read only) 830864 829576 -1288 -0.2
(read/write) 144056 142760 -1296 -0.9
.bss 142056 140760 -1296 -0.9
.text 830856 829568 -1288 -0.2
window-app BRD4161A (read only) 816124 814816 -1308 -0.2
(read/write) 126052 124756 -1296 -1.0
.bss 124196 122900 -1296 -1.0
.text 816116 814808 -1308 -0.2
esp32 all-clusters-app c3devkit (read only) 921826 920958 -868 -0.1
(read/write) 1384866 1383042 -1824 -0.1
.dram0.bss 70880 69584 -1296 -1.8
.flash.rodata 180816 180288 -528 -0.3
.flash.text 921826 920958 -868 -0.1
m5stack (read only) 970759 970139 -620 -0.1
(read/write) 451896 450088 -1808 -0.4
.dram0.bss 75624 74328 -1296 -1.7
.flash.rodata 210112 209600 -512 -0.2
.flash.text 965375 964755 -620 -0.1
k32w light k32w061+release (read/write) 665304 662668 -2636 -0.4
.bss 77628 76332 -1296 -1.7
.text 580008 578668 -1340 -0.2
lock k32w061+release (read/write) 666208 663524 -2684 -0.4
.bss 77892 76596 -1296 -1.7
.text 580624 579236 -1388 -0.2
linux thermostat-no-ble arm64 (read only) 2062772 2060100 -2672 -0.1
(read/write) 148209 145617 -2592 -1.7
.bss 66417 63825 -2592 -3.9
.rodata 131492 131028 -464 -0.4
.text 1715232 1713168 -2064 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2355816 2354472 -1344 -0.1
.bss 189588 188292 -1296 -0.7
.text 1318416 1317072 -1344 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2341088 2339744 -1344 -0.1
.bss 181104 179808 -1296 -0.7
.text 1303688 1302344 -1344 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2307896 2306560 -1336 -0.1
.bss 181000 179704 -1296 -0.7
.text 1270496 1269160 -1336 -0.1
shell CY8CPROTO_062_4343W+release (read/write) 2294100 2292764 -1336 -0.1
.bss 177732 176436 -1296 -0.7
.text 1256672 1255336 -1336 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983787 981115 -2672 -0.3
bss 120860 119564 -1296 -1.1
rodata 116480 115984 -496 -0.4
text 668656 667760 -896 -0.1
nrf52840dk_nrf52840+rpc (read/write) 967651 964947 -2704 -0.3
bss 117904 116608 -1296 -1.1
rodata 108016 107520 -496 -0.5
text 663328 662432 -896 -0.1
nrf52840dongle_nrf52840 (read/write) 999859 997139 -2720 -0.3
bss 122032 120736 -1296 -1.1
rodata 115332 114820 -512 -0.4
text 674032 673136 -896 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 893010 890286 -2724 -0.3
bss 117648 116352 -1296 -1.1
rodata 109780 109264 -516 -0.5
text 584836 583944 -892 -0.2
lock-app nrf52840dk_nrf52840 (read/write) 916355 913647 -2708 -0.3
bss 119240 117944 -1296 -1.1
rodata 105120 104620 -500 -0.5
text 614588 613692 -896 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 826374 823702 -2672 -0.3
bss 116056 114760 -1296 -1.1
rodata 98344 97832 -512 -0.5
text 531540 530648 -892 -0.2
pump-app nrf52840dk_nrf52840 (read/write) 919219 916515 -2704 -0.3
bss 118992 117696 -1296 -1.1
rodata 105632 105136 -496 -0.5
text 617124 616228 -896 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 914403 911699 -2704 -0.3
bss 119016 117720 -1296 -1.1
rodata 104736 104240 -496 -0.5
text 613160 612264 -896 -0.1
p6 all-clusters-app default (read/write) 2416504 2415216 -1288 -0.1
.bss 117932 116636 -1296 -1.1
.text 1374768 1373480 -1288 -0.1
light-app default (read/write) 2339080 2337792 -1288 -0.1
.bss 105684 104388 -1296 -1.2
.text 1297344 1296056 -1288 -0.1
lock-app default (read/write) 2304600 2303312 -1288 -0.1
.bss 105428 104132 -1296 -1.2
.text 1262864 1261576 -1288 -0.1
qpg lighting-app qpg6105+debug (read only) 572100 570724 -1376 -0.2
.bss 89840 88544 -1296 -1.4
.text 566780 565404 -1376 -0.2
lock-app qpg6105+debug (read only) 518180 516788 -1392 -0.3
.bss 89312 88016 -1296 -1.5
.text 512860 511468 -1392 -0.3
telink lighting-app tlsr9518adk80d (read/write) 848182 845406 -2776 -0.3
bss 87640 86344 -1296 -1.5
text 592954 591932 -1022 -0.2
Full report (32 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 777fec7 cb84ab4 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580466 577818 -2648 -0.5
.app_xip_area 485360 484008 -1352 -0.3
.bss 77852 76556 -1296 -1.7
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843508 842200 -1308 -0.2
(read/write) 127396 126104 -1292 -1.0
.bss 125496 124200 -1296 -1.0
.data 1900 1900 0 0.0
.text 843500 842192 -1308 -0.2
BRD4161A+rpc (read only) 830864 829576 -1288 -0.2
(read/write) 144056 142760 -1296 -0.9
.bss 142056 140760 -1296 -0.9
.data 2000 2000 0 0.0
.text 830856 829568 -1288 -0.2
window-app BRD4161A (read only) 816124 814816 -1308 -0.2
(read/write) 126052 124756 -1296 -1.0
.bss 124196 122900 -1296 -1.0
.data 1856 1856 0 0.0
.text 816116 814808 -1308 -0.2
esp32 all-clusters-app c3devkit (read only) 921826 920958 -868 -0.1
(read/write) 1384866 1383042 -1824 -0.1
.dram0.bss 70880 69584 -1296 -1.8
.dram0.data 14252 14252 0 0.0
.flash.rodata 180816 180288 -528 -0.3
.flash.text 921826 920958 -868 -0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 970759 970139 -620 -0.1
(read/write) 451896 450088 -1808 -0.4
.dram0.bss 75624 74328 -1296 -1.7
.dram0.data 34032 34032 0 0.0
.flash.rodata 210112 209600 -512 -0.2
.flash.text 965375 964755 -620 -0.1
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 665304 662668 -2636 -0.4
.bss 77628 76332 -1296 -1.7
.data 1868 1868 0 0.0
.text 580008 578668 -1340 -0.2
lock k32w061+release (read/write) 666208 663524 -2684 -0.4
.bss 77892 76596 -1296 -1.7
.data 1892 1892 0 0.0
.text 580624 579236 -1388 -0.2
linux chip-tool-ipv6only arm64 (read only) 8934988 8935068 80 0.0
(read/write) 394817 394817 0 0.0
.bss 55377 55377 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 264536 264536 0 0.0
.dynamic 560 560 0 0.0
.got 70024 70024 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 544340 544420 80 0.0
.text 7540980 7540980 0 0.0
thermostat-no-ble arm64 (read only) 2062772 2060100 -2672 -0.1
(read/write) 148209 145617 -2592 -1.7
.bss 66417 63825 -2592 -3.9
.data 904 904 0 0.0
.data.rel.ro 73800 73800 0 0.0
.dynamic 560 560 0 0.0
.got 4128 4128 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131492 131028 -464 -0.4
.text 1715232 1713168 -2064 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355816 2354472 -1344 -0.1
.bss 189588 188292 -1296 -0.7
.data 5296 5296 0 0.0
.text 1318416 1317072 -1344 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2341088 2339744 -1344 -0.1
.bss 181104 179808 -1296 -0.7
.data 5584 5584 0 0.0
.text 1303688 1302344 -1344 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307896 2306560 -1336 -0.1
.bss 181000 179704 -1296 -0.7
.data 5568 5568 0 0.0
.text 1270496 1269160 -1336 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294100 2292764 -1336 -0.1
.bss 177732 176436 -1296 -0.7
.data 5384 5384 0 0.0
.text 1256672 1255336 -1336 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983787 981115 -2672 -0.3
bss 120860 119564 -1296 -1.1
rodata 116480 115984 -496 -0.4
text 668656 667760 -896 -0.1
nrf52840dk_nrf52840+rpc (read/write) 967651 964947 -2704 -0.3
bss 117904 116608 -1296 -1.1
rodata 108016 107520 -496 -0.5
text 663328 662432 -896 -0.1
nrf52840dongle_nrf52840 (read/write) 999859 997139 -2720 -0.3
bss 122032 120736 -1296 -1.1
rodata 115332 114820 -512 -0.4
text 674032 673136 -896 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 893010 890286 -2724 -0.3
bss 117648 116352 -1296 -1.1
rodata 109780 109264 -516 -0.5
text 584836 583944 -892 -0.2
lock-app nrf52840dk_nrf52840 (read/write) 916355 913647 -2708 -0.3
bss 119240 117944 -1296 -1.1
rodata 105120 104620 -500 -0.5
text 614588 613692 -896 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 826374 823702 -2672 -0.3
bss 116056 114760 -1296 -1.1
rodata 98344 97832 -512 -0.5
text 531540 530648 -892 -0.2
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 919219 916515 -2704 -0.3
bss 118992 117696 -1296 -1.1
rodata 105632 105136 -496 -0.5
text 617124 616228 -896 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 914403 911699 -2704 -0.3
bss 119016 117720 -1296 -1.1
rodata 104736 104240 -496 -0.5
text 613160 612264 -896 -0.1
shell nrf52840dk_nrf52840 (read/write) 798219 798219 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533652 533652 0 0.0
p6 all-clusters-app default (read/write) 2416504 2415216 -1288 -0.1
.bss 117932 116636 -1296 -1.1
.data 2584 2584 0 0.0
.text 1374768 1373480 -1288 -0.1
light-app default (read/write) 2339080 2337792 -1288 -0.1
.bss 105684 104388 -1296 -1.2
.data 2408 2408 0 0.0
.text 1297344 1296056 -1288 -0.1
lock-app default (read/write) 2304600 2303312 -1288 -0.1
.bss 105428 104132 -1296 -1.2
.data 2360 2360 0 0.0
.text 1262864 1261576 -1288 -0.1
qpg lighting-app qpg6105+debug (read only) 572100 570724 -1376 -0.2
(read/write) 146936 146936 0 0.0
.bss 89840 88544 -1296 -1.4
.data 1060 1060 0 0.0
.text 566780 565404 -1376 -0.2
lock-app qpg6105+debug (read only) 518180 516788 -1392 -0.3
(read/write) 146940 146940 0 0.0
.bss 89312 88016 -1296 -1.5
.data 992 992 0 0.0
.text 512860 511468 -1392 -0.3
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848182 845406 -2776 -0.3
bss 87640 86344 -1296 -1.5
noinit 37160 37160 0 0.0
text 592954 591932 -1022 -0.2

@woody-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Jan 27, 2022 •
edited
Loading

PR #13885: Size comparison from 63d0c37 to 44f9901

Increases (1 build for linux)
platform target config section 63d0c37 44f9901 change % change
linux chip-tool-ipv6only arm64 (read only) 6744396 6749028 4632 0.1
(read/write) 279025 279073 48 0.0
.data.rel.ro 175864 175912 48 0.0
.rodata 387684 387948 264 0.1
.text 5785492 5789812 4320 0.1
Decreases (22 builds for cyw30739, efr32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 63d0c37 44f9901 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580918 576818 -4100 -0.7
.app_xip_area 485716 482912 -2804 -0.6
.bss 77948 76652 -1296 -1.7
lock-app CYW30739 (read/write) 538922 536270 -2652 -0.5
.app_xip_area 445264 443908 -1356 -0.3
.bss 76444 75148 -1296 -1.7
efr32 lighting-app BRD4161A (read only) 844508 841456 -3052 -0.4
(read/write) 127492 126200 -1292 -1.0
.bss 125592 124296 -1296 -1.0
.text 844500 841448 -3052 -0.4
BRD4161A+rpc (read only) 831880 828832 -3048 -0.4
(read/write) 144152 142856 -1296 -0.9
.bss 142152 140856 -1296 -0.9
.text 831872 828824 -3048 -0.4
window-app BRD4161A (read only) 817124 815816 -1308 -0.2
(read/write) 126148 124852 -1296 -1.0
.bss 124292 122996 -1296 -1.0
.text 817116 815808 -1308 -0.2
k32w light k32w061+release (read/write) 665716 663064 -2652 -0.4
.bss 77724 76428 -1296 -1.7
.text 580324 578968 -1356 -0.2
lock k32w061+release (read/write) 666668 663968 -2700 -0.4
.bss 77988 76692 -1296 -1.7
.text 580988 579584 -1404 -0.2
linux thermostat-no-ble arm64 (read only) 2084468 2081844 -2624 -0.1
(read/write) 152097 149505 -2592 -1.7
.bss 69761 67169 -2592 -3.7
.rodata 131940 131476 -464 -0.4
.text 1735136 1733120 -2016 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 984183 980063 -4120 -0.4
bss 120956 119656 -1300 -1.1
rodata 116492 115780 -712 -0.6
text 668944 666812 -2132 -0.3
nrf52840dk_nrf52840+rpc (read/write) 968047 963891 -4156 -0.4
bss 118000 116700 -1300 -1.1
rodata 108028 107312 -716 -0.7
text 663616 661484 -2132 -0.3
nrf52840dongle_nrf52840 (read/write) 1000303 996135 -4168 -0.4
bss 122128 120828 -1300 -1.1
rodata 115344 114616 -728 -0.6
text 674372 672240 -2132 -0.3
nrf5340dk_nrf5340_cpuapp (read/write) 893406 889234 -4172 -0.5
bss 117744 116444 -1300 -1.1
rodata 109792 109060 -732 -0.7
text 585124 582996 -2128 -0.4
lock-app nrf52840dk_nrf52840 (read/write) 916799 914091 -2708 -0.3
bss 119336 118040 -1296 -1.1
rodata 105132 104632 -500 -0.5
text 614928 614024 -904 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 826834 824146 -2688 -0.3
bss 116152 114856 -1296 -1.1
rodata 98356 97844 -512 -0.5
text 531880 530984 -896 -0.2
pump-app nrf52840dk_nrf52840 (read/write) 919663 916959 -2704 -0.3
bss 119088 117792 -1296 -1.1
rodata 105644 105148 -496 -0.5
text 617464 616560 -904 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 914847 912143 -2704 -0.3
bss 119112 117816 -1296 -1.1
rodata 104748 104252 -496 -0.5
text 613500 612600 -900 -0.1
p6 all-clusters-app default (read/write) 2443448 2442144 -1304 -0.1
.bss 118036 116740 -1296 -1.1
.text 1401712 1400408 -1304 -0.1
light-app default (read/write) 2340096 2337032 -3064 -0.1
.bss 105780 104476 -1304 -1.2
.text 1298360 1295296 -3064 -0.2
lock-app default (read/write) 2305600 2304312 -1288 -0.1
.bss 105524 104228 -1296 -1.2
.text 1263864 1262576 -1288 -0.1
qpg lighting-app qpg6105+debug (read only) 572424 569576 -2848 -0.5
.bss 89936 88632 -1304 -1.4
.text 567104 564256 -2848 -0.5
lock-app qpg6105+debug (read only) 518552 517136 -1416 -0.3
.bss 89408 88112 -1296 -1.4
.text 513232 511816 -1416 -0.3
telink lighting-app tlsr9518adk80d (read/write) 848690 844226 -4464 -0.5
bss 87736 86440 -1296 -1.5
text 593356 590864 -2492 -0.4
Full report (26 builds for cyw30739, efr32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 63d0c37 44f9901 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580918 576818 -4100 -0.7
.app_xip_area 485716 482912 -2804 -0.6
.bss 77948 76652 -1296 -1.7
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 538922 536270 -2652 -0.5
.app_xip_area 445264 443908 -1356 -0.3
.bss 76444 75148 -1296 -1.7
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 844508 841456 -3052 -0.4
(read/write) 127492 126200 -1292 -1.0
.bss 125592 124296 -1296 -1.0
.data 1900 1900 0 0.0
.text 844500 841448 -3052 -0.4
BRD4161A+rpc (read only) 831880 828832 -3048 -0.4
(read/write) 144152 142856 -1296 -0.9
.bss 142152 140856 -1296 -0.9
.data 2000 2000 0 0.0
.text 831872 828824 -3048 -0.4
window-app BRD4161A (read only) 817124 815816 -1308 -0.2
(read/write) 126148 124852 -1296 -1.0
.bss 124292 122996 -1296 -1.0
.data 1856 1856 0 0.0
.text 817116 815808 -1308 -0.2
k32w light k32w061+release (read/write) 665716 663064 -2652 -0.4
.bss 77724 76428 -1296 -1.7
.data 1868 1868 0 0.0
.text 580324 578968 -1356 -0.2
lock k32w061+release (read/write) 666668 663968 -2700 -0.4
.bss 77988 76692 -1296 -1.7
.data 1892 1892 0 0.0
.text 580988 579584 -1404 -0.2
linux chip-tool-ipv6only arm64 (read only) 6744396 6749028 4632 0.1
(read/write) 279025 279073 48 0.0
.bss 55537 55537 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 175864 175912 48 0.0
.dynamic 560 560 0 0.0
.got 42744 42744 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 387684 387948 264 0.1
.text 5785492 5789812 4320 0.1
thermostat-no-ble arm64 (read only) 2084468 2081844 -2624 -0.1
(read/write) 152097 149505 -2592 -1.7
.bss 69761 67169 -2592 -3.7
.data 960 960 0 0.0
.data.rel.ro 74256 74256 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131940 131476 -464 -0.4
.text 1735136 1733120 -2016 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 984183 980063 -4120 -0.4
bss 120956 119656 -1300 -1.1
rodata 116492 115780 -712 -0.6
text 668944 666812 -2132 -0.3
nrf52840dk_nrf52840+rpc (read/write) 968047 963891 -4156 -0.4
bss 118000 116700 -1300 -1.1
rodata 108028 107312 -716 -0.7
text 663616 661484 -2132 -0.3
nrf52840dongle_nrf52840 (read/write) 1000303 996135 -4168 -0.4
bss 122128 120828 -1300 -1.1
rodata 115344 114616 -728 -0.6
text 674372 672240 -2132 -0.3
nrf5340dk_nrf5340_cpuapp (read/write) 893406 889234 -4172 -0.5
bss 117744 116444 -1300 -1.1
rodata 109792 109060 -732 -0.7
text 585124 582996 -2128 -0.4
lock-app nrf52840dk_nrf52840 (read/write) 916799 914091 -2708 -0.3
bss 119336 118040 -1296 -1.1
rodata 105132 104632 -500 -0.5
text 614928 614024 -904 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 826834 824146 -2688 -0.3
bss 116152 114856 -1296 -1.1
rodata 98356 97844 -512 -0.5
text 531880 530984 -896 -0.2
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 919663 916959 -2704 -0.3
bss 119088 117792 -1296 -1.1
rodata 105644 105148 -496 -0.5
text 617464 616560 -904 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 914847 912143 -2704 -0.3
bss 119112 117816 -1296 -1.1
rodata 104748 104252 -496 -0.5
text 613500 612600 -900 -0.1
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
p6 all-clusters-app default (read/write) 2443448 2442144 -1304 -0.1
.bss 118036 116740 -1296 -1.1
.data 2584 2584 0 0.0
.text 1401712 1400408 -1304 -0.1
light-app default (read/write) 2340096 2337032 -3064 -0.1
.bss 105780 104476 -1304 -1.2
.data 2408 2408 0 0.0
.text 1298360 1295296 -3064 -0.2
lock-app default (read/write) 2305600 2304312 -1288 -0.1
.bss 105524 104228 -1296 -1.2
.data 2360 2360 0 0.0
.text 1263864 1262576 -1288 -0.1
qpg lighting-app qpg6105+debug (read only) 572424 569576 -2848 -0.5
(read/write) 146936 146936 0 0.0
.bss 89936 88632 -1304 -1.4
.data 1060 1060 0 0.0
.text 567104 564256 -2848 -0.5
lock-app qpg6105+debug (read only) 518552 517136 -1416 -0.3
(read/write) 146940 146940 0 0.0
.bss 89408 88112 -1296 -1.4
.data 992 992 0 0.0
.text 513232 511816 -1416 -0.3
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848690 844226 -4464 -0.5
bss 87736 86440 -1296 -1.5
noinit 37160 37160 0 0.0
text 593356 590864 -2492 -0.4

@github-actions
Copy link

github-actions bot commented Jan 27, 2022 •
edited
Loading

PR #13885: Size comparison from 2c4de1b to 01285d5

Decreases (28 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2c4de1b 01285d5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 581218 578554 -2664 -0.5
.app_xip_area 486016 484648 -1368 -0.3
.bss 77948 76652 -1296 -1.7
lock-app CYW30739 (read/write) 539230 536566 -2664 -0.5
.app_xip_area 445572 444204 -1368 -0.3
.bss 76444 75148 -1296 -1.7
efr32 lighting-app BRD4161A (read only) 844852 843560 -1292 -0.2
(read/write) 127492 126200 -1292 -1.0
.bss 125592 124296 -1296 -1.0
.text 844844 843552 -1292 -0.2
BRD4161A+rpc (read only) 832216 830912 -1304 -0.2
(read/write) 144152 142856 -1296 -0.9
.bss 142152 140856 -1296 -0.9
.text 832208 830904 -1304 -0.2
window-app BRD4161A (read only) 817444 816136 -1308 -0.2
(read/write) 126148 124852 -1296 -1.0
.bss 124292 122996 -1296 -1.0
.text 817436 816128 -1308 -0.2
esp32 all-clusters-app c3devkit (read only) 933942 933062 -880 -0.1
(read/write) 1399146 1397322 -1824 -0.1
.dram0.bss 70984 69688 -1296 -1.8
.flash.rodata 195008 194480 -528 -0.3
.flash.text 933942 933062 -880 -0.1
m5stack (read only) 981523 980987 -536 -0.1
(read/write) 463500 461692 -1808 -0.4
.dram0.bss 75728 74432 -1296 -1.7
.flash.rodata 221620 221108 -512 -0.2
.flash.text 976139 975603 -536 -0.1
k32w light k32w061+release (read/write) 666008 663372 -2636 -0.4
.bss 77724 76428 -1296 -1.7
.text 580616 579276 -1340 -0.2
lock k32w061+release (read/write) 666976 664276 -2700 -0.4
.bss 77988 76692 -1296 -1.7
.text 581296 579892 -1404 -0.2
linux thermostat-no-ble arm64 (read only) 2086108 2083420 -2688 -0.1
(read/write) 152129 149537 -2592 -1.7
.bss 69761 67169 -2592 -3.7
.rodata 132220 131756 -464 -0.4
.text 1736400 1734320 -2080 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2383952 2382608 -1344 -0.1
.bss 189692 188396 -1296 -0.7
.text 1346552 1345208 -1344 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2341760 2340424 -1336 -0.1
.bss 181200 179904 -1296 -0.7
.text 1304360 1303024 -1336 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2308576 2307176 -1400 -0.1
.bss 181096 179800 -1296 -0.7
.text 1271176 1269776 -1400 -0.1
shell CY8CPROTO_062_4343W+release (read/write) 2294780 2293380 -1400 -0.1
.bss 177828 176532 -1296 -0.7
.text 1257352 1255952 -1400 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 984475 981803 -2672 -0.3
bss 120956 119660 -1296 -1.1
rodata 116576 116080 -496 -0.4
text 669160 668252 -908 -0.1
nrf52840dk_nrf52840+rpc (read/write) 968339 965635 -2704 -0.3
bss 118000 116704 -1296 -1.1
rodata 108112 107616 -496 -0.5
text 663832 662924 -908 -0.1
nrf52840dongle_nrf52840 (read/write) 1000611 997875 -2736 -0.3
bss 122128 120832 -1296 -1.1
rodata 115428 114916 -512 -0.4
text 674588 673680 -908 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 893698 890974 -2724 -0.3
bss 117744 116448 -1296 -1.1
rodata 109876 109360 -516 -0.5
text 585340 584440 -900 -0.2
lock-app nrf52840dk_nrf52840 (read/write) 917107 914383 -2724 -0.3
bss 119336 118040 -1296 -1.1
rodata 105216 104716 -500 -0.5
text 615144 614236 -908 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 827126 824438 -2688 -0.3
bss 116152 114856 -1296 -1.1
rodata 98440 97928 -512 -0.5
text 532096 531196 -900 -0.2
pump-app nrf52840dk_nrf52840 (read/write) 919971 917251 -2720 -0.3
bss 119088 117792 -1296 -1.1
rodata 105728 105232 -496 -0.5
text 617680 616772 -908 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 915155 912435 -2720 -0.3
bss 119112 117816 -1296 -1.1
rodata 104832 104336 -496 -0.5
text 613720 612812 -908 -0.1
p6 all-clusters-app default (read/write) 2443520 2442216 -1304 -0.1
.bss 118036 116740 -1296 -1.1
.text 1401784 1400480 -1304 -0.1
light-app default (read/write) 2340432 2339128 -1304 -0.1
.bss 105780 104484 -1296 -1.2
.text 1298696 1297392 -1304 -0.1
lock-app default (read/write) 2305944 2304656 -1288 -0.1
.bss 105524 104228 -1296 -1.2
.text 1264208 1262920 -1288 -0.1
qpg lighting-app qpg6105+debug (read only) 572716 571300 -1416 -0.2
.bss 89936 88640 -1296 -1.4
.text 567396 565980 -1416 -0.2
lock-app qpg6105+debug (read only) 518836 517436 -1400 -0.3
.bss 89408 88112 -1296 -1.4
.text 513516 512116 -1400 -0.3
telink lighting-app tlsr9518adk80d (read/write) 849010 846218 -2792 -0.3
bss 87736 86440 -1296 -1.5
text 593590 592556 -1034 -0.2
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2c4de1b 01285d5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 581218 578554 -2664 -0.5
.app_xip_area 486016 484648 -1368 -0.3
.bss 77948 76652 -1296 -1.7
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 539230 536566 -2664 -0.5
.app_xip_area 445572 444204 -1368 -0.3
.bss 76444 75148 -1296 -1.7
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 844852 843560 -1292 -0.2
(read/write) 127492 126200 -1292 -1.0
.bss 125592 124296 -1296 -1.0
.data 1900 1900 0 0.0
.text 844844 843552 -1292 -0.2
BRD4161A+rpc (read only) 832216 830912 -1304 -0.2
(read/write) 144152 142856 -1296 -0.9
.bss 142152 140856 -1296 -0.9
.data 2000 2000 0 0.0
.text 832208 830904 -1304 -0.2
window-app BRD4161A (read only) 817444 816136 -1308 -0.2
(read/write) 126148 124852 -1296 -1.0
.bss 124292 122996 -1296 -1.0
.data 1856 1856 0 0.0
.text 817436 816128 -1308 -0.2
esp32 all-clusters-app c3devkit (read only) 933942 933062 -880 -0.1
(read/write) 1399146 1397322 -1824 -0.1
.dram0.bss 70984 69688 -1296 -1.8
.dram0.data 14244 14244 0 0.0
.flash.rodata 195008 194480 -528 -0.3
.flash.text 933942 933062 -880 -0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 981523 980987 -536 -0.1
(read/write) 463500 461692 -1808 -0.4
.dram0.bss 75728 74432 -1296 -1.7
.dram0.data 34024 34024 0 0.0
.flash.rodata 221620 221108 -512 -0.2
.flash.text 976139 975603 -536 -0.1
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 666008 663372 -2636 -0.4
.bss 77724 76428 -1296 -1.7
.data 1868 1868 0 0.0
.text 580616 579276 -1340 -0.2
lock k32w061+release (read/write) 666976 664276 -2700 -0.4
.bss 77988 76692 -1296 -1.7
.data 1892 1892 0 0.0
.text 581296 579892 -1404 -0.2
linux chip-tool-ipv6only arm64 (read only) 6767940 6767940 0 0.0
(read/write) 279201 279201 0 0.0
.bss 55537 55537 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 175984 175984 0 0.0
.dynamic 560 560 0 0.0
.got 42784 42784 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 388428 388428 0 0.0
.text 5807412 5807412 0 0.0
thermostat-no-ble arm64 (read only) 2086108 2083420 -2688 -0.1
(read/write) 152129 149537 -2592 -1.7
.bss 69761 67169 -2592 -3.7
.data 960 960 0 0.0
.data.rel.ro 74288 74288 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 132220 131756 -464 -0.4
.text 1736400 1734320 -2080 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2383952 2382608 -1344 -0.1
.bss 189692 188396 -1296 -0.7
.data 5288 5288 0 0.0
.text 1346552 1345208 -1344 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2341760 2340424 -1336 -0.1
.bss 181200 179904 -1296 -0.7
.data 5584 5584 0 0.0
.text 1304360 1303024 -1336 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308576 2307176 -1400 -0.1
.bss 181096 179800 -1296 -0.7
.data 5568 5568 0 0.0
.text 1271176 1269776 -1400 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294780 2293380 -1400 -0.1
.bss 177828 176532 -1296 -0.7
.data 5384 5384 0 0.0
.text 1257352 1255952 -1400 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 984475 981803 -2672 -0.3
bss 120956 119660 -1296 -1.1
rodata 116576 116080 -496 -0.4
text 669160 668252 -908 -0.1
nrf52840dk_nrf52840+rpc (read/write) 968339 965635 -2704 -0.3
bss 118000 116704 -1296 -1.1
rodata 108112 107616 -496 -0.5
text 663832 662924 -908 -0.1
nrf52840dongle_nrf52840 (read/write) 1000611 997875 -2736 -0.3
bss 122128 120832 -1296 -1.1
rodata 115428 114916 -512 -0.4
text 674588 673680 -908 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 893698 890974 -2724 -0.3
bss 117744 116448 -1296 -1.1
rodata 109876 109360 -516 -0.5
text 585340 584440 -900 -0.2
lock-app nrf52840dk_nrf52840 (read/write) 917107 914383 -2724 -0.3
bss 119336 118040 -1296 -1.1
rodata 105216 104716 -500 -0.5
text 615144 614236 -908 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 827126 824438 -2688 -0.3
bss 116152 114856 -1296 -1.1
rodata 98440 97928 -512 -0.5
text 532096 531196 -900 -0.2
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 919971 917251 -2720 -0.3
bss 119088 117792 -1296 -1.1
rodata 105728 105232 -496 -0.5
text 617680 616772 -908 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 915155 912435 -2720 -0.3
bss 119112 117816 -1296 -1.1
rodata 104832 104336 -496 -0.5
text 613720 612812 -908 -0.1
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
p6 all-clusters-app default (read/write) 2443520 2442216 -1304 -0.1
.bss 118036 116740 -1296 -1.1
.data 2584 2584 0 0.0
.text 1401784 1400480 -1304 -0.1
light-app default (read/write) 2340432 2339128 -1304 -0.1
.bss 105780 104484 -1296 -1.2
.data 2408 2408 0 0.0
.text 1298696 1297392 -1304 -0.1
lock-app default (read/write) 2305944 2304656 -1288 -0.1
.bss 105524 104228 -1296 -1.2
.data 2360 2360 0 0.0
.text 1264208 1262920 -1288 -0.1
qpg lighting-app qpg6105+debug (read only) 572716 571300 -1416 -0.2
(read/write) 146936 146936 0 0.0
.bss 89936 88640 -1296 -1.4
.data 1060 1060 0 0.0
.text 567396 565980 -1416 -0.2
lock-app qpg6105+debug (read only) 518836 517436 -1400 -0.3
(read/write) 146940 146940 0 0.0
.bss 89408 88112 -1296 -1.4
.data 992 992 0 0.0
.text 513516 512116 -1400 -0.3
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 849010 846218 -2792 -0.3
bss 87736 86440 -1296 -1.5
noinit 37160 37160 0 0.0
text 593590 592556 -1034 -0.2

@andy31415 andy31415 merged commit ddfa994 into project-chip:master Jan 27, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@tcarmelveilleux @restyled-commits @selissia
Make BasicInformationCluster use AttributeAccessInterface to save RAM (…
681c2c5 
…project-chip#13885)

* Make basic info cluster use AttributeAccessInterface

* ZAP file changes

* Generated files

* Regen zap with External more places

* Fix lack of default value in all-clusters-app

* Restyled by clang-format

* ZAP regen

* Revert Location to RAM to diagnose CI

* Update location attribute usage, empty is illegal

* Fix conflicts and zap regen

* Fix error code returned by location

* Restyled

* Add CI debugging

* Restyled by clang-format

* Fix InvalidValue usage

* Regen zap

* Fix productName

* Fix location access on Darwin

* Fix file save failure caused by restyle-diff.sh

* Go back to external on location

* Zap regen

* Regen ZAP

* Fix Cirque

* ZAP regen

Co-authored-by: Restyled.io <[email protected]>
@mkardous-silabs mkardous-silabs mentioned this pull request Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt left review comments

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@carol-apple carol-apple carol-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@cecille cecille cecille approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller darwin examples linux platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tcarmelveilleux @woody-apple @msandstedt @cecille @carol-apple @bzbarsky-apple @jmartinez-silabs @andy31415 @restyled-commits