Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We Seem to Have Consensus on Not Checking In Commented Out or #if 0ed Code; Document That #1533

Merged
merged 1 commit into from
Jul 9, 2020
Merged

We Seem to Have Consensus on Not Checking In Commented Out or #if 0ed Code; Document That #1533

merged 1 commit into from
Jul 9, 2020

Conversation

gerickson
Copy link
Contributor

@gerickson gerickson commented Jul 9, 2020 •
edited
Loading

Problem

Consistent across pull request reviews for the last several months is consensus against checking in commented out or #if 0ed code. Document that fact.

Summary of Changes

Added 'Common > Language-independent > Commenting Out or Disabling Code'.

Fixes #1532

@gerickson
Copy link
Contributor Author

No idea why ESP32 builds are failing for an AsciiDoc change. From the build failures, the failures seem completely unrelated.

@andy31415
Copy link
Contributor

No idea why ESP32 builds are failing for an AsciiDoc change. From the build failures, the failures seem completely unrelated.

Unfortunate timing for master sync - if you remerge master this should work. Interestingly enough I asked for 'rerun all checks' and CI did not pass ... so I guess you need a merge to fix it.

@gerickson
Copy link
Contributor Author

No idea why ESP32 builds are failing for an AsciiDoc change. From the build failures, the failures seem completely unrelated.

Unfortunate timing for master sync - if you remerge master this should work. Interestingly enough I asked for 'rerun all checks' and CI did not pass ... so I guess you need a merge to fix it.

That did it, thanks.

@gerickson gerickson force-pushed the user/gerickson/github-issue-1532 branch from da28c64 to 524ae80 Compare July 9, 2020 17:32
@woody-apple woody-apple merged commit e836139 into project-chip:master Jul 9, 2020
@gerickson gerickson deleted the user/gerickson/github-issue-1532 branch July 10, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@BroderickCarlin BroderickCarlin BroderickCarlin approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We Seem to Have Consensus on Not Checking In Commented Out or #if 0ed Code; Document That
4 participants
@gerickson @andy31415 @BroderickCarlin @woody-apple