Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We Seem to Have Consensus on Not Checking In Commented Out or #if 0ed Code; Document That #1532

Closed
gerickson opened this issue Jul 9, 2020 · 0 comments · Fixed by #1533
Closed

We Seem to Have Consensus on Not Checking In Commented Out or #if 0ed Code; Document That #1532

gerickson opened this issue Jul 9, 2020 · 0 comments · Fixed by #1533
Assignees
@gerickson

Comments

@gerickson
Copy link
Contributor

Problem

Consistent across pull request reviews for the last several months is consensus against checking in commented out or #if 0ed code. Document that fact.

Proposed Solution

Add something to the project "style" guide to this memorialize this consensus.
@gerickson gerickson self-assigned this Jul 9, 2020
@gerickson gerickson mentioned this issue Jul 9, 2020
Merged
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this issue May 8, 2024
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#1536: Feature/provision 2.0
6d6213b 
Merge in WMN_TOOLS/matter from feature/provision-2.0 to RC_2.3.0-1.3

Squashed commit of the following:

commit 15a5e146bc99d58cd81102bd97a393712b4d0a60
Author: Ricardo Casallas <[email protected]>
Date:   Wed Mar 13 14:14:38 2024 -0400

    Provision 2.0: Code review.

commit ebf550397e22b260f8e2970213e83da934783f08
Author: Ricardo Casallas <[email protected]>
Date:   Tue Feb 27 14:24:36 2024 -0500

    Provision 2.0: Bluetooth channel.
    Provision 2.0: Si917 support.
    Provision 2.0: Image generation automated.
    Provision 2.0: Generator images re-built.
    Provision 2.0: Bugfixes.

commit 92e0e84e7ac5c65ed2406bf99bcd78a9de6f53f7
Author: Louis-Philip Beliveau <[email protected]>
Date:   Thu Feb 1 20:57:10 2024 +0000

    Pull request project-chip#1532: Compiled apps

    Merge in WMN_TOOLS/matter from feature/compiled_apps to draft/provision-2.0

    Squashed commit of the following:

    commit bfe6d18c5a26230e1439cc556b4f18fe2d9c5b24
    Author: lpbeliveau-silabs <[email protected]>
    Date:   Thu Feb 1 14:22:09 2024 -0500

        Added examples for all examples tested to for provisioning versions

... and 5 more commits
rcasallas-silabs added a commit to rcasallas-silabs/connectedhomeip that referenced this issue Jun 20, 2024
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#1536: Feature/provision 2.0
79fb7e4 
Merge in WMN_TOOLS/matter from feature/provision-2.0 to RC_2.3.0-1.3

Squashed commit of the following:

commit 15a5e146bc99d58cd81102bd97a393712b4d0a60
Author: Ricardo Casallas <[email protected]>
Date:   Wed Mar 13 14:14:38 2024 -0400

    Provision 2.0: Code review.

commit ebf550397e22b260f8e2970213e83da934783f08
Author: Ricardo Casallas <[email protected]>
Date:   Tue Feb 27 14:24:36 2024 -0500

    Provision 2.0: Bluetooth channel.
    Provision 2.0: Si917 support.
    Provision 2.0: Image generation automated.
    Provision 2.0: Generator images re-built.
    Provision 2.0: Bugfixes.

commit 92e0e84e7ac5c65ed2406bf99bcd78a9de6f53f7
Author: Louis-Philip Beliveau <[email protected]>
Date:   Thu Feb 1 20:57:10 2024 +0000

    Pull request project-chip#1532: Compiled apps

    Merge in WMN_TOOLS/matter from feature/compiled_apps to draft/provision-2.0

    Squashed commit of the following:

    commit bfe6d18c5a26230e1439cc556b4f18fe2d9c5b24
    Author: lpbeliveau-silabs <[email protected]>
    Date:   Thu Feb 1 14:22:09 2024 -0500

        Added examples for all examples tested to for provisioning versions

... and 5 more commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerickson gerickson

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@gerickson