Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Use of PasscodeId in the PASESession Class #15318

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Fix Use of PasscodeId in the PASESession Class #15318

merged 1 commit into from
Feb 18, 2022

Conversation

emargolis
Copy link
Contributor

Problem

#15303

Change overview

-- The PasscodeId should be provided by the PASE Session Initiator.
-- The PASE Session Responder should verify that PasscodeId provided
by Initiator matches its local record.

Note:
Currently in the CHIPDeviceController.cpp the default PasscodeId is assigned during Pair() call.
There is TODO: Need to determine how PasscodeId is provided for a non-default case. i.e. ECM

Testing

existing tests

@emargolis emargolis force-pushed the emargolis/feature/pase-session-fix-passcode-id-use branch from 27c9492 to 3554da4 Compare February 17, 2022 19:09
@github-actions
Copy link

github-actions bot commented Feb 17, 2022 •
edited
Loading

PR #15318: Size comparison from 2a826f9 to 3554da4

Increases (20 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 2a826f9 3554da4 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598498 598522 24 0.0
.app_xip_area 502440 502464 24 0.0
lock cyw930739m2evb_01 (read/write) 556646 556670 24 0.0
.app_xip_area 462132 462156 24 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577770 577794 24 0.0
.app_xip_area 473824 473848 24 0.0
efr32 lighting-app BRD4161A (read only) 914536 914568 32 0.0
.text 914528 914560 32 0.0
BRD4161A+rpc (read only) 943228 943260 32 0.0
.text 943220 943252 32 0.0
window-app BRD4161A (read only) 848516 848548 32 0.0
.text 848508 848540 32 0.0
esp32 all-clusters-app c3devkit (read only) 949808 949838 30 0.0
.flash.text 949808 949838 30 0.0
m5stack (read only) 999271 999283 12 0.0
.flash.text 993887 993899 12 0.0
k32w light k32w061+release (read/write) 691784 691800 16 0.0
.text 605688 605704 16 0.0
lock k32w061+release (read/write) 694384 694400 16 0.0
.text 608032 608048 16 0.0
linux chip-tool-ipv6only arm64 (read only) 8650804 8650948 144 0.0
.text 7329924 7330068 144 0.0
thermostat-no-ble arm64 (read only) 2162924 2163036 112 0.0
.text 1810560 1810672 112 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2430164 2430252 88 0.0
.text 1392736 1392824 88 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2391940 2392028 88 0.0
.text 1354512 1354600 88 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2327568 2327656 88 0.0
.text 1290168 1290256 88 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2318404 2318492 88 0.0
.text 1280976 1281064 88 0.0
p6 all-clusters-app default (read/write) 2487800 2487832 32 0.0
.text 1446064 1446096 32 0.0
light-app default (read/write) 2393096 2393128 32 0.0
.text 1351360 1351392 32 0.0
lock-app default (read/write) 2356744 2356760 16 0.0
.text 1315008 1315024 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 877894 877918 24 0.0
text 618338 618364 26 0.0
Full report (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 2a826f9 3554da4 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598498 598522 24 0.0
.app_xip_area 502440 502464 24 0.0
.bss 78756 78756 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556646 556670 24 0.0
.app_xip_area 462132 462156 24 0.0
.bss 77252 77252 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577770 577794 24 0.0
.app_xip_area 473824 473848 24 0.0
.bss 86356 86356 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914536 914568 32 0.0
(read/write) 129504 129504 0 0.0
.bss 127464 127464 0 0.0
.data 2036 2036 0 0.0
.text 914528 914560 32 0.0
BRD4161A+rpc (read only) 943228 943260 32 0.0
(read/write) 146416 146416 0 0.0
.bss 144240 144240 0 0.0
.data 2176 2176 0 0.0
.text 943220 943252 32 0.0
window-app BRD4161A (read only) 848516 848548 32 0.0
(read/write) 127416 127416 0 0.0
.bss 125512 125512 0 0.0
.data 1904 1904 0 0.0
.text 848508 848540 32 0.0
esp32 all-clusters-app c3devkit (read only) 949808 949838 30 0.0
(read/write) 1401602 1401602 0 0.0
.dram0.bss 68504 68504 0 0.0
.dram0.data 14156 14156 0 0.0
.flash.rodata 200040 200040 0 0.0
.flash.text 949808 949838 30 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 999271 999283 12 0.0
(read/write) 466832 466832 0 0.0
.dram0.bss 73640 73640 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227000 227000 0 0.0
.flash.text 993887 993899 12 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691784 691800 16 0.0
.bss 78384 78384 0 0.0
.data 1912 1912 0 0.0
.text 605688 605704 16 0.0
lock k32w061+release (read/write) 694384 694400 16 0.0
.bss 78600 78600 0 0.0
.data 1952 1952 0 0.0
.text 608032 608048 16 0.0
linux chip-tool-ipv6only arm64 (read only) 8650804 8650948 144 0.0
(read/write) 413265 413265 0 0.0
.bss 58961 58961 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 298744 298744 0 0.0
.dynamic 560 560 0 0.0
.got 50552 50552 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 450092 450092 0 0.0
.text 7329924 7330068 144 0.0
thermostat-no-ble arm64 (read only) 2162924 2163036 112 0.0
(read/write) 150753 150753 0 0.0
.bss 67489 67489 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75040 75040 0 0.0
.dynamic 560 560 0 0.0
.got 4208 4208 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 133692 133692 0 0.0
.text 1810560 1810672 112 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2430164 2430252 88 0.0
.bss 195916 195916 0 0.0
.data 5328 5328 0 0.0
.text 1392736 1392824 88 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391940 2392028 88 0.0
.bss 188424 188424 0 0.0
.data 5632 5632 0 0.0
.text 1354512 1354600 88 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2327568 2327656 88 0.0
.bss 187424 187424 0 0.0
.data 5608 5608 0 0.0
.text 1290168 1290256 88 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2318404 2318492 88 0.0
.bss 185972 185972 0 0.0
.data 5440 5440 0 0.0
.text 1280976 1281064 88 0.0
p6 all-clusters-app default (read/write) 2487800 2487832 32 0.0
.bss 124232 124232 0 0.0
.data 2672 2672 0 0.0
.text 1446064 1446096 32 0.0
light-app default (read/write) 2393096 2393128 32 0.0
.bss 113888 113888 0 0.0
.data 2528 2528 0 0.0
.text 1351360 1351392 32 0.0
lock-app default (read/write) 2356744 2356760 16 0.0
.bss 113640 113640 0 0.0
.data 2488 2488 0 0.0
.text 1315008 1315024 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 877894 877918 24 0.0
bss 87496 87496 0 0.0
noinit 37160 37160 0 0.0
text 618338 618364 26 0.0

@andy31415
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the emargolis/feature/pase-session-fix-passcode-id-use branch from 3554da4 to 1a1edc1 Compare February 17, 2022 22:02
@github-actions
Copy link

github-actions bot commented Feb 17, 2022 •
edited
Loading

PR #15318: Size comparison from 37d6208 to 1a1edc1

Increases (39 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 37d6208 1a1edc1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598498 598522 24 0.0
.app_xip_area 502440 502464 24 0.0
lock cyw930739m2evb_01 (read/write) 556646 556670 24 0.0
.app_xip_area 462132 462156 24 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577770 577794 24 0.0
.app_xip_area 473824 473848 24 0.0
efr32 lighting-app BRD4161A (read only) 914536 914568 32 0.0
.text 914528 914560 32 0.0
BRD4161A+rpc (read only) 943228 943260 32 0.0
.text 943220 943252 32 0.0
window-app BRD4161A (read only) 848516 848548 32 0.0
.text 848508 848540 32 0.0
esp32 all-clusters-app c3devkit (read only) 949808 949838 30 0.0
.flash.text 949808 949838 30 0.0
m5stack (read only) 999271 999283 12 0.0
.flash.text 993887 993899 12 0.0
k32w light k32w061+release (read/write) 691784 691800 16 0.0
.text 605688 605704 16 0.0
lock k32w061+release (read/write) 694384 694400 16 0.0
.text 608032 608048 16 0.0
linux all-clusters-app debug (read only) 2381585 2381697 112 0.0
.text 2012290 2012402 112 0.0
bridge-app debug+rpc (read only) 1731293 1731405 112 0.0
.text 1472725 1472837 112 0.0
chip-tool debug (read only) 8922405 8922549 144 0.0
.text 7831397 7831541 144 0.0
chip-tool-ipv6only arm64 (read only) 8650804 8650948 144 0.0
.text 7329924 7330068 144 0.0
door-lock-app debug (read only) 1943041 1943137 96 0.0
.text 1620610 1620706 96 0.0
lighting-app debug+rpc (read only) 2069065 2069161 96 0.0
.text 1747922 1748018 96 0.0
ota-provider-app debug (read only) 1876289 1876401 112 0.0
.text 1566882 1566994 112 0.0
ota-requestor-app debug (read only) 1889049 1889161 112 0.0
.text 1586898 1587010 112 0.0
shell debug (read only) 2356425 2356521 96 0.0
.text 1992194 1992290 96 0.0
thermostat-no-ble arm64 (read only) 2162924 2163036 112 0.0
.text 1810560 1810672 112 0.0
tv-app debug (read only) 2538449 2538593 144 0.0
.text 2166738 2166882 144 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2430164 2430252 88 0.0
.text 1392736 1392824 88 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2391940 2392028 88 0.0
.text 1354512 1354600 88 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2327568 2327656 88 0.0
.text 1290168 1290256 88 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2318404 2318492 88 0.0
.text 1280976 1281064 88 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1022527 1022559 32 0.0
text 699348 699372 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 991835 991867 32 0.0
text 679248 679272 24 0.0
nrf52840dongle_nrf52840 (read/write) 1037343 1037359 16 0.0
text 703216 703240 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 929138 929154 16 0.0
text 614372 614396 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 951403 951419 16 0.0
text 641568 641592 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 858878 858894 16 0.0
text 557372 557396 24 0.0
pump-app nrf52840dk_nrf52840 (read/write) 949851 949867 16 0.0
text 641388 641412 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 945923 945955 32 0.0
text 637628 637652 24 0.0
p6 all-clusters-app default (read/write) 2487800 2487832 32 0.0
.text 1446064 1446096 32 0.0
light-app default (read/write) 2393096 2393128 32 0.0
.text 1351360 1351392 32 0.0
lock-app default (read/write) 2356744 2356760 16 0.0
.text 1315008 1315024 16 0.0
qpg lighting-app qpg6105+debug (read only) 599388 599412 24 0.0
.text 594068 594092 24 0.0
lock-app qpg6105+debug (read only) 565192 565216 24 0.0
.text 559872 559896 24 0.0
telink lighting-app tlsr9518adk80d (read/write) 877894 877918 24 0.0
text 618338 618364 26 0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 37d6208 1a1edc1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598498 598522 24 0.0
.app_xip_area 502440 502464 24 0.0
.bss 78756 78756 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556646 556670 24 0.0
.app_xip_area 462132 462156 24 0.0
.bss 77252 77252 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577770 577794 24 0.0
.app_xip_area 473824 473848 24 0.0
.bss 86356 86356 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914536 914568 32 0.0
(read/write) 129504 129504 0 0.0
.bss 127464 127464 0 0.0
.data 2036 2036 0 0.0
.text 914528 914560 32 0.0
BRD4161A+rpc (read only) 943228 943260 32 0.0
(read/write) 146416 146416 0 0.0
.bss 144240 144240 0 0.0
.data 2176 2176 0 0.0
.text 943220 943252 32 0.0
window-app BRD4161A (read only) 848516 848548 32 0.0
(read/write) 127416 127416 0 0.0
.bss 125512 125512 0 0.0
.data 1904 1904 0 0.0
.text 848508 848540 32 0.0
esp32 all-clusters-app c3devkit (read only) 949808 949838 30 0.0
(read/write) 1401602 1401602 0 0.0
.dram0.bss 68504 68504 0 0.0
.dram0.data 14156 14156 0 0.0
.flash.rodata 200040 200040 0 0.0
.flash.text 949808 949838 30 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 999271 999283 12 0.0
(read/write) 466832 466832 0 0.0
.dram0.bss 73640 73640 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227000 227000 0 0.0
.flash.text 993887 993899 12 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691784 691800 16 0.0
.bss 78384 78384 0 0.0
.data 1912 1912 0 0.0
.text 605688 605704 16 0.0
lock k32w061+release (read/write) 694384 694400 16 0.0
.bss 78600 78600 0 0.0
.data 1952 1952 0 0.0
.text 608032 608048 16 0.0
linux all-clusters-app debug (read only) 2381585 2381697 112 0.0
(read/write) 151104 151104 0 0.0
.bss 65376 65376 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 78696 78696 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 206309 206309 0 0.0
.text 2012290 2012402 112 0.0
bridge-app debug+rpc (read only) 1731293 1731405 112 0.0
(read/write) 94568 94568 0 0.0
.bss 49296 49296 0 0.0
.data 2034 2034 0 0.0
.data.rel.ro 38104 38104 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 142188 142188 0 0.0
.text 1472725 1472837 112 0.0
chip-tool debug (read only) 8922405 8922549 144 0.0
(read/write) 301472 301472 0 0.0
.bss 40712 40712 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 253536 253536 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 473077 473077 0 0.0
.text 7831397 7831541 144 0.0
chip-tool-ipv6only arm64 (read only) 8650804 8650948 144 0.0
(read/write) 413265 413265 0 0.0
.bss 58961 58961 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 298744 298744 0 0.0
.dynamic 560 560 0 0.0
.got 50552 50552 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 450092 450092 0 0.0
.text 7329924 7330068 144 0.0
door-lock-app debug (read only) 1943041 1943137 96 0.0
(read/write) 120536 120536 0 0.0
.bss 51984 51984 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62104 62104 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173522 173522 0 0.0
.text 1620610 1620706 96 0.0
lighting-app debug+rpc (read only) 2069065 2069161 96 0.0
(read/write) 125528 125528 0 0.0
.bss 52992 52992 0 0.0
.data 1400 1400 0 0.0
.data.rel.ro 65616 65616 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 166097 166097 0 0.0
.text 1747922 1748018 96 0.0
ota-provider-app debug (read only) 1876289 1876401 112 0.0
(read/write) 116216 116216 0 0.0
.bss 51840 51840 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 57496 57496 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 158395 158395 0 0.0
.text 1566882 1566994 112 0.0
ota-requestor-app debug (read only) 1889049 1889161 112 0.0
(read/write) 117600 117600 0 0.0
.bss 52256 52256 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 58760 58760 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 152812 152812 0 0.0
.text 1586898 1587010 112 0.0
shell debug (read only) 2356425 2356521 96 0.0
(read/write) 153456 153456 0 0.0
.bss 73696 73696 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73240 73240 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 207378 207378 0 0.0
.text 1992194 1992290 96 0.0
thermostat-no-ble arm64 (read only) 2162924 2163036 112 0.0
(read/write) 150753 150753 0 0.0
.bss 67489 67489 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75040 75040 0 0.0
.dynamic 560 560 0 0.0
.got 4208 4208 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 133692 133692 0 0.0
.text 1810560 1810672 112 0.0
tv-app debug (read only) 2538449 2538593 144 0.0
(read/write) 151456 151456 0 0.0
.bss 69184 69184 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 198349 198349 0 0.0
.text 2166738 2166882 144 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2430164 2430252 88 0.0
.bss 195916 195916 0 0.0
.data 5328 5328 0 0.0
.text 1392736 1392824 88 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391940 2392028 88 0.0
.bss 188424 188424 0 0.0
.data 5632 5632 0 0.0
.text 1354512 1354600 88 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2327568 2327656 88 0.0
.bss 187424 187424 0 0.0
.data 5608 5608 0 0.0
.text 1290168 1290256 88 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2318404 2318492 88 0.0
.bss 185972 185972 0 0.0
.data 5440 5440 0 0.0
.text 1280976 1281064 88 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1022527 1022559 32 0.0
bss 123524 123524 0 0.0
rodata 120636 120636 0 0.0
text 699348 699372 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 991835 991867 32 0.0
bss 120712 120712 0 0.0
rodata 112176 112176 0 0.0
text 679248 679272 24 0.0
nrf52840dongle_nrf52840 (read/write) 1037343 1037359 16 0.0
bss 124744 124744 0 0.0
rodata 119464 119464 0 0.0
text 703216 703240 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 929138 929154 16 0.0
bss 120084 120084 0 0.0
rodata 113892 113892 0 0.0
text 614372 614396 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 951403 951419 16 0.0
bss 121752 121752 0 0.0
rodata 109472 109472 0 0.0
text 641568 641592 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 858878 858894 16 0.0
bss 118344 118344 0 0.0
rodata 102640 102640 0 0.0
text 557372 557396 24 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 949851 949867 16 0.0
bss 121472 121472 0 0.0
rodata 108424 108424 0 0.0
text 641388 641412 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 945923 945955 32 0.0
bss 121476 121476 0 0.0
rodata 108120 108120 0 0.0
text 637628 637652 24 0.0
shell nrf52840dk_nrf52840 (read/write) 810767 810767 0 0.0
bss 113324 113324 0 0.0
rodata 79348 79348 0 0.0
text 540444 540444 0 0.0
p6 all-clusters-app default (read/write) 2487800 2487832 32 0.0
.bss 124232 124232 0 0.0
.data 2672 2672 0 0.0
.text 1446064 1446096 32 0.0
light-app default (read/write) 2393096 2393128 32 0.0
.bss 113888 113888 0 0.0
.data 2528 2528 0 0.0
.text 1351360 1351392 32 0.0
lock-app default (read/write) 2356744 2356760 16 0.0
.bss 113640 113640 0 0.0
.data 2488 2488 0 0.0
.text 1315008 1315024 16 0.0
qpg lighting-app qpg6105+debug (read only) 599388 599412 24 0.0
(read/write) 146940 146940 0 0.0
.bss 90944 90944 0 0.0
.data 1112 1112 0 0.0
.text 594068 594092 24 0.0
lock-app qpg6105+debug (read only) 565192 565216 24 0.0
(read/write) 146940 146940 0 0.0
.bss 90952 90952 0 0.0
.data 1064 1064 0 0.0
.text 559872 559896 24 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877894 877918 24 0.0
bss 87496 87496 0 0.0
noinit 37160 37160 0 0.0
text 618338 618364 26 0.0

@emargolis
Fix Use of PasscodeId in the PASESession Class
2923bfa 
  -- The PasscodeId should be provided by the PASE Session Initiator.
  -- The PASE Session Responder should verify that PasscodeId provided
     by Initiator matches its local record.
@emargolis emargolis force-pushed the emargolis/feature/pase-session-fix-passcode-id-use branch from 1a1edc1 to 2923bfa Compare February 18, 2022 02:56
@github-actions
Copy link

github-actions bot commented Feb 18, 2022 •
edited
Loading

PR #15318: Size comparison from 4394fcb to 2923bfa

Increases (39 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4394fcb 2923bfa change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599210 599234 24 0.0
.app_xip_area 503136 503160 24 0.0
lock cyw930739m2evb_01 (read/write) 557246 557270 24 0.0
.app_xip_area 462716 462740 24 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578482 578506 24 0.0
.app_xip_area 474528 474552 24 0.0
efr32 lighting-app BRD4161A (read only) 916128 916160 32 0.0
.text 916120 916152 32 0.0
BRD4161A+rpc (read only) 944852 944868 16 0.0
.text 944844 944860 16 0.0
window-app BRD4161A (read only) 849968 850000 32 0.0
.text 849960 849992 32 0.0
esp32 all-clusters-app c3devkit (read only) 950320 950350 30 0.0
.flash.text 950320 950350 30 0.0
m5stack (read only) 999831 999843 12 0.0
.flash.text 994447 994459 12 0.0
k32w light k32w061+release (read/write) 692384 692416 32 0.0
.text 606280 606312 32 0.0
lock k32w061+release (read/write) 694940 694956 16 0.0
.text 608580 608596 16 0.0
linux all-clusters-app debug (read only) 2385801 2385897 96 0.0
.text 2015202 2015298 96 0.0
bridge-app debug+rpc (read only) 1734709 1734805 96 0.0
.text 1475141 1475237 96 0.0
chip-tool debug (read only) 8987901 8988045 144 0.0
.text 7855589 7855733 144 0.0
chip-tool-ipv6only arm64 (read only) 8713540 8713684 144 0.0
.text 7351636 7351780 144 0.0
door-lock-app debug (read only) 1946777 1946873 96 0.0
.text 1623074 1623170 96 0.0
lighting-app debug+rpc (read only) 2073265 2073361 96 0.0
.text 1750818 1750914 96 0.0
ota-provider-app debug (read only) 1880233 1880329 96 0.0
.text 1569522 1569618 96 0.0
ota-requestor-app debug (read only) 1893249 1893361 112 0.0
.text 1589826 1589938 112 0.0
shell debug (read only) 2360673 2360785 112 0.0
.text 1995170 1995282 112 0.0
thermostat-no-ble arm64 (read only) 2167068 2167196 128 0.0
.text 1813536 1813664 128 0.0
tv-app debug (read only) 2542441 2542585 144 0.0
.text 2168978 2169122 144 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2431164 2431252 88 0.0
.text 1393736 1393824 88 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2392940 2393028 88 0.0
.text 1355512 1355600 88 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2328448 2328536 88 0.0
.text 1291048 1291136 88 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2319340 2319428 88 0.0
.text 1281912 1282000 88 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1023259 1023275 16 0.0
text 699800 699824 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 992555 992587 32 0.0
text 679700 679724 24 0.0
nrf52840dongle_nrf52840 (read/write) 1037999 1038031 32 0.0
text 703612 703636 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 929854 929886 32 0.0
text 614824 614848 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 952023 952039 16 0.0
text 641916 641940 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859486 859518 32 0.0
text 557716 557740 24 0.0
pump-app nrf52840dk_nrf52840 (read/write) 950599 950615 16 0.0
text 641736 641760 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 946547 946579 32 0.0
text 637976 638000 24 0.0
p6 all-clusters-app default (read/write) 2489272 2489304 32 0.0
.text 1447536 1447568 32 0.0
light-app default (read/write) 2394536 2394568 32 0.0
.text 1352800 1352832 32 0.0
lock-app default (read/write) 2358112 2358128 16 0.0
.text 1316376 1316392 16 0.0
qpg lighting-app qpg6105+debug (read only) 600036 600060 24 0.0
.text 594716 594740 24 0.0
lock-app qpg6105+debug (read only) 565804 565828 24 0.0
.text 560484 560508 24 0.0
telink lighting-app tlsr9518adk80d (read/write) 878638 878662 24 0.0
text 618800 618826 26 0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4394fcb 2923bfa change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599210 599234 24 0.0
.app_xip_area 503136 503160 24 0.0
.bss 78772 78772 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557246 557270 24 0.0
.app_xip_area 462716 462740 24 0.0
.bss 77268 77268 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578482 578506 24 0.0
.app_xip_area 474528 474552 24 0.0
.bss 86364 86364 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916128 916160 32 0.0
(read/write) 129512 129512 0 0.0
.bss 127472 127472 0 0.0
.data 2036 2036 0 0.0
.text 916120 916152 32 0.0
BRD4161A+rpc (read only) 944852 944868 16 0.0
(read/write) 146424 146424 0 0.0
.bss 144248 144248 0 0.0
.data 2176 2176 0 0.0
.text 944844 944860 16 0.0
window-app BRD4161A (read only) 849968 850000 32 0.0
(read/write) 127424 127424 0 0.0
.bss 125520 125520 0 0.0
.data 1904 1904 0 0.0
.text 849960 849992 32 0.0
esp32 all-clusters-app c3devkit (read only) 950320 950350 30 0.0
(read/write) 1401938 1401938 0 0.0
.dram0.bss 68512 68512 0 0.0
.dram0.data 14156 14156 0 0.0
.flash.rodata 200376 200376 0 0.0
.flash.text 950320 950350 30 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 999831 999843 12 0.0
(read/write) 467216 467216 0 0.0
.dram0.bss 73656 73656 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227368 227368 0 0.0
.flash.text 994447 994459 12 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 692384 692416 32 0.0
.bss 78392 78392 0 0.0
.data 1912 1912 0 0.0
.text 606280 606312 32 0.0
lock k32w061+release (read/write) 694940 694956 16 0.0
.bss 78608 78608 0 0.0
.data 1952 1952 0 0.0
.text 608580 608596 16 0.0
linux all-clusters-app debug (read only) 2385801 2385897 96 0.0
(read/write) 151456 151456 0 0.0
.bss 65376 65376 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 207013 207013 0 0.0
.text 2015202 2015298 96 0.0
bridge-app debug+rpc (read only) 1734709 1734805 96 0.0
(read/write) 94856 94856 0 0.0
.bss 49296 49296 0 0.0
.data 2034 2034 0 0.0
.data.rel.ro 38376 38376 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 142732 142732 0 0.0
.text 1475141 1475237 96 0.0
chip-tool debug (read only) 8987901 8988045 144 0.0
(read/write) 319568 319568 0 0.0
.bss 40728 40728 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 271624 271624 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 474037 474037 0 0.0
.text 7855589 7855733 144 0.0
chip-tool-ipv6only arm64 (read only) 8713540 8713684 144 0.0
(read/write) 431377 431377 0 0.0
.bss 58977 58977 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 316816 316816 0 0.0
.dynamic 560 560 0 0.0
.got 50568 50568 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 450444 450444 0 0.0
.text 7351636 7351780 144 0.0
door-lock-app debug (read only) 1946777 1946873 96 0.0
(read/write) 120952 120952 0 0.0
.bss 52016 52016 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62488 62488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 174194 174194 0 0.0
.text 1623074 1623170 96 0.0
lighting-app debug+rpc (read only) 2073265 2073361 96 0.0
(read/write) 125944 125944 0 0.0
.bss 53024 53024 0 0.0
.data 1400 1400 0 0.0
.data.rel.ro 65984 65984 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 166801 166801 0 0.0
.text 1750818 1750914 96 0.0
ota-provider-app debug (read only) 1880233 1880329 96 0.0
(read/write) 116568 116568 0 0.0
.bss 51872 51872 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 57816 57816 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 159099 159099 0 0.0
.text 1569522 1569618 96 0.0
ota-requestor-app debug (read only) 1893249 1893361 112 0.0
(read/write) 117952 117952 0 0.0
.bss 52288 52288 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 59080 59080 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 153484 153484 0 0.0
.text 1589826 1589938 112 0.0
shell debug (read only) 2360673 2360785 112 0.0
(read/write) 153872 153872 0 0.0
.bss 73728 73728 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73632 73632 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 208050 208050 0 0.0
.text 1995170 1995282 112 0.0
thermostat-no-ble arm64 (read only) 2167068 2167196 128 0.0
(read/write) 151137 151137 0 0.0
.bss 67505 67505 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75384 75384 0 0.0
.dynamic 560 560 0 0.0
.got 4224 4224 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 134060 134060 0 0.0
.text 1813536 1813664 128 0.0
tv-app debug (read only) 2542441 2542585 144 0.0
(read/write) 152064 152064 0 0.0
.bss 69248 69248 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73576 73576 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 199117 199117 0 0.0
.text 2168978 2169122 144 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2431164 2431252 88 0.0
.bss 195924 195924 0 0.0
.data 5328 5328 0 0.0
.text 1393736 1393824 88 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2392940 2393028 88 0.0
.bss 188432 188432 0 0.0
.data 5632 5632 0 0.0
.text 1355512 1355600 88 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2328448 2328536 88 0.0
.bss 187432 187432 0 0.0
.data 5608 5608 0 0.0
.text 1291048 1291136 88 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319340 2319428 88 0.0
.bss 185980 185980 0 0.0
.data 5440 5440 0 0.0
.text 1281912 1282000 88 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1023259 1023275 16 0.0
bss 123532 123532 0 0.0
rodata 120904 120904 0 0.0
text 699800 699824 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 992555 992587 32 0.0
bss 120720 120720 0 0.0
rodata 112448 112448 0 0.0
text 679700 679724 24 0.0
nrf52840dongle_nrf52840 (read/write) 1037999 1038031 32 0.0
bss 124752 124752 0 0.0
rodata 119736 119736 0 0.0
text 703612 703636 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 929854 929886 32 0.0
bss 120092 120092 0 0.0
rodata 114160 114160 0 0.0
text 614824 614848 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 952023 952039 16 0.0
bss 121760 121760 0 0.0
rodata 109740 109740 0 0.0
text 641916 641940 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859486 859518 32 0.0
bss 118352 118352 0 0.0
rodata 102912 102912 0 0.0
text 557716 557740 24 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 950599 950615 16 0.0
bss 121480 121480 0 0.0
rodata 108692 108692 0 0.0
text 641736 641760 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 946547 946579 32 0.0
bss 121484 121484 0 0.0
rodata 108392 108392 0 0.0
text 637976 638000 24 0.0
shell nrf52840dk_nrf52840 (read/write) 811335 811335 0 0.0
bss 113328 113328 0 0.0
rodata 79676 79676 0 0.0
text 540684 540684 0 0.0
p6 all-clusters-app default (read/write) 2489272 2489304 32 0.0
.bss 124240 124240 0 0.0
.data 2672 2672 0 0.0
.text 1447536 1447568 32 0.0
light-app default (read/write) 2394536 2394568 32 0.0
.bss 113896 113896 0 0.0
.data 2528 2528 0 0.0
.text 1352800 1352832 32 0.0
lock-app default (read/write) 2358112 2358128 16 0.0
.bss 113648 113648 0 0.0
.data 2488 2488 0 0.0
.text 1316376 1316392 16 0.0
qpg lighting-app qpg6105+debug (read only) 600036 600060 24 0.0
(read/write) 146940 146940 0 0.0
.bss 90952 90952 0 0.0
.data 1112 1112 0 0.0
.text 594716 594740 24 0.0
lock-app qpg6105+debug (read only) 565804 565828 24 0.0
(read/write) 146940 146940 0 0.0
.bss 90960 90960 0 0.0
.data 1064 1064 0 0.0
.text 560484 560508 24 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 878638 878662 24 0.0
bss 87504 87504 0 0.0
noinit 37160 37160 0 0.0
text 618800 618826 26 0.0

@andy31415 andy31415 merged commit 8a5032d into project-chip:master Feb 18, 2022
@bluebin14 bluebin14 mentioned this pull request Feb 18, 2022
Closed
@bzbarsky-apple bzbarsky-apple mentioned this pull request Feb 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlepage-google mlepage-google mlepage-google approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emargolis @andy31415 @bzbarsky-apple @mlepage-google