Skip to content

Commit

Permalink
Revert "[QPG] Fix shell app (#15094)" (#15321)
Browse files Browse the repository at this point in the history
ToT QPG buiulds failed with `AttributePathExpandIterator.cpp` link
errors after this commit (even though PR checks were green).

This reverts commit 2a826f9.
  • Loading branch information
andy31415 authored Feb 17, 2022
1 parent c61251e commit 37d6208
Show file tree
Hide file tree
Showing 12 changed files with 20 additions and 591 deletions.
8 changes: 0 additions & 8 deletions .github/workflows/examples-qpg.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,6 @@ jobs:
qpg qpg6105+debug lighting-app \
out/lighting_app_debug/chip-qpg6105-lighting-example.out \
/tmp/bloat_reports/
- name: Build example QPG6105 Shell App
timeout-minutes: 5
run: |
scripts/examples/gn_build_example.sh examples/shell/qpg out/shell_app_debug qpg_target_ic=\"qpg6105\"
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
qpg qpg6105+debug shell-app \
out/shell_app_debug/chip-qpg6105-shell-example.out \
/tmp/bloat_reports/
- name: Build example QPG6105 persistent-storage
timeout-minutes: 5
run: |
Expand Down
5 changes: 2 additions & 3 deletions config/qpg/chip-gn/args.gni
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,8 @@ chip_mdns = "platform"
# INCLUDE_xSemaphoreGetMutexHolder
chip_stack_lock_tracking = "none"

# Using lighting-app as template config
# Application specific override to be done as cmd line arg
chip_project_config_include_dirs = [ "//examples/lighting-app/qpg/include" ]
chip_project_config_include_dirs =
[ "//examples/platform/qpg/project_include/" ]
chip_project_config_include = "<CHIPProjectConfig.h>"
chip_system_project_config_include = "<CHIPProjectConfig.h>"
chip_ble_project_config_include = ""
Expand Down
5 changes: 3 additions & 2 deletions examples/lighting-app/qpg/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,15 @@ if (chip_enable_pw_rpc) {

assert(current_os == "freertos")

qpg_project_dir = "${chip_root}/examples/lighting-app/qpg"
examples_plat_dir = "${chip_root}/examples/platform/qpg"

qpg_sdk("sdk") {
sources = [ "${examples_plat_dir}/project_include/CHIPProjectConfig.h" ]

include_dirs = [
"${chip_root}/src/platform/qpg",
"${examples_plat_dir}",
"${qpg_project_dir}/include",
"${examples_plat_dir}/project_include",
]

if (chip_enable_pw_rpc) {
Expand Down
188 changes: 0 additions & 188 deletions examples/lighting-app/qpg/include/CHIPProjectConfig.h

This file was deleted.

5 changes: 3 additions & 2 deletions examples/lock-app/qpg/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,15 @@ if (chip_enable_pw_rpc) {

assert(current_os == "freertos")

qpg_project_dir = "${chip_root}/examples/lock-app/qpg"
examples_plat_dir = "${chip_root}/examples/platform/qpg"

qpg_sdk("sdk") {
sources = [ "${examples_plat_dir}/project_include/CHIPProjectConfig.h" ]

include_dirs = [
"${chip_root}/src/platform/qpg",
"${examples_plat_dir}",
"${qpg_project_dir}/include",
"${examples_plat_dir}/project_include",
]

if (chip_enable_pw_rpc) {
Expand Down
Loading

0 comments on commit 37d6208

Please sign in to comment.