-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32]: Fix initialization order of ota-requestor and ota-provider apps #15179
Merged
woody-apple
merged 1 commit into
project-chip:master
from
shubhamdp:esp32_fix_init_order
Feb 15, 2022
Merged
[ESP32]: Fix initialization order of ota-requestor and ota-provider apps #15179
woody-apple
merged 1 commit into
project-chip:master
from
shubhamdp:esp32_fix_init_order
Feb 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov and
LuDuda
February 15, 2022 04:11
pullapprove
bot
requested review from
mlepage-google,
msandstedt,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
February 15, 2022 04:11
PR #15179: Size comparison from 6ad78e2 to d0d7791 Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
dhrishi
approved these changes
Feb 15, 2022
bzbarsky-apple
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely, this should solve the threading problems this code had, too!
/rebase |
Also, fixed the wrong API being called in ESP32 OTA image processor implementation
woody-apple
force-pushed
the
esp32_fix_init_order
branch
from
February 15, 2022 07:10
d0d7791
to
874e2d3
Compare
PR #15179: Size comparison from a35b95a to 874e2d3 Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jamesluo11
pushed a commit
to jamesluo11/connectedhomeip
that referenced
this pull request
Apr 26, 2022
…pps (project-chip#15179) Also, fixed the wrong API being called in ESP32 OTA image processor implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is the regression introduces in #14946 while fixing the network commissioning.
Change overview
Testing
Tested manually