-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Make apps commissionable #14946
Merged
andy31415
merged 1 commit into
project-chip:master
from
shubhamdp:esp32_fix_commissioning_in_apps
Feb 9, 2022
Merged
[ESP32] Make apps commissionable #14946
andy31415
merged 1 commit into
project-chip:master
from
shubhamdp:esp32_fix_commissioning_in_apps
Feb 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridge-app, lighting-app, lock-app, ota-provider-app, and ota-requestor-app reports being a thread device. These apps do not use the newer Network commissioning API.
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
msandstedt,
mspang and
robszewczyk
February 9, 2022 10:07
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
February 9, 2022 10:07
PR #14946: Size comparison from 8ce90ac to e939831 Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Feb 9, 2022
gjc13
approved these changes
Feb 9, 2022
dhrishi
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bridge-app, lighting-app, lock-app, ota-provider-app, and
ota-requestor-app reports being a thread device.
These apps do not use the newer Network commissioning API.
Problem
Unable to commission bridge-app, lighting-app, lock-app, ota-provider-app, and ota-requestor-app.
Change overview
Initialized the network commissioning instance
Adapting changes from #14913
Testing
Tested commissioning on these apps using chip-tool