Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESP32] Make apps commissionable #14946

Merged

Conversation

shubhamdp
Copy link
Contributor

@shubhamdp shubhamdp commented Feb 9, 2022

bridge-app, lighting-app, lock-app, ota-provider-app, and
ota-requestor-app reports being a thread device.
These apps do not use the newer Network commissioning API.

Problem

Unable to commission bridge-app, lighting-app, lock-app, ota-provider-app, and ota-requestor-app.

Change overview

Initialized the network commissioning instance
Adapting changes from #14913

Testing

Tested commissioning on these apps using chip-tool

bridge-app, lighting-app, lock-app, ota-provider-app, and
ota-requestor-app reports being a thread device.
These apps do not use the newer Network commissioning API.
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

PR #14946: Size comparison from 8ce90ac to e939831

Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 8ce90ac e939831 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595374 595374 0 0.0
.app_xip_area 500908 500908 0 0.0
.bss 77188 77188 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556326 556326 0 0.0
.app_xip_area 463396 463396 0 0.0
.bss 75684 75684 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577226 577226 0 0.0
.app_xip_area 475048 475048 0 0.0
.bss 84604 84604 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 866532 866532 0 0.0
(read/write) 126684 126684 0 0.0
.bss 124760 124760 0 0.0
.data 1924 1924 0 0.0
.text 866524 866524 0 0.0
BRD4161A+rpc (read only) 853996 853996 0 0.0
(read/write) 143344 143344 0 0.0
.bss 141320 141320 0 0.0
.data 2024 2024 0 0.0
.text 853988 853988 0 0.0
window-app BRD4161A (read only) 838752 838752 0 0.0
(read/write) 125328 125328 0 0.0
.bss 123448 123448 0 0.0
.data 1880 1880 0 0.0
.text 838744 838744 0 0.0
esp32 all-clusters-app c3devkit (read only) 938970 938970 0 0.0
(read/write) 1397658 1397658 0 0.0
.dram0.bss 66328 66328 0 0.0
.dram0.data 14260 14260 0 0.0
.flash.rodata 198160 198160 0 0.0
.flash.text 938970 938970 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 987163 987163 0 0.0
(read/write) 462680 462680 0 0.0
.dram0.bss 71472 71472 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 225056 225056 0 0.0
.flash.text 981779 981779 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679116 679116 0 0.0
.bss 76584 76584 0 0.0
.data 1884 1884 0 0.0
.text 594848 594848 0 0.0
lock k32w061+release (read/write) 683996 683996 0 0.0
.bss 76984 76984 0 0.0
.data 1928 1928 0 0.0
.text 599284 599284 0 0.0
linux all-clusters-app debug (read only) 2329273 2329273 0 0.0
(read/write) 140032 140032 0 0.0
.bss 54656 54656 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 78536 78536 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 204453 204453 0 0.0
.text 1962594 1962594 0 0.0
bridge-app debug+rpc (read only) 1705829 1705829 0 0.0
(read/write) 84328 84328 0 0.0
.bss 39088 39088 0 0.0
.data 1970 1970 0 0.0
.data.rel.ro 38120 38120 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 140332 140332 0 0.0
.text 1448949 1448949 0 0.0
chip-tool debug (read only) 7466349 7466349 0 0.0
(read/write) 197176 197176 0 0.0
.bss 32360 32360 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 157624 157624 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 414773 414773 0 0.0
.text 6651141 6651141 0 0.0
chip-tool-ipv6only arm64 (read only) 7390428 7390428 0 0.0
(read/write) 301313 301313 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 199304 199304 0 0.0
.dynamic 560 560 0 0.0
.got 46400 46400 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 397252 397252 0 0.0
.text 6355892 6355892 0 0.0
door-lock-app debug (read only) 1910537 1910537 0 0.0
(read/write) 110680 110680 0 0.0
.bss 42160 42160 0 0.0
.data 946 946 0 0.0
.data.rel.ro 62160 62160 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171858 171858 0 0.0
.text 1590162 1590162 0 0.0
lighting-app debug+rpc (read only) 2005097 2005097 0 0.0
(read/write) 115632 115632 0 0.0
.bss 43104 43104 0 0.0
.data 1368 1368 0 0.0
.data.rel.ro 65672 65672 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 163057 163057 0 0.0
.text 1687394 1687394 0 0.0
ota-provider-app debug (read only) 1714521 1714521 0 0.0
(read/write) 81368 81368 0 0.0
.bss 41120 41120 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 33560 33560 0 0.0
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151910 151910 0 0.0
.text 1443906 1443906 0 0.0
ota-requestor-app debug (read only) 1709145 1709145 0 0.0
(read/write) 83288 83288 0 0.0
.bss 42240 42240 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 34616 34616 0 0.0
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 145495 145495 0 0.0
.text 1446754 1446754 0 0.0
shell debug (read only) 2302729 2302729 0 0.0
(read/write) 141584 141584 0 0.0
.bss 62048 62048 0 0.0
.data 768 768 0 0.0
.data.rel.ro 73072 73072 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205170 205170 0 0.0
.text 1941138 1941138 0 0.0
thermostat-no-ble arm64 (read only) 2131052 2131052 0 0.0
(read/write) 140673 140673 0 0.0
.bss 57665 57665 0 0.0
.data 984 984 0 0.0
.data.rel.ro 74904 74904 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132108 132108 0 0.0
.text 1780880 1780880 0 0.0
tv-app debug (read only) 2503193 2503193 0 0.0
(read/write) 139512 139512 0 0.0
.bss 57280 57280 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73048 73048 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 196140 196140 0 0.0
.text 2134114 2134114 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389944 2389944 0 0.0
.bss 188404 188404 0 0.0
.data 5280 5280 0 0.0
.text 1352544 1352544 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349448 2349448 0 0.0
.bss 181000 181000 0 0.0
.data 5600 5600 0 0.0
.text 1312048 1312048 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317408 2317408 0 0.0
.bss 180912 180912 0 0.0
.data 5584 5584 0 0.0
.text 1280008 1280008 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303340 2303340 0 0.0
.bss 178164 178164 0 0.0
.data 5400 5400 0 0.0
.text 1265912 1265912 0 0.0
p6 all-clusters-app default (read/write) 2476616 2476616 0 0.0
.bss 117656 117656 0 0.0
.data 2632 2632 0 0.0
.text 1434880 1434880 0 0.0
light-app default (read/write) 2380312 2380312 0 0.0
.bss 107296 107296 0 0.0
.data 2496 2496 0 0.0
.text 1338576 1338576 0 0.0
lock-app default (read/write) 2349136 2349136 0 0.0
.bss 107040 107040 0 0.0
.data 2464 2464 0 0.0
.text 1307400 1307400 0 0.0
qpg lighting-app qpg6105+debug (read only) 586320 586320 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88872 88872 0 0.0
.data 1084 1084 0 0.0
.text 581000 581000 0 0.0
lock-app qpg6105+debug (read only) 535316 535316 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88392 88392 0 0.0
.data 1028 1028 0 0.0
.text 529996 529996 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 866774 866774 0 0.0
bss 88664 88664 0 0.0
noinit 37160 37160 0 0.0
text 608368 608368 0 0.0

@andy31415 andy31415 merged commit 90c8884 into project-chip:master Feb 9, 2022
@shubhamdp shubhamdp deleted the esp32_fix_commissioning_in_apps branch February 9, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants