Compile-time generation for CHIPClusters-JNI.cpp #15171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinh0
force-pushed
the
move_clusters_to_compile_gen
branch
from
c399e46 to
2585e90
Compare
|
PR #15171: Size comparison from d1c7e85 to 2585e90 Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs and
kpschoedel
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
andy31415
approved these changes
Feb 15, 2022
|
PR #15171: Size comparison from 101ff17 to 41b8563 Full report (41 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
mrjerryjohns
approved these changes
Feb 15, 2022
electrocucaracha
approved these changes
Feb 15, 2022
bzbarsky-apple
approved these changes
Feb 15, 2022
|
File splitting seems to have done the trick for RAM but now the runner is running out of disk space. Will put up another fix |
jamesluo11
pushed a commit
to jamesluo11/connectedhomeip
that referenced
this pull request
Apr 26, 2022
* Compile-time generation for CHIPClusters-JNI.cpp * Split Android-generated CHIPClusters.cpp into per-cluster files * Restyled by whitespace * Restyled by clang-format * Update tests Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CHIPClusters-JNI.cpp causing CI to hit OOM. Compile-time generation is the first step in splitting into per-cluster generated files.
Change overview
Move code generation to build-time for CHIPClusters-JNI. Same as #14519 with minor fixes (check optional correctly in
boxed_java_signatureandFieldToGlobalName) and updated to latest master.What's in this PR
Testing
Ran diff after ./scripts/codegen.py --generator java --output-dir ./out/java_test_gen/ src/controller/data_model/controller-clusters.matter && clang-format -i out/java_test_gen/jni/CHIPClusters.cpp
The files were the same EXCEPT: 'license blurb' and some newlines in between method definition (had a hard time matching empty lines, was unsure if worth it).