Refine SessionManager logs #15086
Merged
Refine SessionManager logs #15086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
robszewczyk
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #15086: Size comparison from 512ab16 to aee46a4 Increases (5 builds for cyw30739, qpg)
Decreases (18 builds for efr32, k32w, linux, mbed, p6, telink)
Full report (31 builds for cyw30739, efr32, k32w, linux, mbed, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 12, 2022
kghost
force-pushed
the
transport-logs
branch
from
aee46a4 to
dd1abed
Compare
|
PR #15086: Size comparison from 3828308 to dd1abed Increases (1 build for esp32)
Decreases (28 builds for efr32, esp32, linux, nrfconnect, p6, telink)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
reviewed
Feb 16, 2022
andy31415
reviewed
Feb 16, 2022
andy31415
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Log changes seem ok, but wondering it this is worth some boy/girl scout approach and fixing this while touching (same PR or followup since we are looking at the code):
- why do we have a
Diein a method that can return a CHIP_ERROR ? - Why do we use an enum of Yes/No instead of a bool that is built into the language. I understand enums to pass into function methods (so that I don't read
foo(true, false, true)but ratherfoo(EnableFeatureA::Yes, AckRequired::No, MessageType::HighPriority)), but I do not understand them at all inside methods that have names and are basically bools.
That local ends up getting passed to other functions. |
woody-apple
approved these changes
Feb 21, 2022
kghost
force-pushed
the
transport-logs
branch
from
dd1abed to
488abb7
Compare
|
PR #15086: Size comparison from 08d8b9b to 488abb7 Increases (41 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (44 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
kghost
force-pushed
the
transport-logs
branch
from
488abb7 to
fbe32ed
Compare
|
PR #15086: Size comparison from 924c01c to fbe32ed Increases (42 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (45 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The duplicated packet log is not printed correctly in certain condition.
Change overview
Print duplicated packet info when detected, make it more intuitive.
Testing
Passes tests