Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docker images and submodule workflow (was drop repos.conf) #1508

Merged
merged 9 commits into from
Jul 9, 2020

Conversation

rwalker-apple
Copy link
Contributor

@rwalker-apple rwalker-apple commented Jul 8, 2020

Problem

  • git 2.17 (default on ubuntu:bionic)does not support git for github action-based wokflows
  • repos.conf and Makefile-bootstrap are deprecated in favor of git submodules (but are required for the automake-based "distcheck" target to function)

Summary of Changes

  • make repos.conf a symbolic link to .gitmodules, so there's one source of truth for submodules
  • update docker images to be based on ubuntu:focal, which brings current cmake, clang, openssl, and git (which allows github workflows to run on a git repository, and get git submodules)
  • update docs

Rob Walker added 6 commits July 8, 2020 17:41
* rev version to 0.3.0
* fix up build-all.sh to understand the dependencies among the images
@rwalker-apple rwalker-apple changed the title drop repos.conf fail to drop repos.conf Jul 9, 2020
@andy31415
Copy link
Contributor

This also have quite some docker file updates - unsure if PR description actually captures those changes description.

@andy31415
Copy link
Contributor

This also have quite some docker file updates - unsure if PR description actually captures those changes description.

@rwalker-apple I believe a description 'fail to drop repos.conf' may need to be updated if we want to include the whole PR since the change of 'update docker to new ubuntu image' seems to be a important change. Did not yet merge the PR for this reason.

@rwalker-apple rwalker-apple changed the title fail to drop repos.conf update docker images and submodule workflow (was drop repos.conf) Jul 9, 2020
@andy31415 andy31415 merged commit dee9b45 into project-chip:master Jul 9, 2020
@rwalker-apple rwalker-apple deleted the drop-repos.conf branch July 9, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants